Skip to content

Conversation

roblabla
Copy link
Contributor

@roblabla roblabla commented Sep 6, 2024

So, I'm an idiot. I was mostly after a 32-bit win32 objdiff-cli build, but thought (in my previous PR) that the CLI and GUI were built as part of the same step. Oops.

@encounter
Copy link
Owner

I think you'll want i586-windows-pc-msvc for older Windows support. Could you remove the GUI entry as well?

@roblabla
Copy link
Contributor Author

roblabla commented Sep 6, 2024

Unfortunately, old versions of windows-rs don't support the i586 target. So we either need to update all the dependencies that use an old version of windows-rs, or... just use the i686 target. I don't think that matters too much anyways - I won't be running this on an actual Pentium 1, the oldest CPU I have in my possession is a core 2 duo I believe, which is i686-compliant :^).

@encounter
Copy link
Owner

This is the main issue with using i686- if you want to run on older Windows: https://blog.rust-lang.org/2024/02/26/Windows-7.html

Curious what deps were pulling in older windows-rs

@roblabla
Copy link
Contributor Author

roblabla commented Sep 6, 2024

enable-ansi-support pulls windows-sys 0.42.0, which is the oldest offender. There are currently four versions of windows-sys in objdiff workspace: https://github.com/encounter/objdiff/blob/main/Cargo.lock#L5067-L5107

FWIW, using i586-pc-windows-msvc wouldn't help here, it also doesn't support win10- either. For win7+ support, we could use the i686-win7-windows-msvc target (which I happen to be the main maintainer of :^) ). But that's annoying because those targets are tier 3, and as such not available in rustup.

Maybe I should petition to make them tier 2 targets...

@NWPlayer123
Copy link
Contributor

I'm also not sure that enable-ansi-support is that big a deal anyways, it only affects Windows 10+ and only in old-school Command Prompt, PowerShell and the new Terminal are unaffected because they properly handle ANSI codes afaik. I got rid of it in Orthrus since I didn't see much use in keeping it around as a dependency.

@encounter encounter merged commit 7d0d7df into encounter:main Sep 7, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants