Reimplement function data value tooltips, function data value diffing, and data relocation diffing #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reimplements encounter#154 Note that colorizing the text depending on the kind of diff has still not been reimplemented yet
|
Awesome work, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#108 PPC: Guess reloc data type based on the instruction.
#153 Show relocation diffs in function view when the data's content differs
#154 Implement diffing relocations within data sections
For the last one, with the refactored tooltip system there didn't seem to be a clean way to change the text color to green/red for added/removed relocations, so I left that as a TODO for now and it's just always grey instead, but this isn't a big loss, only downside is it's harder to tell at a glance which reloc differs if there are multiple on a single row now.