Skip to content

Commit 5d1cf7d

Browse files
committed
Merge branch 'feature-issue117' #117
* feature-issue117: Fixed a bug with the installer which was always failing. The installer was trying to un/register file "sa.shellextension-d.dll" even if we were building in release.
2 parents 5889b97 + 0d38d4a commit 5d1cf7d

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

CMakeLists.txt

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,14 @@ if(NOT CMAKE_DEBUG_POSTFIX)
156156
set(CMAKE_DEBUG_POSTFIX "-d")
157157
endif()
158158

159+
# Define EXEC_FILENAME_POSTFIX to accurately guess the end of filename of library/executable files
160+
if(CMAKE_BUILD_TYPE STREQUAL "Debug")
161+
set(EXEC_FILENAME_POSTFIX "${CMAKE_DEBUG_POSTFIX}")
162+
else()
163+
set(EXEC_FILENAME_POSTFIX "")
164+
endif()
165+
MESSAGE( STATUS "EXEC_FILENAME_POSTFIX: " ${EXEC_FILENAME_POSTFIX} )
166+
159167
# Prevents annoying warnings on MSVC
160168
if (WIN32)
161169
add_definitions(-D_CRT_SECURE_NO_WARNINGS)

wix/WIX.extra.in

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@
3535
<![CDATA[(&RegistrationFeature=2) AND (!RegistrationFeature=3)]]>
3636
</Custom>
3737
</InstallExecuteSequence>
38-
<CustomAction Id="RegisterFeatureInstall" Return="check" Impersonate="no" Execute="deferred" Directory="CM_DP_bin" ExeCommand="regsvr32.exe /s &quot;[CM_DP_bin]sa.shellextension${CMAKE_DEBUG_POSTFIX}.dll&quot;"/>
39-
<CustomAction Id="UnregisterFeatureUninstall" Return="check" Impersonate="no" Execute="deferred" Directory="CM_DP_bin" ExeCommand="regsvr32.exe /s /u &quot;[CM_DP_bin]sa.shellextension${CMAKE_DEBUG_POSTFIX}.dll&quot;"/>
38+
<CustomAction Id="RegisterFeatureInstall" Return="check" Impersonate="no" Execute="deferred" Directory="CM_DP_bin" ExeCommand="regsvr32.exe /s &quot;[CM_DP_bin]sa.shellextension${EXEC_FILENAME_POSTFIX}.dll&quot;"/>
39+
<CustomAction Id="UnregisterFeatureUninstall" Return="check" Impersonate="no" Execute="deferred" Directory="CM_DP_bin" ExeCommand="regsvr32.exe /s /u &quot;[CM_DP_bin]sa.shellextension${EXEC_FILENAME_POSTFIX}.dll&quot;"/>
4040

4141
<DirectoryRef Id="INSTALL_ROOT">
4242
<Component Id="cmpREGISTRATION" Guid="*">

0 commit comments

Comments
 (0)