Bitmap device-independent (DIP) transparency

Author: GasDauMin

ci/appveyor/install_googletest.bat

@@ -26,7 +26,7 @@ echo Compiling...
 echo ============================================================================
 mkdir build >NUL 2>NUL
 cd build
-cmake -Wno-dev -DCMAKE_GENERATOR_PLATFORM=%Platform% -T %PlatformToolset% -DCMAKE_INSTALL_PREFIX=%GTEST_ROOT% -Dgtest_force_shared_crt=ON -DBUILD_GMOCK=OFF -DBUILD_GTEST=ON ..
+cmake -Wno-dev -DCMAKE_GENERATOR_PLATFORM=%Platform% -T %PlatformToolset% -DCMAKE_INSTALL_PREFIX=%GTEST_ROOT% -Dgtest_force_shared_crt=ON -DBUILD_GMOCK=OFF -DBUILD_GTEST=ON -DCMAKE_CXX_FLAGS=/D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING ..
 if %errorlevel% neq 0 exit /b %errorlevel%
 cmake --build . --config %Configuration%
 if %errorlevel% neq 0 exit /b %errorlevel%

src/Win32Utils.cpp

@@ -157,6 +157,20 @@ namespace Win32Utils
   }
   #endif
 
+  HBITMAP CreateBitmap(int biWidth, int biHeight, UINT biPlanes, UINT biBitCount, HDC hDc)
+  {
+    BITMAPINFO bmi;
+    bmi.bmiHeader.biSize = sizeof(BITMAPINFOHEADER);
+    bmi.bmiHeader.biWidth = biWidth;
+    bmi.bmiHeader.biHeight = biHeight;
+    bmi.bmiHeader.biPlanes = biPlanes;
+    bmi.bmiHeader.biBitCount = biBitCount;
+    bmi.bmiHeader.biCompression = BI_RGB;
+    bmi.bmiHeader.biSizeImage = biWidth * biHeight * 4;
+    VOID* pvBits;
+    return CreateDIBSection(hDc, &bmi, DIB_RGB_COLORS, &pvBits, NULL, 0x0);;
+  }
+
   HBITMAP CopyAsBitmap(HICON hIcon, const int bitmap_width, const int bitmap_height)
   {
     //According to https://devblogs.microsoft.com/oldnewthing/20101021-00/?p=12483, using DrawIconEx()
@@ -194,7 +208,7 @@ namespace Win32Utils
     HDC hDcMem = CreateCompatibleDC(hdcDesktop);
 
     // Create a 32bbp bitmap and select it.
-    HBITMAP hBitmap = CreateBitmap(bitmap_width, bitmap_height, 1, BITS_PER_PIXEL, NULL);
+    HBITMAP hBitmap = CreateBitmap(bitmap_width, bitmap_height, 1, BITS_PER_PIXEL, hDcMem);
     HBITMAP hbmOld = (HBITMAP)SelectObject(hDcMem, hBitmap);
 
   #if 0
@@ -270,7 +284,7 @@ namespace Win32Utils
 
     return hBitmap;
   }
- 
+
   HBITMAP CopyAsBitmap(HICON hIcon)
   {
     //Get properties related to Windows Menu

src/Win32Utils.h

@@ -35,6 +35,7 @@ namespace Win32Utils
   RGBQUAD ToRgbQuad(const DWORD & iColor);
   SIZE GetBitmapSize(HBITMAP hBitmap);
   BOOL FillTransparentPixels(HBITMAP hBitmap, COLORREF background_color);
+  HBITMAP CreateBitmap(int biWidth, int biHeight, UINT biPlanes, UINT biBitCount, HDC hDc);
   HBITMAP CopyAsBitmap(HICON hIcon, const int bitmap_width, const int bitmap_height);
   HBITMAP CopyAsBitmap(HICON hIcon);
   bool CreateBmpFile(const char * path, HBITMAP hBitmap);

src/shellext.cpp

@@ -356,9 +356,11 @@ void CContextMenu::BuildMenuTree(HMENU hMenu, shellanything::Menu * menu, UINT &
         //Convert the icon to a bitmap (with invisible background)
         hBitmap = Win32Utils::CopyAsBitmap(hIcon);
 
+      #if 0
         //Remove the invisible background and replace by the default popup menu color
         COLORREF menu_background_color = GetSysColor(COLOR_MENU);
         Win32Utils::FillTransparentPixels(hBitmap, menu_background_color);
+      #endif
 
         DestroyIcon(hIconLarge);
         DestroyIcon(hIconSmall);

test/TestBitmapCache.cpp

@@ -40,9 +40,11 @@ namespace shellanything { namespace test
     SIZE icon_size = Win32Utils::GetIconSize(hIconLarge);
     HBITMAP hBitmap = Win32Utils::CopyAsBitmap(hIconLarge, icon_size.cx, icon_size.cy);
 
+  #if 0
     //Remove the invisible background and replace by red color
     COLORREF background_color = RGB(255,0,255); //pink
     Win32Utils::FillTransparentPixels(hBitmap, background_color);
+  #endif
 
     DestroyIcon(hIconLarge);
     DestroyIcon(hIconSmall);
@@ -61,9 +63,11 @@ namespace shellanything { namespace test
     SIZE icon_size = Win32Utils::GetIconSize(hIconLarge);
     HBITMAP hBitmap = Win32Utils::CopyAsBitmap(hIconLarge, icon_size.cx, icon_size.cy);
 
+  #if 0
     //Remove the invisible background and replace by red color
     COLORREF background_color = RGB(255,0,255); //pink
     Win32Utils::FillTransparentPixels(hBitmap, background_color);
+  #endif
 
     DestroyIcon(hIconLarge);
     DestroyIcon(hIconSmall);

test/TestWin32Registry.cpp

@@ -234,9 +234,11 @@ namespace shellanything { namespace test
         SIZE icon_size = Win32Utils::GetIconSize(hIconBest);
         HBITMAP hBitmap = Win32Utils::CopyAsBitmap(hIconBest, icon_size.cx, icon_size.cy);
 
+      #if 0
         //Remove the invisible background and replace by red color
         COLORREF background_color = RGB(255,0,255); //pink
         Win32Utils::FillTransparentPixels(hBitmap, background_color);
+      #endif
 
         DestroyIcon(hIconLarge);
         DestroyIcon(hIconSmall);
@@ -319,9 +321,11 @@ namespace shellanything { namespace test
       SIZE icon_size = Win32Utils::GetIconSize(hIconLarge);
       HBITMAP hBitmap = Win32Utils::CopyAsBitmap(hIconLarge, icon_size.cx, icon_size.cy);
 
+    #if 0
       //Remove the invisible background and replace by red color
       COLORREF background_color = RGB(255,0,255); //pink
       Win32Utils::FillTransparentPixels(hBitmap, background_color);
+    #endif
 
       DestroyIcon(hIconLarge);
       DestroyIcon(hIconSmall);

test/TestWin32Utils.cpp

@@ -59,9 +59,11 @@ namespace shellanything { namespace test
       SIZE icon_size = Win32Utils::GetIconSize(hIconLarge);
       HBITMAP hBitmap = Win32Utils::CopyAsBitmap(hIconLarge, icon_size.cx, icon_size.cy);
 
+    #if 0
       //Remove the invisible background and replace by red color
       COLORREF background_color = RGB(255,0,255); //pink
       Win32Utils::FillTransparentPixels(hBitmap, background_color);
+    #endif
 
       DestroyIcon(hIconLarge);
       DestroyIcon(hIconSmall);
@@ -112,10 +114,12 @@ namespace shellanything { namespace test
       SIZE icon_size = Win32Utils::GetIconSize(hIconLarge);
       HBITMAP hBitmap = Win32Utils::CopyAsBitmap(hIconLarge, icon_size.cx, icon_size.cy);
 
+    #if 0
       //Remove the invisible background and replace by red color
       static const COLORREF color_pink  = RGB(255,  0,255);
       static const COLORREF color_white = RGB(255,255,255);
       Win32Utils::FillTransparentPixels(hBitmap, color_pink);
+    #endif
 
       DestroyIcon(hIconLarge);
       DestroyIcon(hIconSmall);