Find coin nodes by their group #58
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Play this branch at https://endlessm.github.io/moddable-platformer/branches/endlessm/push-nstwurnuppst. (This launches the game from the start, not directly at the change(s) in this pull request.) |
wjt
force-pushed
the
push-nstwurnuppst
branch
from
7b3a687 to
646643e
Compare
Previously, game_logic.gd walked recursively over all nodes in the tree, counting those which are an instance of the Coin script. A more idiomatic way to do this is to place coins into a group, and then count how many nodes are in that group. This will also make it easier to have some coins that don't count towards the goal, by having those coins not be in this group.
The bug this was taking advantage of was fixed in Godot 4.4. The property is displayed with a spin control despite this hack. Godot 4.6 will add a new "prefer_slider" hint <https://github.com/godotengine/godot/pull/1104599>. Remove the weird 0.9-coin step, and replace the HACK comment with a TODO for when we update to Godot 4.6.
wjt
force-pushed
the
push-nstwurnuppst
branch
from
646643e to
97d1a24
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, game_logic.gd walked recursively over all nodes in the tree, counting those which are an instance of the Coin script.
A more idiomatic way to do this is to place coins into a group, and then count how many nodes are in that group. This will also make it easier to have some coins that don't count towards the goal, by having those coins not be in this group.