test(ses): repro 2941 errorTrapping bugs

erights · erights · commit 37d8080d8c62 · 2025-08-19T22:10:53.000-07:00
diff --git a/packages/ses/test/error/issue-2941/test1/README.md b/packages/ses/test/error/issue-2941/test1/README.md
@@ -0,0 +1,52 @@
+# repro
+
+---
+
+# `errorTrapping: 'platform'`
+
+In ses/src/test/error/issue-2941/test1/
+1. open error-trapping-platform.js in the browser using `file://` protocol
+2. see
+
+Brave (likely all Chromium):
+
+<img alt="errorTrapping: 'platform'" src="./error-trapping-platform.jpg" />
+
+FireFox (TODO):
+```
+???
+```
+
+---
+
+# `errorTrapping: 'platform', errorTaming: 'safe'`
+
+In ses/src/test/error/issue-2941/test1/
+1. open error-trapping-platform-safe.js in the browser using `file://` protocol
+2. see
+
+Brave (likely all Chromium):
+
+<img alt="errorTrapping: 'platform'" src="./error-trapping-platform-safe.jpg" />
+
+FireFox (TODO):
+```
+???
+```
+
+---
+
+# `errorTrapping: 'none'`
+
+In ses/src/test/error/issue-2941/test1/
+1. open error-trapping-none.js in the browser using `file://` protocol
+2. see
+
+Brave (likely all Chromium):
+
+<img alt="errorTrapping: 'none'" src="./error-trapping-none.jpg" />
+
+FireFox (TODO):
+```
+???
+```
diff --git a/packages/ses/test/error/issue-2941/test1/error-trapping-none.html b/packages/ses/test/error/issue-2941/test1/error-trapping-none.html
@@ -0,0 +1,23 @@
+<!DOCTYPE html>
+<html lang="en">
+
+<head>
+    <meta charset="UTF-8">
+    <meta name="viewport" content="width=device-width, initial-scale=1.0">
+    <title>Document</title>
+    <script src="../../../../dist/ses.cjs"></script>
+    <script>
+        lockdown({
+            errorTaming: 'unsafe',
+            stackFiltering: 'concise',
+            errorTrapping: 'none',
+        })
+
+    </script>
+</head>
+
+<body>
+    <script src="./test.notjs"></script>
+</body>
+
+</html>
diff --git a/packages/ses/test/error/issue-2941/test1/error-trapping-none.jpg b/packages/ses/test/error/issue-2941/test1/error-trapping-none.jpg
diff --git a/packages/ses/test/error/issue-2941/test1/error-trapping-platform-safe.html b/packages/ses/test/error/issue-2941/test1/error-trapping-platform-safe.html
@@ -0,0 +1,23 @@
+<!DOCTYPE html>
+<html lang="en">
+
+<head>
+    <meta charset="UTF-8">
+    <meta name="viewport" content="width=device-width, initial-scale=1.0">
+    <title>Document</title>
+    <script src="../../../../dist/ses.cjs"></script>
+    <script>
+        lockdown({
+            errorTaming: 'safe',
+            stackFiltering: 'concise',
+            errorTrapping: 'platform',
+        })
+
+    </script>
+</head>
+
+<body>
+    <script src="./test.notjs"></script>
+</body>
+
+</html>
diff --git a/packages/ses/test/error/issue-2941/test1/error-trapping-platform-safe.jpg b/packages/ses/test/error/issue-2941/test1/error-trapping-platform-safe.jpg
diff --git a/packages/ses/test/error/issue-2941/test1/error-trapping-platform.html b/packages/ses/test/error/issue-2941/test1/error-trapping-platform.html
@@ -0,0 +1,23 @@
+<!DOCTYPE html>
+<html lang="en">
+
+<head>
+    <meta charset="UTF-8">
+    <meta name="viewport" content="width=device-width, initial-scale=1.0">
+    <title>Document</title>
+    <script src="../../../../dist/ses.cjs"></script>
+    <script>
+        lockdown({
+            errorTaming: 'unsafe',
+            stackFiltering: 'concise',
+            errorTrapping: 'platform',
+        })
+
+    </script>
+</head>
+
+<body>
+    <script src="./test.notjs"></script>
+</body>
+
+</html>
diff --git a/packages/ses/test/error/issue-2941/test1/error-trapping-platform.jpg b/packages/ses/test/error/issue-2941/test1/error-trapping-platform.jpg
diff --git a/packages/ses/test/error/issue-2941/test1/test.notjs b/packages/ses/test/error/issue-2941/test1/test.notjs
@@ -0,0 +1 @@
+canIRunInvalidSyntax?()
diff --git a/packages/ses/test/error/issue-2941/test2/README.md b/packages/ses/test/error/issue-2941/test2/README.md
@@ -0,0 +1,50 @@
+# repro
+
+When a multiline message is thrown in Node.js, SES will print all lines of the message, except first, twice.
+
+The problem goes away when `errorTrapping: "none"` is added to lockdown options
+
+---
+# `errorTrapping: 'platform'`
+
+```
+$ node error-trapping-platform.demo.js
+SES_UNCAUGHT_EXCEPTION: (Error#1)
+Error#1: Does this place have an
+  echo?
+
+  echo?
+
+  at packages/ses/test/error/issue-2941/test2/error-trapping-platform.demo.js:9:7
+```
+
+---
+# `errorTrapping: 'platform', errorTaming: 'safe'`
+
+```
+$ node error-trapping-platform-safe.demo.js
+SES_UNCAUGHT_EXCEPTION: (Error#1)
+Error#1: Does this place have an
+  echo?
+
+
+  at packages/ses/test/error/issue-2941/test2/error-trapping-platform-safe.demo.js:9:7
+```
+
+---
+
+# `errorTrapping: 'none'`
+
+```
+$ node error-trapping-none.demo.js
+file:///Users/markmiller/src/ongithub/endojs/endo/packages/ses/test/error/issue-2941/test2/error-trapping-none.demo.js:9
+throw Error(`Does this place have an
+      ^
+
+[Error: Does this place have an
+  echo?
+
+  at packages/ses/test/error/issue-2941/test2/error-trapping-none.demo.js:9:7]
+
+Node.js v22.16.0
+```
diff --git a/packages/ses/test/error/issue-2941/test2/error-trapping-none.demo.js b/packages/ses/test/error/issue-2941/test2/error-trapping-none.demo.js
@@ -0,0 +1,11 @@
+import '../../../../index.js';
+
+lockdown({
+  errorTaming: 'unsafe',
+  stackFiltering: 'concise',
+  errorTrapping: 'none',
+});
+
+throw Error(`Does this place have an
+  echo?
+`);
diff --git a/packages/ses/test/error/issue-2941/test2/error-trapping-platform-safe.demo.js b/packages/ses/test/error/issue-2941/test2/error-trapping-platform-safe.demo.js
@@ -0,0 +1,11 @@
+import '../../../../index.js';
+
+lockdown({
+  errorTaming: 'safe',
+  stackFiltering: 'concise',
+  errorTrapping: 'platform',
+});
+
+throw Error(`Does this place have an
+  echo?
+`);
diff --git a/packages/ses/test/error/issue-2941/test2/error-trapping-platform.demo.js b/packages/ses/test/error/issue-2941/test2/error-trapping-platform.demo.js
@@ -0,0 +1,11 @@
+import '../../../../index.js';
+
+lockdown({
+  errorTaming: 'unsafe',
+  stackFiltering: 'concise',
+  errorTrapping: 'platform',
+});
+
+throw Error(`Does this place have an
+  echo?
+`);
diff --git a/packages/ses/test/error/issue-2941/test3/README.md b/packages/ses/test/error/issue-2941/test3/README.md
@@ -0,0 +1,75 @@
+Same error, different presentation
+
+---
+# `errorTrapping" 'platform'`
+
+```
+$ node error-trapping-platform.demo.js
+SES_UNCAUGHT_EXCEPTION: (Error#1)
+Error#1: que?
+  at packages/ses/test/error/issue-2941/test3/error-trapping-platform.demo.js:12:9
+
+Error#1 cause: (Error#2)
+Nested error under Error#1
+  Error#2: karramba
+    at packages/ses/test/error/issue-2941/test3/error-trapping-platform.demo.js:10:9
+```
+
+---
+# `errorTrapping" 'platform', errorTaming: 'safe'`
+
+```
+$ node error-trapping-platformsafe.demo.js
+SES_UNCAUGHT_EXCEPTION: (Error#1)
+Error#1: que?
+  at packages/ses/test/error/issue-2941/test3/error-trapping-platform.demo.js:12:9
+
+Error#1 cause: (Error#2)
+Nested error under Error#1
+  Error#2: karramba
+    at packages/ses/test/error/issue-2941/test3/error-trapping-platform.demo.js:10:9
+```
+
+---
+
+# `errorTrapping: 'none'`
+
+```
+$ node error-trapping-none.demo.js
+file:///Users/markmiller/src/ongithub/endojs/endo/packages/ses/test/error/issue-2941/test3/error-trapping-none.demo.js:12
+  throw Error('que?', { cause: e });
+        ^
+
+[Error: que?
+  at packages/ses/test/error/issue-2941/test3/error-trapping-none.demo.js:12:9] {
+  [cause]: [Error: karramba
+    at packages/ses/test/error/issue-2941/test3/error-trapping-none.demo.js:10:9]
+}
+
+Node.js v22.16.0
+```
+
+---
+
+# SES without lockdown
+
+```
+$ node error-trapping-no-lockdown.demo.js
+file:///Users/markmiller/src/ongithub/endojs/endo/packages/ses/test/error/issue-2941/test3/error-trapping-no-lockdown.demo.js:6
+  throw Error('que?', { cause: e });
+        ^
+
+Error: que?
+    at file:///Users/markmiller/src/ongithub/endojs/endo/packages/ses/test/error/issue-2941/test3/error-trapping-no-lockdown.demo.js:6:9
+    at ModuleJob.run (node:internal/modules/esm/module_job:274:25)
+    at async onImport.tracePromise.__proto__ (node:internal/modules/esm/loader:644:26)
+    at async asyncRunEntryPointWithESMLoader (node:internal/modules/run_main:117:5) {
+  [cause]: Error: karramba
+      at file:///Users/markmiller/src/ongithub/endojs/endo/packages/ses/test/error/issue-2941/test3/error-trapping-no-lockdown.demo.js:4:9
+      at ModuleJob.run (node:internal/modules/esm/module_job:274:25)
+      at async onImport.tracePromise.__proto__ (node:internal/modules/esm/loader:644:26)
+      at async asyncRunEntryPointWithESMLoader (node:internal/modules/run_main:117:5)
+}
+
+Node.js v22.16.0
+```
diff --git a/packages/ses/test/error/issue-2941/test3/error-trapping-no-lockdown.demo.js b/packages/ses/test/error/issue-2941/test3/error-trapping-no-lockdown.demo.js
@@ -0,0 +1,7 @@
+import '../../../../index.js';
+
+try {
+  throw Error(`karramba`);
+} catch (e) {
+  throw Error('que?', { cause: e });
+}
diff --git a/packages/ses/test/error/issue-2941/test3/error-trapping-none.demo.js b/packages/ses/test/error/issue-2941/test3/error-trapping-none.demo.js
@@ -0,0 +1,13 @@
+import '../../../../index.js';
+
+lockdown({
+  errorTaming: 'unsafe',
+  stackFiltering: 'concise',
+  errorTrapping: 'none',
+});
+
+try {
+  throw Error(`karramba`);
+} catch (e) {
+  throw Error('que?', { cause: e });
+}
diff --git a/packages/ses/test/error/issue-2941/test3/error-trapping-platform-safe.demo.js b/packages/ses/test/error/issue-2941/test3/error-trapping-platform-safe.demo.js
@@ -0,0 +1,13 @@
+import '../../../../index.js';
+
+lockdown({
+  errorTaming: 'safe',
+  stackFiltering: 'concise',
+  errorTrapping: 'platform',
+});
+
+try {
+  throw Error(`karramba`);
+} catch (e) {
+  throw Error('que?', { cause: e });
+}
diff --git a/packages/ses/test/error/issue-2941/test3/error-trapping-platform.demo.js b/packages/ses/test/error/issue-2941/test3/error-trapping-platform.demo.js
@@ -0,0 +1,13 @@
+import '../../../../index.js';
+
+lockdown({
+  errorTaming: 'unsafe',
+  stackFiltering: 'concise',
+  errorTrapping: 'platform',
+});
+
+try {
+  throw Error(`karramba`);
+} catch (e) {
+  throw Error('que?', { cause: e });
+}
