Also default to true color in case of transparent fore or background

endroid · endroid · commit 21e888e85974 · 2025-07-13T19:59:45.000Z
diff --git a/src/Writer/PngWriter.php b/src/Writer/PngWriter.php
@@ -23,8 +23,11 @@ public function write(QrCodeInterface $qrCode, ?LogoInterface $logo = null, ?Lab
         }
 
         if (!array_key_exists(self::WRITER_OPTION_NUMBER_OF_COLORS, $options)) {
-            // When a logo is present use true color, otherwise use a palette of 16 colors
-            $options[self::WRITER_OPTION_NUMBER_OF_COLORS] = $logo instanceof LogoInterface ? null : 16;
+            $options[self::WRITER_OPTION_NUMBER_OF_COLORS] = match (true) {
+                $qrCode->getBackgroundColor()->getAlpha() > 0 || $qrCode->getForegroundColor()->getAlpha() > 0 => null,
+                $logo instanceof LogoInterface => null,
+                default => 16,
+            };
         }
 
         /** @var GdResult $gdResult */

Original file line number	Diff line number	Diff line change
`@@ -23,8 +23,11 @@ public function write(QrCodeInterface $qrCode, ?LogoInterface $logo = null, ?Lab`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`if (!array_key_exists(self::WRITER_OPTION_NUMBER_OF_COLORS, $options)) {`
`26`		`- // When a logo is present use true color, otherwise use a palette of 16 colors`
`27`		`- $options[self::WRITER_OPTION_NUMBER_OF_COLORS] = $logo instanceof LogoInterface ? null : 16;`
	`26`	`+ $options[self::WRITER_OPTION_NUMBER_OF_COLORS] = match (true) {`
	`27`	`+ $qrCode->getBackgroundColor()->getAlpha() > 0 \|\| $qrCode->getForegroundColor()->getAlpha() > 0 => null,`
	`28`	`+ $logo instanceof LogoInterface => null,`
	`29`	`+ default => 16,`
	`30`	`+ };`
`28`	`31`	`}`
`29`	`32`
`30`	`33`	`/** @var GdResult $gdResult */`