Feature/evsemanager persistent transactions (EVerest#789)

* Added SessionEventEnum SessionResumed to allow the evse_manager to indicate that a previous session has been resumed at startup
* Added subscription to this event to OCPP module so that OCPP is aware that the EvseManager is aware of previous transactions. This allows OCPP to not terminate such transactions individually every time

---------

Signed-off-by: Cornelius Claussen <cc@pionix.de>
Signed-off-by: pietfried <pietgoempel@gmail.com>
Signed-off-by: florinmihut <florinmihut1@gmail.com>
Signed-off-by: Piet Gömpel <37657534+Pietfried@users.noreply.github.com>
Co-authored-by: pietfried <pietgoempel@gmail.com>
Co-authored-by: florinmihut <florinmihut1@gmail.com>
Co-authored-by: Piet Gömpel <37657534+Pietfried@users.noreply.github.com>

Author: 3 people

config/config-sil-ocpp.yaml

@@ -13,6 +13,8 @@ active_modules:
     config_module:
       device: auto
       supported_ISO15118_2: true
+  persistent_store:
+    module: PersistentStore
   evse_manager_1:
     evse: 1
     module: EvseManager
@@ -39,6 +41,9 @@ active_modules:
       hlc:
         - module_id: iso15118_charger
           implementation_id: charger
+      store:
+        - module_id: persistent_store
+          implementation_id: main
   evse_manager_2:
     module: EvseManager
     evse: 2

dependencies.yaml

@@ -60,7 +60,7 @@ libevse-security:
 # OCPP
 libocpp:
   git: https://github.com/EVerest/libocpp.git
-  git_tag: 1067cf3ddf27be3a43f8abc519b69da11c4ef921
+  git_tag: aab1d5785bde141203b1a89b03d66fa91edf8093
   cmake_condition: "EVEREST_DEPENDENCY_ENABLED_LIBOCPP"
 # Josev
 Josev:

interfaces/powermeter.yaml

@@ -12,7 +12,11 @@ cmds:
       type: object
       $ref: /powermeter#/TransactionStartResponse
   stop_transaction:
-    description: Stop the transaction on the power meter and return the signed metering information
+    description: >-
+      Stop the transaction on the power meter and return the signed metering information.
+      If the transaction id is an empty string, all ongoing transaction should be cancelled.
+      This is used on start up to clear dangling transactions that might still be ongoing
+      in the power meter but are not known to the EvseManager.
     arguments:
       transaction_id:
         description: Transaction id

modules/EvseManager/CMakeLists.txt

@@ -18,6 +18,7 @@ target_sources(${MODULE_NAME}
         IECStateMachine.cpp
         ErrorHandling.cpp
         backtrace.cpp
+        PersistentStore.cpp
 )
 
 target_link_libraries(${MODULE_NAME}

modules/EvseManager/Charger.cpp

@@ -25,12 +25,14 @@ namespace module {
 
 Charger::Charger(const std::unique_ptr<IECStateMachine>& bsp, const std::unique_ptr<ErrorHandling>& error_handling,
                  const std::vector<std::unique_ptr<powermeterIntf>>& r_powermeter_billing,
+                 const std::unique_ptr<PersistentStore>& _store,
                  const types::evse_board_support::Connector_type& connector_type, const std::string& evse_id) :
     bsp(bsp),
     error_handling(error_handling),
+    r_powermeter_billing(r_powermeter_billing),
+    store(_store),
     connector_type(connector_type),
-    evse_id(evse_id),
-    r_powermeter_billing(r_powermeter_billing) {
+    evse_id(evse_id) {
 
 #ifdef EVEREST_USE_BACKTRACES
     Everest::install_backtrace_handler();
@@ -1169,6 +1171,8 @@ bool Charger::start_transaction() {
         }
     }
 
+    store->store_session(shared_context.session_uuid);
+
     signal_transaction_started_event(shared_context.id_token);
     return true;
 }
@@ -1191,11 +1195,51 @@ void Charger::stop_transaction() {
         }
     }
 
+    store->clear_session();
+
     signal_simple_event(types::evse_manager::SessionEventEnum::ChargingFinished);
     signal_transaction_finished_event(shared_context.last_stop_transaction_reason,
                                       shared_context.stop_transaction_id_token);
 }
 
+void Charger::cleanup_transactions_on_startup() {
+    // See if we have an open transaction in persistent storage
+    auto session_uuid = store->get_session();
+    if (not session_uuid.empty()) {
+        EVLOG_info << "Cleaning up transaction with UUID " << session_uuid << " on start up";
+        store->clear_session();
+
+        types::evse_manager::TransactionFinished transaction_finished;
+
+        // If yes, try to close nicely with the ID we remember and trigger a transaction finished event on success
+        for (const auto& meter : r_powermeter_billing) {
+            const auto response = meter->call_stop_transaction(session_uuid);
+            // If we fail to stop the transaction, it was probably just not active anymore
+            if (response.status == types::powermeter::TransactionRequestStatus::UNEXPECTED_ERROR) {
+                EVLOG_warning << "Failed to stop a transaction on the power meter " << response.error.value_or("");
+                break;
+            } else if (response.status == types::powermeter::TransactionRequestStatus::OK) {
+                // Fill in OCMF from the recovered transaction
+                transaction_finished.start_signed_meter_value = response.start_signed_meter_value;
+                transaction_finished.signed_meter_value = response.signed_meter_value;
+                break;
+            }
+        }
+
+        // Send out event to inform OCPP et al
+        std::optional<types::authorization::ProvidedIdToken> id_token;
+        signal_transaction_finished_event(types::evse_manager::StopTransactionReason::PowerLoss, id_token);
+    }
+
+    // Now we did what we could to clean up, so if there are still transactions going on in the power meter close them
+    // anyway. In this case we cannot generate a transaction finished event for OCPP et al since we cannot match it to
+    // our transaction anymore.
+    EVLOG_info << "Cleaning up any other transaction on start up";
+    for (const auto& meter : r_powermeter_billing) {
+        meter->call_stop_transaction("");
+    }
+}
+
 std::optional<types::units_signed::SignedMeterValue>
 Charger::take_signed_meter_data(std::optional<types::units_signed::SignedMeterValue>& in) {
     std::optional<types::units_signed::SignedMeterValue> out;

modules/EvseManager/Charger.hpp

@@ -45,6 +45,7 @@
 #include "ErrorHandling.hpp"
 #include "EventQueue.hpp"
 #include "IECStateMachine.hpp"
+#include "PersistentStore.hpp"
 #include "scoped_lock_timeout.hpp"
 #include "utils.hpp"
 
@@ -57,6 +58,7 @@ class Charger {
 public:
     Charger(const std::unique_ptr<IECStateMachine>& bsp, const std::unique_ptr<ErrorHandling>& error_handling,
             const std::vector<std::unique_ptr<powermeterIntf>>& r_powermeter_billing,
+            const std::unique_ptr<PersistentStore>& store,
             const types::evse_board_support::Connector_type& connector_type, const std::string& evse_id);
     ~Charger();
 
@@ -149,6 +151,7 @@ class Charger {
 
     // Signal for EvseEvents
     sigslot::signal<types::evse_manager::SessionEventEnum> signal_simple_event;
+    sigslot::signal<std::string> signal_session_resumed_event;
     sigslot::signal<types::evse_manager::StartSessionReason, std::optional<types::authorization::ProvidedIdToken>>
         signal_session_started_event;
     sigslot::signal<types::authorization::ProvidedIdToken> signal_transaction_started_event;
@@ -212,6 +215,8 @@ class Charger {
         connector_type = t;
     }
 
+    void cleanup_transactions_on_startup();
+
 private:
     utils::Stopwatch stopwatch;
 
@@ -358,12 +363,11 @@ class Charger {
 
     const std::unique_ptr<IECStateMachine>& bsp;
     const std::unique_ptr<ErrorHandling>& error_handling;
-
+    const std::vector<std::unique_ptr<powermeterIntf>>& r_powermeter_billing;
+    const std::unique_ptr<PersistentStore>& store;
     std::atomic<types::evse_board_support::Connector_type> connector_type{
         types::evse_board_support::Connector_type::IEC62196Type2Cable};
-
     const std::string evse_id;
-    const std::vector<std::unique_ptr<powermeterIntf>>& r_powermeter_billing;
 
     // ErrorHandling events
     enum class ErrorHandlingEvents : std::uint8_t {

modules/EvseManager/EvseManager.cpp

@@ -42,6 +42,9 @@ inline static types::authorization::ProvidedIdToken create_autocharge_token(std:
 }
 
 void EvseManager::init() {
+
+    store = std::unique_ptr<PersistentStore>(new PersistentStore(r_store, info.id));
+
     random_delay_enabled = config.uk_smartcharging_random_delay_enable;
     random_delay_max_duration = std::chrono::seconds(config.uk_smartcharging_random_delay_max_duration);
     if (random_delay_enabled) {
@@ -159,8 +162,8 @@ void EvseManager::ready() {
     error_handling =
         std::unique_ptr<ErrorHandling>(new ErrorHandling(r_bsp, r_hlc, r_connector_lock, r_ac_rcd, p_evse, r_imd));
 
-    charger = std::unique_ptr<Charger>(
-        new Charger(bsp, error_handling, r_powermeter_billing(), hw_capabilities.connector_type, config.evse_id));
+    charger = std::unique_ptr<Charger>(new Charger(bsp, error_handling, r_powermeter_billing(), store,
+                                                   hw_capabilities.connector_type, config.evse_id));
 
     // Now incoming hardware capabilties can be processed
     hw_caps_mutex.unlock();
@@ -926,6 +929,17 @@ void EvseManager::ready() {
                                      [this] { return initial_powermeter_value_received; });
     }
 
+    // Resuming left-over transaction from e.g. powerloss. This information allows other modules like to OCPP to be
+    // informed that the EvseManager is aware of previous sessions so that no individual cleanup is required
+    const auto session_id = store->get_session();
+    if (!session_id.empty()) {
+        charger->signal_session_resumed_event(session_id);
+    }
+
+    // By default cleanup left-over transaction from e.g. power loss
+    // TOOD: Add resume handling
+    charger->cleanup_transactions_on_startup();
+
     //  start with a limit of 0 amps. We will get a budget from EnergyManager that is locally limited by hw
     //  caps.
     charger->set_max_current(0.0F, date::utc_clock::now() + std::chrono::seconds(120));

modules/EvseManager/EvseManager.hpp

@@ -22,6 +22,7 @@
 #include <generated/interfaces/connector_lock/Interface.hpp>
 #include <generated/interfaces/evse_board_support/Interface.hpp>
 #include <generated/interfaces/isolation_monitor/Interface.hpp>
+#include <generated/interfaces/kvs/Interface.hpp>
 #include <generated/interfaces/power_supply_DC/Interface.hpp>
 #include <generated/interfaces/powermeter/Interface.hpp>
 #include <generated/interfaces/slac/Interface.hpp>
@@ -41,6 +42,7 @@
 #include "CarManufacturer.hpp"
 #include "Charger.hpp"
 #include "ErrorHandling.hpp"
+#include "PersistentStore.hpp"
 #include "SessionLog.hpp"
 #include "VarContainer.hpp"
 #include "scoped_lock_timeout.hpp"
@@ -110,7 +112,8 @@ class EvseManager : public Everest::ModuleBase {
                 std::vector<std::unique_ptr<powermeterIntf>> r_powermeter_car_side,
                 std::vector<std::unique_ptr<slacIntf>> r_slac, std::vector<std::unique_ptr<ISO15118_chargerIntf>> r_hlc,
                 std::vector<std::unique_ptr<isolation_monitorIntf>> r_imd,
-                std::vector<std::unique_ptr<power_supply_DCIntf>> r_powersupply_DC, Conf& config) :
+                std::vector<std::unique_ptr<power_supply_DCIntf>> r_powersupply_DC,
+                std::vector<std::unique_ptr<kvsIntf>> r_store, Conf& config) :
         ModuleBase(info),
         mqtt(mqtt_provider),
         telemetry(telemetry),
@@ -127,6 +130,7 @@ class EvseManager : public Everest::ModuleBase {
         r_hlc(std::move(r_hlc)),
         r_imd(std::move(r_imd)),
         r_powersupply_DC(std::move(r_powersupply_DC)),
+        r_store(std::move(r_store)),
         config(config){};
 
     Everest::MqttProvider& mqtt;
@@ -144,6 +148,7 @@ class EvseManager : public Everest::ModuleBase {
     const std::vector<std::unique_ptr<ISO15118_chargerIntf>> r_hlc;
     const std::vector<std::unique_ptr<isolation_monitorIntf>> r_imd;
     const std::vector<std::unique_ptr<power_supply_DCIntf>> r_powersupply_DC;
+    const std::vector<std::unique_ptr<kvsIntf>> r_store;
     const Conf& config;
 
     // ev@1fce4c5e-0ab8-41bb-90f7-14277703d2ac:v1
@@ -191,6 +196,7 @@ class EvseManager : public Everest::ModuleBase {
 
     std::unique_ptr<IECStateMachine> bsp;
     std::unique_ptr<ErrorHandling> error_handling;
+    std::unique_ptr<PersistentStore> store;
 
     std::atomic_bool random_delay_enabled{false};
     std::atomic_bool random_delay_running{false};

modules/EvseManager/PersistentStore.cpp

@@ -0,0 +1,44 @@
+// SPDX-License-Identifier: Apache-2.0
+// Copyright 2023 Pionix GmbH and Contributors to EVerest
+
+#include "PersistentStore.hpp"
+
+namespace module {
+
+PersistentStore::PersistentStore(const std::vector<std::unique_ptr<kvsIntf>>& _r_store, const std::string module_id) :
+    r_store(_r_store) {
+
+    if (r_store.size() > 0) {
+        active = true;
+    }
+
+    session_key = module_id + "_session";
+}
+
+void PersistentStore::store_session(const std::string& session_uuid) {
+    if (active) {
+        r_store[0]->call_store(session_key, session_uuid);
+    }
+}
+
+void PersistentStore::clear_session() {
+    if (active) {
+        r_store[0]->call_store(session_key, "");
+    }
+}
+
+std::string PersistentStore::get_session() {
+    if (active) {
+        auto r = r_store[0]->call_load(session_key);
+        try {
+            if (std::holds_alternative<std::string>(r)) {
+                return std::get<std::string>(r);
+            }
+        } catch (...) {
+            return {};
+        }
+    }
+    return {};
+}
+
+} // namespace module

modules/EvseManager/PersistentStore.hpp

@@ -0,0 +1,33 @@
+// SPDX-License-Identifier: Apache-2.0
+// Copyright 2020 - 2021 Pionix GmbH and Contributors to EVerest
+
+/*
+ The Persistent Store class is an abstraction layer to store any persistent information
+ (such as sessions) for the EvseManager.
+*/
+
+#ifndef EVSE_MANAGER_PERSISTENT_STORE_H_
+#define EVSE_MANAGER_PERSISTENT_STORE_H_
+
+#include <generated/interfaces/kvs/Interface.hpp>
+
+namespace module {
+
+class PersistentStore {
+public:
+    // We need the r_bsp reference to be able to talk to the bsp driver module
+    explicit PersistentStore(const std::vector<std::unique_ptr<kvsIntf>>& r_store, const std::string module_id);
+
+    void store_session(const std::string& session_uuid);
+    void clear_session();
+    std::string get_session();
+
+private:
+    const std::vector<std::unique_ptr<kvsIntf>>& r_store;
+    std::string session_key;
+    bool active{false};
+};
+
+} // namespace module
+
+#endif // EVSE_MANAGER_PERSISTENT_STORE_H_