Skip to content

Commit 57e9257

Browse files
committed
update name of testing target
1 parent 58ace59 commit 57e9257

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ jobs:
203203
mkdir cmake-build
204204
cd cmake-build
205205
cmake ../ -DGODOTCPP_ENABLE_TESTING=YES -DGODOTCPP_TARGET=template_release
206-
cmake --build . --verbose -j $(nproc) --config Release
206+
cmake --build . --verbose -j $(nproc) --target godot-cpp-test --config Release
207207
208208
windows-msvc-cmake:
209209
name: 🏁 Build (Windows, MSVC, CMake)
@@ -219,4 +219,4 @@ jobs:
219219
mkdir cmake-build
220220
cd cmake-build
221221
cmake ../ -DGODOTCPP_ENABLE_TESTING=YES -DGODOTCPP_TARGET=template_release
222-
cmake --build . --verbose --config Release
222+
cmake --build . --verbose --target godot-cpp-test --config Release

doc/cmake.rst

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ the notable differences.
8080

8181
Testing Integration
8282
-------------------
83-
The testing target ``gdexample`` is guarded by ``GODOTCPP_ENABLE_TESTING`` which is off by default.
83+
The testing target ``godot-cpp-test`` is guarded by ``GODOTCPP_ENABLE_TESTING`` which is off by default.
8484

8585
To configure and build the godot-cpp project to enable the integration
8686
testing targets the command will look something like:
@@ -89,7 +89,7 @@ testing targets the command will look something like:
8989
9090
# Assuming our current directory is the godot-cpp source root
9191
cmake -S . -B cmake-build -DGODOTCPP_ENABLE_TESTING=YES
92-
cmake --build cmake-build --target gdexample
92+
cmake --build cmake-build --target godot-cpp-test
9393
9494
Basic walkthrough
9595
-----------------
@@ -189,7 +189,7 @@ needs to be specified at build time ie ``--config Release``
189189
190190
# Assuming our current directory is the godot-cpp source root
191191
cmake -S . -B cmake-build -DGODOTCPP_ENABLE_TESTING=YES
192-
cmake --build cmake-build -t gdexample --config Release
192+
cmake --build cmake-build -t godot-cpp-test --config Release
193193
194194
195195
MSys2/clang64, "Ninja" - Debug
@@ -205,7 +205,7 @@ Using the msys2/clang64 shell
205205
206206
# Assuming our current directory is the godot-cpp source root
207207
cmake -S . -B cmake-build -G"Ninja" -DGODOTCPP_ENABLE_TESTING=YES -DCMAKE_BUILD_TYPE=Release
208-
cmake --build cmake-build -t gdexample
208+
cmake --build cmake-build -t godot-cpp-test
209209
210210
MSys2/clang64, "Ninja Multi-Config" - dev_build, Debug Symbols
211211
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@@ -220,7 +220,7 @@ Using the msys2/clang64 shell
220220
221221
# Assuming our current directory is the godot-cpp source root
222222
cmake -S . -B cmake-build -G"Ninja Multi-Config" -DGODOTCPP_ENABLE_TESTING=YES -DGODOTCPP_DEV_BUILD:BOOL=ON
223-
cmake --build cmake-build -t gdexample --config Debug
223+
cmake --build cmake-build -t godot-cpp-test --config Debug
224224
225225
Emscripten for web platform
226226
~~~~~~~~~~~~~~~~~~~~~~~~~~~

test/CMakeLists.txt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ set(DOC_SOURCE_FILE "${CMAKE_CURRENT_BINARY_DIR}/gen/doc_source.cpp")
1414

1515
generate_doc_source( "${DOC_SOURCE_FILE}" ${DOC_XML} )
1616

17-
set(TARGET_NAME "gdexample")
17+
set(TARGET_NAME "godot-cpp-test")
1818

1919
add_library(${TARGET_NAME} SHARED EXCLUDE_FROM_ALL)
2020

@@ -58,7 +58,8 @@ set_target_properties(
5858
PDB_OUTPUT_DIRECTORY "$<1:${OUTPUT_DIR}>" #MSVC Only, ignored on other platforms
5959

6060
PREFIX "lib"
61-
OUTPUT_NAME "${TARGET_NAME}${GODOTCPP_SUFFIX}"
61+
OUTPUT_NAME "gdexample${GODOTCPP_SUFFIX}"
62+
# TODO rename the file for both CMake and SCons
6263

6364
# Some IDE's respect this property to logically group targets
6465
FOLDER "godot-cpp"

0 commit comments

Comments
 (0)