Skip to content

Commit 3bc64e8

Browse files
authored
Chore/gradle remove redundant apply (flutter#135348)
I'm removing an unneded block of configuration from the `settings.gradle` template. It was introduced by me in flutter#123511. At that time, I did not know that it's unnecessary, and did not test removing it � sorry about that. I learned that it's unnecessary recently, when [I asked a question on StackOverflow](https://stackoverflow.com/questions/77073596/whats-the-difference-between-plugins-and-pluginmanagement-plugins-in). More context there.
1 parent 5a0ef34 commit 3bc64e8

File tree

4 files changed

+1
-15
lines changed

4 files changed

+1
-15
lines changed

dev/a11y_assessments/android/settings.gradle

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,6 @@ pluginManagement {
1313
settings.ext.flutterSdkPath = flutterSdkPath()
1414

1515
includeBuild("${settings.ext.flutterSdkPath}/packages/flutter_tools/gradle")
16-
17-
plugins {
18-
id "dev.flutter.flutter-gradle-plugin" version "1.0.0" apply false
19-
}
2016
}
2117

2218
include ":app"

examples/hello_world/android/settings.gradle

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,6 @@ pluginManagement {
2424
mavenCentral()
2525
gradlePluginPortal()
2626
}
27-
28-
plugins {
29-
// Flutter Gradle Plugin's ID is defined in /packages/flutter_tools/gradle/build.gradle.kts.
30-
// We set `apply false`, because we don't want to apply the plugin to
31-
// the `android` root project, but only to the `app` subproject.
32-
id "dev.flutter.flutter-gradle-plugin" version "1.0.0" apply false
33-
}
3427
}
3528

3629
plugins {

packages/flutter_tools/gradle/build.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ gradlePlugin {
1818
id = "dev.flutter.flutter-gradle-plugin"
1919
implementationClass = "FlutterPlugin"
2020
}
21+
// The "flutterAppPluginLoaderPlugin" name isn't used anywhere.
2122
create("flutterAppPluginLoaderPlugin") {
2223
id = "dev.flutter.flutter-plugin-loader"
2324
implementationClass = "FlutterAppPluginLoaderPlugin"

packages/flutter_tools/templates/app_shared/android.tmpl/settings.gradle.tmpl

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,6 @@ pluginManagement {
1515
mavenCentral()
1616
gradlePluginPortal()
1717
}
18-
19-
plugins {
20-
id "dev.flutter.flutter-gradle-plugin" version "1.0.0" apply false
21-
}
2218
}
2319

2420
plugins {

0 commit comments

Comments
 (0)