Skip to content

Commit 9bf18f0

Browse files
bump warn agp version from 7.3 to 8.3 (flutter#166555)
Bumping the warn agp version from 7.3 (sept 2022) to 8.3 (feb 2024). This is because we will likely need to depend on apis available in the newer versions of AGP as part of our work to migrate to the public/stable agp api. Warning will not break customers but starts the clock on being able to bump error version. I would have also bumped the error version but want to get this in before the 3.32 cut next monday and adding errors can cause review delay. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Jackson Gardner <[email protected]>
1 parent c827c53 commit 9bf18f0

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

packages/flutter_tools/gradle/src/main/kotlin/DependencyVersionChecker.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ object DependencyVersionChecker {
9191

9292
@VisibleForTesting internal val errorJavaVersion: JavaVersion = JavaVersion.VERSION_1_1
9393

94-
@VisibleForTesting internal val warnAGPVersion: AndroidPluginVersion = AndroidPluginVersion(7, 3, 1)
94+
@VisibleForTesting internal val warnAGPVersion: AndroidPluginVersion = AndroidPluginVersion(8, 3, 0)
9595

9696
@VisibleForTesting internal val errorAGPVersion: AndroidPluginVersion = AndroidPluginVersion(7, 0, 0)
9797

packages/flutter_tools/gradle/src/test/kotlin/DependencyVersionCheckerTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ private const val FAKE_PROJECT_ROOT_DIR = "/fake/root/dir"
5353
// are updated in DependencyVersionChecker.kt
5454
private const val SUPPORTED_GRADLE_VERSION: String = "7.4.2"
5555
private val SUPPORTED_JAVA_VERSION: JavaVersion = JavaVersion.VERSION_11
56-
private val SUPPORTED_AGP_VERSION: AndroidPluginVersion = AndroidPluginVersion(7, 3, 1)
56+
private val SUPPORTED_AGP_VERSION: AndroidPluginVersion = AndroidPluginVersion(8, 3, 0)
5757
private const val SUPPORTED_KGP_VERSION: String = "1.8.10"
5858
private val SUPPORTED_SDK_VERSION: MinSdkVersion = MinSdkVersion("release", 30)
5959

@@ -82,7 +82,7 @@ class DependencyVersionCheckerTest {
8282

8383
@Test
8484
fun `AGP version in warn range results in warning logs`() {
85-
val exampleWarnAgpVersion = AndroidPluginVersion(7, 1, 0)
85+
val exampleWarnAgpVersion = AndroidPluginVersion(8, 2, 0)
8686
val mockProject = MockProjectFactory.createMockProjectWithSpecifiedDependencyVersions(agpVersion = exampleWarnAgpVersion)
8787

8888
val mockExtraPropertiesExtension = mockProject.extra

0 commit comments

Comments
 (0)