Revert "[ios][tools]do not log "bonjour not found" at all (unless verbose)" (flutter#173879)

hellohuanlin · web-flow · commit eeb3a40cbef8 · 2025-08-15T23:30:08.000Z
Reverts flutter#173569 Sorry I have to revert this one as it didn't work. # Why didn't work From the comment, it looks like `echoError` is only used for verbose mode, and `streamOutput` is used for non-verbose mode (I am still looking into how this is setup) https://github.com/flutter/flutter/blob/e4f27cd09734db6c6ed94e104ab5333c48dfc544/packages/flutter_tools/bin/xcode_backend.dart#L151 # How to fix ## Possible Fix 1 I tested this works, by changing this line: https://github.com/flutter/flutter/blob/master/packages/flutter_tools/bin/xcode_backend.dart#L159 into this: ``` if (!verbose && exitCode == 0 && !skipErrorLog) ``` ## Possible fix 2: Surprisingly this also works: ``` if (!verbose && exitCode == 0) { streamOutput(errorOutput.string().replaceAll('error', ''); } ``` Although we made sure `errorOutput` doesn't start with `error:`, there's an `error:` in the middle of the string. Possibly because of this code in `mac.dart`: https://github.com/flutter/flutter/blob/e4f27cd09734db6c6ed94e104ab5333c48dfc544/packages/flutter_tools/lib/src/ios/mac.dart#L431-L433 # Why we missed it? I tested my initial code code and assumed updated code would work, because I incorrectly thought `echoError` was the one triggered the output in non-verbose mode. I should have verified it.
diff --git a/packages/flutter_tools/bin/xcode_backend.dart b/packages/flutter_tools/bin/xcode_backend.dart
@@ -102,22 +102,14 @@ class Context {
 
   Directory directoryFromPath(String path) => Directory(path);
 
-  /// Run given command ([bin]) in a synchronous subprocess.
-  ///
-  /// If [allowFail] is true, an exception will not be thrown even if the process returns a
-  /// non-zero exit code. Also, `error:` will not be prefixed to the output to prevent Xcode
-  /// complication failures.
-  ///
-  /// If [skipErrorLog] is true, `stderr` from the process will not be output unless in [verbose]
-  /// mode. If in [verbose], pipes `stderr` to `stdout`.
+  /// Run given command in a synchronous subprocess.
   ///
   /// Will throw [Exception] if the exit code is not 0.
   ProcessResult runSync(
     String bin,
     List<String> args, {
     bool verbose = false,
     bool allowFail = false,
-    bool skipErrorLog = false,
     String? workingDirectory,
   }) {
     if (verbose) {
@@ -130,22 +122,15 @@ class Context {
     final String resultStderr = result.stderr.toString().trim();
     if (resultStderr.isNotEmpty) {
       final errorOutput = StringBuffer();
+      // If allowFail, do not fail Xcode build. An example is on macOS 26,
+      // plutil reports NSBonjourServices key not found via stderr (rather than
+      // stdout on older macOS), and it should not cause compile failure.
       if (!allowFail && result.exitCode != 0) {
         // "error:" prefix makes this show up as an Xcode compilation error.
         errorOutput.write('error: ');
       }
       errorOutput.write(resultStderr);
-      if (skipErrorLog) {
-        // Pipe stderr to stdout under verbose mode.
-        // An example is on macOS 26, plutil reports NSBonjourServices key not found
-        // via stderr (rather than stdout on older macOS), and logging the message
-        // in stderr would be confusing, since not having the key is one of the expected states.
-        if (verbose) {
-          echo(errorOutput.toString());
-        }
-      } else {
-        echoError(errorOutput.toString());
-      }
+      echoError(errorOutput.toString());
 
       // Stream stderr to the Flutter build process.
       // When in verbose mode, `echoError` above will show the logs. So only
@@ -439,17 +424,16 @@ class Context {
       return;
     }
 
-    final bool verbose = (environment['VERBOSE_SCRIPT_LOGGING'] ?? '').isNotEmpty;
-
     // If there are already NSBonjourServices specified by the app (uncommon),
     // insert the vmService service name to the existing list.
-    ProcessResult result = runSync(
-      'plutil',
-      <String>['-extract', 'NSBonjourServices', 'xml1', '-o', '-', builtProductsPlist],
-      verbose: verbose,
-      allowFail: true,
-      skipErrorLog: true,
-    );
+    ProcessResult result = runSync('plutil', <String>[
+      '-extract',
+      'NSBonjourServices',
+      'xml1',
+      '-o',
+      '-',
+      builtProductsPlist,
+    ], allowFail: true);
     if (result.exitCode == 0) {
       runSync('plutil', <String>[
         '-insert',
@@ -474,13 +458,14 @@ class Context {
     // specified (uncommon). This text will appear below the "Your app would
     // like to find and connect to devices on your local network" permissions
     // popup.
-    result = runSync(
-      'plutil',
-      <String>['-extract', 'NSLocalNetworkUsageDescription', 'xml1', '-o', '-', builtProductsPlist],
-      verbose: verbose,
-      allowFail: true,
-      skipErrorLog: true,
-    );
+    result = runSync('plutil', <String>[
+      '-extract',
+      'NSLocalNetworkUsageDescription',
+      'xml1',
+      '-o',
+      '-',
+      builtProductsPlist,
+    ], allowFail: true);
     if (result.exitCode != 0) {
       runSync('plutil', <String>[
         '-insert',
diff --git a/packages/flutter_tools/test/general.shard/xcode_backend_test.dart b/packages/flutter_tools/test/general.shard/xcode_backend_test.dart
@@ -390,211 +390,70 @@ void main() {
       );
     });
 
-    test(
-      'Missing NSBonjourServices key in Info.plist should not fail Xcode compilation, and no plutil error in stdout without verbose mode',
-      () {
-        final Directory buildDir = fileSystem.directory('/path/to/builds')
-          ..createSync(recursive: true);
-        final File infoPlist = buildDir.childFile('Info.plist')..createSync();
-        const plutilErrorMessage =
-            'Could not extract value, error: No value at that key path or invalid key path: NSBonjourServices';
-
-        final context = TestContext(
-          <String>['test_vm_service_bonjour_service'],
-          <String, String>{
-            'CONFIGURATION': 'Debug',
-            'BUILT_PRODUCTS_DIR': buildDir.path,
-            'INFOPLIST_PATH': 'Info.plist',
-          },
-          commands: <FakeCommand>[
-            FakeCommand(
-              command: <String>[
-                'plutil',
-                '-extract',
-                'NSBonjourServices',
-                'xml1',
-                '-o',
-                '-',
-                infoPlist.path,
-              ],
-              exitCode: 1,
-              stderr: plutilErrorMessage,
-            ),
-            FakeCommand(
-              command: <String>[
-                'plutil',
-                '-insert',
-                'NSBonjourServices',
-                '-json',
-                '["_dartVmService._tcp"]',
-                infoPlist.path,
-              ],
-            ),
-            FakeCommand(
-              command: <String>[
-                'plutil',
-                '-extract',
-                'NSLocalNetworkUsageDescription',
-                'xml1',
-                '-o',
-                '-',
-                infoPlist.path,
-              ],
-            ),
-          ],
-          fileSystem: fileSystem,
-        )..run();
-        expect(context.stderr, isNot(startsWith('error: ')));
-        expect(context.stderr, isNot(contains(plutilErrorMessage)));
-        expect(context.stdout, isNot(contains(plutilErrorMessage)));
-      },
-    );
-
-    test(
-      'Missing NSBonjourServices key in Info.plist should not fail Xcode compilation, and has plutil error in stdout under verbose mode',
-      () {
-        final Directory buildDir = fileSystem.directory('/path/to/builds')
-          ..createSync(recursive: true);
-        final File infoPlist = buildDir.childFile('Info.plist')..createSync();
-        const plutilErrorMessage =
-            'Could not extract value, error: No value at that key path or invalid key path: NSBonjourServices';
-
-        final context = TestContext(
-          <String>['test_vm_service_bonjour_service'],
-          <String, String>{
-            'CONFIGURATION': 'Debug',
-            'BUILT_PRODUCTS_DIR': buildDir.path,
-            'INFOPLIST_PATH': 'Info.plist',
-            'VERBOSE_SCRIPT_LOGGING': 'YES',
-          },
-          commands: <FakeCommand>[
-            FakeCommand(
-              command: <String>[
-                'plutil',
-                '-extract',
-                'NSBonjourServices',
-                'xml1',
-                '-o',
-                '-',
-                infoPlist.path,
-              ],
-              exitCode: 1,
-              stderr: plutilErrorMessage,
-            ),
-            FakeCommand(
-              command: <String>[
-                'plutil',
-                '-insert',
-                'NSBonjourServices',
-                '-json',
-                '["_dartVmService._tcp"]',
-                infoPlist.path,
-              ],
-            ),
-            FakeCommand(
-              command: <String>[
-                'plutil',
-                '-extract',
-                'NSLocalNetworkUsageDescription',
-                'xml1',
-                '-o',
-                '-',
-                infoPlist.path,
-              ],
-            ),
-          ],
-          fileSystem: fileSystem,
-        )..run();
-        expect(context.stderr, isNot(startsWith('error: ')));
-        expect(context.stderr, isNot(contains(plutilErrorMessage)));
-        expect(context.stdout, contains(plutilErrorMessage));
-      },
-    );
-
-    test(
-      'Missing NSLocalNetworkUsageDescription in Info.plist should not fail Xcode compilation, and no plutil error in stdout without verbose mode',
-      () {
-        final Directory buildDir = fileSystem.directory('/path/to/builds')
-          ..createSync(recursive: true);
-        final File infoPlist = buildDir.childFile('Info.plist')..createSync();
-        const plutilErrorMessage =
-            'Could not extract value, error: No value at that key path or invalid key path: NSLocalNetworkUsageDescription';
-        final context = TestContext(
-          <String>['test_vm_service_bonjour_service'],
-          <String, String>{
-            'CONFIGURATION': 'Debug',
-            'BUILT_PRODUCTS_DIR': buildDir.path,
-            'INFOPLIST_PATH': 'Info.plist',
-          },
-          commands: <FakeCommand>[
-            FakeCommand(
-              command: <String>[
-                'plutil',
-                '-extract',
-                'NSBonjourServices',
-                'xml1',
-                '-o',
-                '-',
-                infoPlist.path,
-              ],
-            ),
-            FakeCommand(
-              command: <String>[
-                'plutil',
-                '-insert',
-                'NSBonjourServices.0',
-                '-string',
-                '_dartVmService._tcp',
-                infoPlist.path,
-              ],
-            ),
-            FakeCommand(
-              command: <String>[
-                'plutil',
-                '-extract',
-                'NSLocalNetworkUsageDescription',
-                'xml1',
-                '-o',
-                '-',
-                infoPlist.path,
-              ],
-              exitCode: 1,
-              stderr: plutilErrorMessage,
-            ),
-            FakeCommand(
-              command: <String>[
-                'plutil',
-                '-insert',
-                'NSLocalNetworkUsageDescription',
-                '-string',
-                'Allow Flutter tools on your computer to connect and debug your application. This prompt will not appear on release builds.',
-                infoPlist.path,
-              ],
-            ),
-          ],
-          fileSystem: fileSystem,
-        )..run();
-        expect(context.stderr, isNot(startsWith('error: ')));
-        expect(context.stderr, isNot(contains(plutilErrorMessage)));
-        expect(context.stdout, isNot(contains(plutilErrorMessage)));
-      },
-    );
+    test('Missing NSBonjourServices key in Info.plist should not fail Xcode compilation', () {
+      final Directory buildDir = fileSystem.directory('/path/to/builds')
+        ..createSync(recursive: true);
+      final File infoPlist = buildDir.childFile('Info.plist')..createSync();
+      final context = TestContext(
+        <String>['test_vm_service_bonjour_service'],
+        <String, String>{
+          'CONFIGURATION': 'Debug',
+          'BUILT_PRODUCTS_DIR': buildDir.path,
+          'INFOPLIST_PATH': 'Info.plist',
+        },
+        commands: <FakeCommand>[
+          FakeCommand(
+            command: <String>[
+              'plutil',
+              '-extract',
+              'NSBonjourServices',
+              'xml1',
+              '-o',
+              '-',
+              infoPlist.path,
+            ],
+            exitCode: 1,
+            stderr: 'No value at that key path or invalid key path: NSBonjourServices',
+          ),
+          FakeCommand(
+            command: <String>[
+              'plutil',
+              '-insert',
+              'NSBonjourServices',
+              '-json',
+              '["_dartVmService._tcp"]',
+              infoPlist.path,
+            ],
+          ),
+          FakeCommand(
+            command: <String>[
+              'plutil',
+              '-extract',
+              'NSLocalNetworkUsageDescription',
+              'xml1',
+              '-o',
+              '-',
+              infoPlist.path,
+            ],
+          ),
+        ],
+        fileSystem: fileSystem,
+      )..run();
+      expect(context.stderr, isNot(contains('error: ')));
+    });
 
     test(
-      'Missing NSLocalNetworkUsageDescription in Info.plist should not fail Xcode compilation, and has plutil error in stdout under verbose mode',
+      'Missing NSLocalNetworkUsageDescription in Info.plist should not fail Xcode compilation',
       () {
         final Directory buildDir = fileSystem.directory('/path/to/builds')
           ..createSync(recursive: true);
         final File infoPlist = buildDir.childFile('Info.plist')..createSync();
-        const plutilErrorMessage =
-            'Could not extract value, error: No value at that key path or invalid key path: NSLocalNetworkUsageDescription';
         final context = TestContext(
           <String>['test_vm_service_bonjour_service'],
           <String, String>{
             'CONFIGURATION': 'Debug',
             'BUILT_PRODUCTS_DIR': buildDir.path,
             'INFOPLIST_PATH': 'Info.plist',
-            'VERBOSE_SCRIPT_LOGGING': 'YES',
           },
           commands: <FakeCommand>[
             FakeCommand(
@@ -629,7 +488,8 @@ void main() {
                 infoPlist.path,
               ],
               exitCode: 1,
-              stderr: plutilErrorMessage,
+              stderr:
+                  'No value at that key path or invalid key path: NSLocalNetworkUsageDescription',
             ),
             FakeCommand(
               command: <String>[
@@ -644,9 +504,7 @@ void main() {
           ],
           fileSystem: fileSystem,
         )..run();
-        expect(context.stderr, isNot(startsWith('error: ')));
-        expect(context.stderr, isNot(contains(plutilErrorMessage)));
-        expect(context.stdout, contains(plutilErrorMessage));
+        expect(context.stderr, isNot(contains('error: ')));
       },
     );
   });
diff --git a/packages/flutter_tools/test/integration.shard/xcode_backend_test.dart b/packages/flutter_tools/test/integration.shard/xcode_backend_test.dart
