Skip to content

Commit 5116f03

Browse files
committed
namespace signup params
* stringify params
1 parent 15f19b1 commit 5116f03

File tree

2 files changed

+11
-13
lines changed

2 files changed

+11
-13
lines changed

lib/ey-core/requests/signup.rb

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,7 @@
11
class Ey::Core::Client
22
class Real
3-
def signup(user, account, features = nil)
4-
params = {
5-
"user" => user,
6-
"account" => account,
7-
}
8-
params["features"] = features if features
3+
def signup(_params)
4+
params = Cistern::Hash.stringify_keys(_params)
95

106
request(
117
:method => :post,
@@ -16,31 +12,33 @@ def signup(user, account, features = nil)
1612
end # Real
1713

1814
class Mock
19-
def signup(user, account, features = nil)
15+
def signup(_params)
2016
if self.authentication != :hmac
2117
response(status: 403)
2218
end
2319

24-
user_id = self.uuid
20+
params = Cistern::Hash.stringify_keys(_params)
2521

26-
user = user.dup
27-
user["token"] = SecureRandom.hex(20)
22+
user_id = self.uuid
2823

24+
user = params["user"].dup
2925
user.merge!({
3026
"id" => user_id,
3127
"accounts" => url_for("/users/#{user_id}/accounts"),
3228
"memberships" => url_for("/users/#{user_id}/memberships"),
3329
"keypairs" => url_for("/users/#{user_id}/keypairs"),
30+
"token" => SecureRandom.hex(20)
3431
})
3532

3633
self.data[:users][user_id] = user
3734

3835
account_id = self.uuid
39-
account = mock_account_setup(account_id, account.dup)
36+
37+
account = mock_account_setup(account_id, params["account"].dup)
4038

4139
self.data[:accounts][account_id] = account.merge(:account_users => [user_id], :account_owners => [user_id])
4240

43-
features.each do |resource_id|
41+
(params["features"] || []).each do |resource_id|
4442
feature = self.data[:features][resource_id]
4543

4644
account_url = url_for("/accounts/#{account_id}")

spec/signups_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
}
2828
features = [ public_feature.id ]
2929

30-
signup = client.signup(user_params, account_params, features).body["signup"]
30+
signup = client.signup(user: user_params, account: account_params, features: features).body["signup"]
3131
user = client.users.get(signup["user_id"])
3232
account = client.accounts.get(signup["account_id"])
3333

0 commit comments

Comments
 (0)