editorconfig (#63)

* editorconfig fixes: use var
* Fixing package publish

---------

Co-authored-by: Nikola Dragićević <nda@enigmatry.com>
Co-authored-by: Milos Stojanovic <mso@enigmatry.com>

Author: 3 people

.editorconfig

@@ -1,18 +1,18 @@
 # To learn more about .editorconfig see https://aka.ms/editorconfigdocs
-############################### 
-# Core EditorConfig Options   # 
-############################### 
-# All files 
-[*] 
+###############################
+# Core EditorConfig Options   #
+###############################
+# All files
+[*]
 indent_style = space
-# Code files 
+# Code files
 [*.{cs,csx,vb,vbx}]
 indent_size = 4
 insert_final_newline = true
 charset = utf-8-bom
-############################### 
-# .NET Coding Conventions     # 
-############################### 
+###############################
+# .NET Coding Conventions     #
+###############################
 [*.{cs,vb}]
 # Organize usings
 dotnet_sort_system_directives_first = true:suggestion
@@ -21,74 +21,96 @@ dotnet_style_qualification_for_field = false:silent
 dotnet_style_qualification_for_property = false:silent
 dotnet_style_qualification_for_method = false:silent
 dotnet_style_qualification_for_event = false:silent
-# Language keywords vs BCL types preferences 
+# Language keywords vs BCL types preferences
 dotnet_style_predefined_type_for_locals_parameters_members = true:suggestion
 dotnet_style_predefined_type_for_member_access = false:suggestion
-# Parentheses preferences 
+# Parentheses preferences
 dotnet_style_parentheses_in_arithmetic_binary_operators = always_for_clarity:silent
 dotnet_style_parentheses_in_relational_binary_operators = always_for_clarity:silent
 dotnet_style_parentheses_in_other_binary_operators = always_for_clarity:silent
 dotnet_style_parentheses_in_other_operators = never_if_unnecessary:silent
-# Modifier preferences 
+# Modifier preferences
 dotnet_style_require_accessibility_modifiers = for_non_interface_members:suggestion
 dotnet_style_readonly_field = true:suggestion
-# Expression-level preferences 
+# Expression-level preferences
 dotnet_style_object_initializer = true:suggestion
-dotnet_style_collection_initializer = true:suggestion
-dotnet_style_explicit_tuple_names = true:suggestion
-dotnet_style_null_propagation = true:suggestion
+dotnet_style_collection_initializer = true:warning
+dotnet_style_explicit_tuple_names = true:error
+dotnet_style_null_propagation = true:error
 dotnet_style_coalesce_expression = true:suggestion
-dotnet_style_prefer_is_null_check_over_reference_equality_method = true:silent 
+dotnet_style_prefer_is_null_check_over_reference_equality_method = true:suggestion
 dotnet_style_prefer_inferred_anonymous_type_member_names = true:suggestion
 dotnet_style_prefer_inferred_tuple_names = true:suggestion
-dotnet_style_prefer_auto_properties = true:silent
-dotnet_style_prefer_conditional_expression_over_assignment = true:silent
-dotnet_style_prefer_conditional_expression_over_return = true:silent
-############################### 
-# C# Coding Conventions       # 
-############################### 
+dotnet_style_prefer_auto_properties = true:suggestion
+dotnet_style_prefer_conditional_expression_over_assignment = true:suggestion
+dotnet_style_prefer_conditional_expression_over_return = true:suggestion
+dotnet_style_operator_placement_when_wrapping = beginning_of_line:suggestion
+dotnet_style_prefer_compound_assignment = true:error
+dotnet_style_prefer_simplified_boolean_expressions = true:warning
+dotnet_style_prefer_simplified_interpolation = true:warning
+dotnet_style_prefer_foreach_explicit_cast_in_source = when_strongly_typed:silent
+dotnet_style_prefer_collection_expression = true:suggestion
+###############################
+# C# Coding Conventions       #
+###############################
 [*.cs]
-# var preferences 
-csharp_style_var_for_built_in_types = true:silent
-csharp_style_var_when_type_is_apparent = true:silent
-csharp_style_var_elsewhere = false:silent
-# Expression-bodied members 
-csharp_style_expression_bodied_methods = false:silent
+# var preferences
+csharp_style_var_elsewhere = true:suggestion
+csharp_style_var_for_built_in_types = true:warning
+csharp_style_var_when_type_is_apparent = true:warning
+csharp_style_prefer_tuple_swap = true:suggestion
+# Expression-bodied members
+csharp_style_expression_bodied_methods = true:suggestion
 csharp_style_expression_bodied_constructors = false:silent
 csharp_style_expression_bodied_operators = false:silent
-csharp_style_expression_bodied_properties = true:silent
+csharp_style_expression_bodied_properties = true:suggestion
 csharp_style_expression_bodied_indexers = true:silent
-csharp_style_expression_bodied_accessors = true:silent
-# Pattern matching preferences 
+csharp_style_expression_bodied_accessors = true:suggestion
+csharp_style_expression_bodied_lambdas = true:silent
+csharp_style_expression_bodied_local_functions = false:silent
+# Expression-level preferences
+csharp_prefer_simple_default_expression = true:error
+csharp_style_deconstructed_variable_declaration = true:silent
+csharp_style_inlined_variable_declaration = true:warning
+csharp_style_pattern_local_over_anonymous_function = true:suggestion
+csharp_style_prefer_index_operator = true:warning
+csharp_style_prefer_range_operator = true:suggestion
+csharp_style_throw_expression = true:warning
+csharp_style_unused_value_assignment_preference = discard_variable:error
+csharp_style_unused_value_expression_statement_preference = discard_variable:silent
+csharp_style_prefer_utf8_string_literals = true:suggestion
+csharp_style_prefer_readonly_struct = true:suggestion
+csharp_style_prefer_readonly_struct_member = true:suggestion
+# Pattern matching preferences
 csharp_style_pattern_matching_over_is_with_cast_check = true:suggestion
 csharp_style_pattern_matching_over_as_with_null_check = true:suggestion
-# Null-checking preferences 
+# Null-checking preferences
 csharp_style_throw_expression = true:suggestion
 csharp_style_conditional_delegate_call = true:suggestion
-# Modifier preferences 
+# Modifier preferences
 csharp_preferred_modifier_order = public,internal,protected,private,static,extern,new,virtual,abstract,sealed,override,readonly,unsafe,volatile,async:suggestion
-# Expression-level preferences 
+# Expression-level preferences
 csharp_prefer_braces = true:silent
 csharp_style_deconstructed_variable_declaration = true:suggestion
 csharp_prefer_simple_default_expression = true:suggestion
 csharp_style_pattern_local_over_anonymous_function = true:suggestion
 csharp_style_inlined_variable_declaration = true:suggestion
-############################### 
-# C# Formatting Rules         # 
-############################### 
-# New line preferences 
+###############################
+# C# Formatting Rules         #
+###############################
+# New line preferences
 csharp_new_line_before_open_brace = all
 csharp_new_line_before_else = true
 csharp_new_line_before_catch = true
 csharp_new_line_before_finally = true
 csharp_new_line_before_members_in_object_initializers = true
 csharp_new_line_before_members_in_anonymous_types = true
 csharp_new_line_between_query_expression_clauses = true
-# Indentation preferences 
+# Indentation preferences
 csharp_indent_case_contents = true
 csharp_indent_switch_labels = true
 csharp_indent_labels = flush_left
-# Space preferences 
+# Space preferences
 csharp_space_after_cast = false
 csharp_space_after_keywords_in_control_flow_statements = true
 csharp_space_between_method_call_parameter_list_parentheses = false
@@ -100,60 +122,60 @@ csharp_space_around_binary_operators = before_and_after
 csharp_space_between_method_declaration_empty_parameter_list_parentheses = false
 csharp_space_between_method_call_name_and_opening_parenthesis = false
 csharp_space_between_method_call_empty_parameter_list_parentheses = false
-# Wrapping preferences 
+# Wrapping preferences
 csharp_preserve_single_line_statements = false
 csharp_preserve_single_line_blocks = true
-############################### 
-# Naming Conventions          # 
-############################### 
-# Style Definitions 
+###############################
+# Naming Conventions          #
+###############################
+# Style Definitions
 dotnet_naming_style.pascal_case_style.capitalization            = pascal_case
 dotnet_naming_style.camel_case_style.capitalization             = camel_case
 dotnet_naming_style.underscore_prefix_style.capitalization      = camel_case
 dotnet_naming_style.underscore_prefix_style.required_prefix     = _
 dotnet_naming_style.interface_prefix_style.capitalization       = pascal_case
 dotnet_naming_style.interface_prefix_style.required_prefix      = I
 # Use PascalCase for types
-dotnet_naming_rule.types_should_be_pascal_case.severity         = suggestion 
-dotnet_naming_rule.types_should_be_pascal_case.symbols          = types 
-dotnet_naming_rule.types_should_be_pascal_case.style            = pascal_case_style 
+dotnet_naming_rule.types_should_be_pascal_case.severity         = suggestion
+dotnet_naming_rule.types_should_be_pascal_case.symbols          = types
+dotnet_naming_rule.types_should_be_pascal_case.style            = pascal_case_style
 dotnet_naming_symbols.types.applicable_kinds                    = class,struct,enum
-dotnet_naming_symbols.types.applicable_accessibilities          = * 
+dotnet_naming_symbols.types.applicable_accessibilities          = *
 # Use camelCase for parameters and local variables
-dotnet_naming_rule.locals_should_be_camel_case.severity         = suggestion 
-dotnet_naming_rule.locals_should_be_camel_case.symbols          = locals 
-dotnet_naming_rule.locals_should_be_camel_case.style            = camel_case_style 
+dotnet_naming_rule.locals_should_be_camel_case.severity         = suggestion
+dotnet_naming_rule.locals_should_be_camel_case.symbols          = locals
+dotnet_naming_rule.locals_should_be_camel_case.style            = camel_case_style
 dotnet_naming_symbols.locals.applicable_kinds                   = parameter
-# Use PascalCase for constant fields   
-dotnet_naming_rule.constant_fields_should_be_pascal_case.severity = suggestion 
+# Use PascalCase for constant fields
+dotnet_naming_rule.constant_fields_should_be_pascal_case.severity = suggestion
 dotnet_naming_rule.constant_fields_should_be_pascal_case.symbols  = constant_fields
-dotnet_naming_rule.constant_fields_should_be_pascal_case.style    = pascal_case_style 
-dotnet_naming_symbols.constant_fields.applicable_kinds            = field 
-dotnet_naming_symbols.constant_fields.applicable_accessibilities  = * 
+dotnet_naming_rule.constant_fields_should_be_pascal_case.style    = pascal_case_style
+dotnet_naming_symbols.constant_fields.applicable_kinds            = field
+dotnet_naming_symbols.constant_fields.applicable_accessibilities  = *
 dotnet_naming_symbols.constant_fields.required_modifiers          = const
-# Use PascalCase for readonly static fields   
-dotnet_naming_rule.static_readonly_fields_should_be_pascal_case.severity = suggestion 
+# Use PascalCase for readonly static fields
+dotnet_naming_rule.static_readonly_fields_should_be_pascal_case.severity = suggestion
 dotnet_naming_rule.static_readonly_fields_should_be_pascal_case.symbols  = static_readonly_fields
-dotnet_naming_rule.static_readonly_fields_should_be_pascal_case.style    = pascal_case_style 
-dotnet_naming_symbols.static_readonly_fields.applicable_kinds            = field 
-dotnet_naming_symbols.static_readonly_fields.applicable_accessibilities  = * 
+dotnet_naming_rule.static_readonly_fields_should_be_pascal_case.style    = pascal_case_style
+dotnet_naming_symbols.static_readonly_fields.applicable_kinds            = field
+dotnet_naming_symbols.static_readonly_fields.applicable_accessibilities  = *
 dotnet_naming_symbols.static_readonly_fields.required_modifiers          = static,readonly
 # Use underscore prefix and camel case for (non-constant) fields
-dotnet_naming_rule.fields_should_be_prefixed_underscore.severity = suggestion 
-dotnet_naming_rule.fields_should_be_prefixed_underscore.symbols  = fields 
-dotnet_naming_rule.fields_should_be_prefixed_underscore.style    = underscore_prefix_style 
-dotnet_naming_symbols.fields.applicable_kinds                    = field 
+dotnet_naming_rule.fields_should_be_prefixed_underscore.severity = suggestion
+dotnet_naming_rule.fields_should_be_prefixed_underscore.symbols  = fields
+dotnet_naming_rule.fields_should_be_prefixed_underscore.style    = underscore_prefix_style
+dotnet_naming_symbols.fields.applicable_kinds                    = field
 dotnet_naming_symbols.fields.applicable_accessibilities          = *
 # Use PascalCase for all members except fields
-dotnet_naming_rule.members_should_be_pascal_case.severity       = suggestion 
-dotnet_naming_rule.members_should_be_pascal_case.symbols        = members 
-dotnet_naming_rule.members_should_be_pascal_case.style          = pascal_case_style 
+dotnet_naming_rule.members_should_be_pascal_case.severity       = suggestion
+dotnet_naming_rule.members_should_be_pascal_case.symbols        = members
+dotnet_naming_rule.members_should_be_pascal_case.style          = pascal_case_style
 dotnet_naming_symbols.members.applicable_kinds                  = property,method,event,delegate
 dotnet_naming_symbols.members.applicable_accessibilities        = *
 # Use PascalCase and I prefix for interfaces
-dotnet_naming_rule.interfaces_should_be_prefixed_with_I.severity   = suggestion 
-dotnet_naming_rule.interfaces_should_be_prefixed_with_I.symbols    = interfaces 
-dotnet_naming_rule.interfaces_should_be_prefixed_with_I.style      = interface_prefix_style 
+dotnet_naming_rule.interfaces_should_be_prefixed_with_I.severity   = suggestion
+dotnet_naming_rule.interfaces_should_be_prefixed_with_I.symbols    = interfaces
+dotnet_naming_rule.interfaces_should_be_prefixed_with_I.style      = interface_prefix_style
 dotnet_naming_symbols.interfaces.applicable_kinds                  = interface
 dotnet_naming_symbols.interfaces.applicable_accessibilities        = *
 

Enigmatry.Entry.CodeGeneration.Configuration.Tests/ExpressionExtensionsFixture.cs

@@ -12,7 +12,7 @@ public void TestGetPropertyInfoFromPropertyExpression()
     {
         Expression<Func<Model1, string>> propertyExpression = model => model.Title;
 
-        System.Reflection.PropertyInfo propertyInfo = propertyExpression.GetPropertyInfo();
+        var propertyInfo = propertyExpression.GetPropertyInfo();
 
         propertyInfo.ShouldNotBeNull();
         propertyInfo.Name.ShouldBe(nameof(Model1.Title));

Enigmatry.Entry.CodeGeneration.Configuration.Tests/Form/FormComponentBuilderFixture.cs

@@ -12,7 +12,7 @@ public void TestBuildFormComponentModel()
     {
         var builder = new FormComponentBuilder<Project1>();
 
-        FormComponentModel componentModel = builder.Build();
+        var componentModel = builder.Build();
 
         componentModel.ShouldNotBeNull();
         componentModel.ComponentInfo.ShouldNotBeNull();

Enigmatry.Entry.CodeGeneration.Configuration.Tests/Form/FormComponentConfigurationFixture.cs

@@ -23,22 +23,22 @@ public void Setup()
     public void TestFormComponentConfiguration()
     {
         _configuration.Configure(_builder);
-        FormComponentModel formComponent = _builder.Build();
+        var formComponent = _builder.Build();
 
         formComponent.ShouldNotBeNull();
         formComponent.ComponentInfo.Name.ShouldBe("ProjectDetails");
         formComponent.ComponentInfo.Feature.Name.ShouldBe("Projects");
 
         formComponent.FormControls.Count.ShouldBe(5);
 
-        Configuration.Form.Controls.FormControl titleFormControl = formComponent.FormControls.Single(x => x.PropertyName == nameof(ProjectDetails.Title).ToLowerInvariant());
+        var titleFormControl = formComponent.FormControls.Single(x => x.PropertyName == nameof(ProjectDetails.Title).ToLowerInvariant());
 
         titleFormControl.ValidationRules.Count.ShouldBe(1);
         titleFormControl.ValidationRules.Single()
             .FormlyRuleName
             .ShouldBe("maxLength");
 
-        Configuration.Form.Controls.FormControl detailsFormControl = formComponent.FormControls.Single(x => x.PropertyName == nameof(ProjectDetails.Description).ToLowerInvariant());
+        var detailsFormControl = formComponent.FormControls.Single(x => x.PropertyName == nameof(ProjectDetails.Description).ToLowerInvariant());
         detailsFormControl.ValidationRules.Count.ShouldBe(1);
         detailsFormControl.ValidationRules.Single()
             .FormlyRuleName
@@ -51,7 +51,7 @@ public void TestExcludedUnconfiguredProperties()
         _builder.Component().IncludeUnconfiguredProperties(false);
 
         _configuration.Configure(_builder);
-        FormComponentModel formComponent = _builder.Build();
+        var formComponent = _builder.Build();
 
         formComponent.ShouldNotBeNull();
         formComponent.FormControls.Count.ShouldBe(4);
@@ -63,7 +63,7 @@ public void TestOrderByModel()
         _builder.Component().OrderBy(OrderByType.Model);
 
         _configuration.Configure(_builder);
-        FormComponentModel formComponent = _builder.Build();
+        var formComponent = _builder.Build();
 
         formComponent.ShouldNotBeNull();
         formComponent.FormControls.Count.ShouldBe(5);
@@ -81,7 +81,7 @@ public void TestOrderByConfiguration()
         _builder.Component().OrderBy(OrderByType.Configuration);
 
         _configuration.Configure(_builder);
-        FormComponentModel formComponent = _builder.Build();
+        var formComponent = _builder.Build();
 
         formComponent.ShouldNotBeNull();
         formComponent.FormControls.Count.ShouldBe(5);

Enigmatry.Entry.CodeGeneration.Configuration.Tests/List/ListComponentBuilderFixture.cs

@@ -14,7 +14,7 @@ public void TestBuildListComponentModel()
         builder.Component().HasName("ProjectList");
         builder.Component().BelongsToFeature("Projects");
 
-        ListComponentModel componentModel = builder.Build();
+        var componentModel = builder.Build();
 
         componentModel.ComponentInfo.Name.ShouldBe("ProjectList");
         componentModel.ComponentInfo.Feature.Name.ShouldBe("Projects");
@@ -24,7 +24,7 @@ public void TestBuildListComponentModel()
     public void TestColumnsAreVisibleByDefault()
     {
         var builder = new ListComponentBuilder<Project1>();
-        ListComponentModel componentModel = builder.Build();
+        var componentModel = builder.Build();
         componentModel.Columns.Count.ShouldBe(2);
     }
 
@@ -39,9 +39,9 @@ public void TestColumnsShouldBeConfigurable()
             .WithHeaderName("Test Title")
             .WithTranslationId("title");
 
-        ListComponentModel componentModel = builder.Build();
+        var componentModel = builder.Build();
 
-        Configuration.List.Model.ColumnDefinition? column = componentModel.Columns.FirstOrDefault(c => c.HeaderName == "Test Title");
+        var column = componentModel.Columns.FirstOrDefault(c => c.HeaderName == "Test Title");
         column.ShouldNotBeNull();
         column!.IsVisible.ShouldBeTrue();
         column.IsSortable.ShouldBeFalse();