Fix checkbox icon color

Author: enisn

sandbox/SandboxMAUI/Pages/CheckBoxPage.xaml.cs

@@ -23,5 +23,10 @@ private void Button_Clicked(object sender, EventArgs e)
                 chk.Color = color;
             }
         }
+
+        if(sender is Button button)
+        {
+            button.BackgroundColor = color;
+        }
     }
 }

src/InputKit/Shared/Controls/CheckBox.cs

@@ -220,7 +220,7 @@ public LabelPosition LabelPosition
 #pragma warning disable CS1591 // Missing XML comment for publicly visible type or member
     public static readonly BindableProperty ColorProperty = BindableProperty.Create(nameof(Color), typeof(Color), typeof(CheckBox), GlobalSetting.Color, propertyChanged: (bo, ov, nv) => (bo as CheckBox).UpdateColors());
     public static readonly BindableProperty TextColorProperty = BindableProperty.Create(nameof(TextColor), typeof(Color), typeof(CheckBox), GlobalSetting.TextColor, propertyChanged: (bo, ov, nv) => (bo as CheckBox).TextColor = (Color)nv);
-    public static readonly BindableProperty IconColorProperty = BindableProperty.Create(nameof(IconColor), typeof(Color), typeof(CheckBox), GlobalSetting.Color, propertyChanged: (bo, ov, nv) => (bo as CheckBox).UpdateColors());
+    public static readonly BindableProperty IconColorProperty = BindableProperty.Create(nameof(IconColor), typeof(Color), typeof(CheckBox), Colors.Transparent, propertyChanged: (bo, ov, nv) => (bo as CheckBox).UpdateColors());
     public static readonly BindableProperty IsCheckedProperty = BindableProperty.Create(nameof(IsChecked), typeof(bool), typeof(CheckBox), false, BindingMode.TwoWay, propertyChanged: (bo, ov, nv) => (bo as CheckBox).ApplyIsCheckedAction(bo as CheckBox, (bool)nv));
     public static readonly BindableProperty IsDisabledProperty = BindableProperty.Create(nameof(IsDisabled), typeof(bool), typeof(CheckBox), false, propertyChanged: (bo, ov, nv) => (bo as CheckBox).IsDisabled = (bool)nv);
     public static readonly BindableProperty KeyProperty = BindableProperty.Create(nameof(Key), typeof(int), typeof(CheckBox), 0, propertyChanged: (bo, ov, nv) => (bo as CheckBox).Key = (int)nv);
@@ -282,17 +282,14 @@ void UpdateColors()
         {
             frmBackground.BorderColor = Color;
             frmBackground.BackgroundColor = IsChecked ? Color : Colors.Transparent;
+            imgSelected.FillColor = Color.ToSurfaceColor();
         }
         else
         {
             frmBackground.BorderColor = IsChecked ? Color : BorderColor;
             frmBackground.BackgroundColor = BoxBackgroundColor;
+            imgSelected.FillColor = IconColor == Colors.Transparent ? Color : IconColor;
         }
-
-        imgSelected.FillColor =
-            IconColor == frmBackground.BackgroundColor ?
-                IconColor.ToSurfaceColor() :
-                IconColor;
     }
 
     void UpdateBorderColor()