Build electron package on Windows with Bazel (#14561)

- Better engine build configuration, building the engine on Windows is now working.
- Bazel configuration for Rust-based installer and uninstaller binaries
- Building installer on Windows works, except for version metadata (WIP on all platforms).

Author: vitvakatu

.bazelrc

@@ -17,7 +17,7 @@ coverage --build_runfile_links
 
 ## Stamping for release builds
 # Enable with --config=release
-build:release --stamp --workspace_status_command="node $(pwd)/internal/workspaceStatus.mjs"
+build:release --stamp --workspace_status_command="node internal/workspaceStatus.mjs"
 
 # Use processwrapper-sandbox strategy by default, to align behavior with CI.
 # Note: this is the default strategy inside Docker containers (because of sandboxing restrictions)

BUILD.bazel

@@ -2,6 +2,7 @@ load("@aspect_bazel_lib//lib:write_source_files.bzl", "write_source_files")
 load("@aspect_rules_ts//ts:defs.bzl", "ts_config")
 load("@buildifier_prebuilt//:rules.bzl", "buildifier")
 load("@npm//:defs.bzl", "npm_link_all_packages")
+load("//:bazel_scripts/distribution_config.bzl", "SBT_SYSTEM_PROPS", "engine_distribution", "get_enso_env")
 load("//:bazel_scripts/run_engine_distribution.bzl", "ensure_native_enso", "run_enso")
 load("//:bazel_scripts/stdlibs.bzl", "stdlib_source_patterns")
 load("//toolchains/sbt:run_sbt.bzl", "run_sbt")
@@ -186,38 +187,6 @@ ENGINE_DIST_SOURCES = STDLIB_SOURCES + SBT_PROJECT_FILES + [
     "std-bits/tableau/src/**",
 ])
 
-SBT_BOOT_DIR = "$$TMPDIR/.sbt/boot"
-
-SBT_IVY_HOME = "$$TMPDIR/.ivy2"
-
-SBT_COURSIER_HOME = "$$TMPDIR/.coursier"
-
-SBT_GLOBAL_BASE = "$$TMPDIR"
-
-SBT_LOCAL_REPOS = "$$TMPDIR/.sbt/repositories"
-
-SBT_SYSTEM_PROPS = [
-    "-Dsbt.repositories.local=" + SBT_LOCAL_REPOS,
-    "-Dsbt.global.base=" + SBT_GLOBAL_BASE,
-    "-Dsbt.boot.directory=" + SBT_BOOT_DIR,
-    "-Dsbt.ivy.home=" + SBT_IVY_HOME,
-    "-Dsbt.coursier.home=" + SBT_COURSIER_HOME,
-    # Copied from .jvmopts
-    # TODO: Create a rule that reads that file?
-    "-Xss16M",
-    "-Xmx4G",
-    "-XX:+UseCompressedOops",
-    "--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED",
-    "--add-exports=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED",
-    "--add-exports=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED",
-    "--add-exports=jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED",
-    "--add-exports=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED",
-    "--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED",
-    "--add-exports=jdk.graal.compiler/jdk.graal.compiler.graphio=ALL-UNNAMED",
-    "--enable-native-access=ALL-UNNAMED",
-    "--sun-misc-unsafe-memory-access=allow",
-]
-
 # These system properties are needed so that sbt will known that it runs as a subprocess of Bazel.
 # In such case, it will avoid running `cargo` or `pnpm` commands on its own,
 # instead, it will expect that all the necessary artifacts are already provided
@@ -236,39 +205,21 @@ SMALL_JDK_SYSTEM_PROPS = [
     "-Denso.BazelSupport.home=$(BINDIR)/home",
 ]
 
-ENV = {
-    "JAVA_HOME": "$(JAVABASE)",
-    "PATH": "$(FLATC_PATH):$(JAVABASE)/bin:$$PATH",
-    "LC_ALL": "C.UTF-8",
-    "SBT_SERVER_FORCESTART": "1",
-}
-
-NATIVE_IMAGE_ENV = dict(
-    ENV,
-    ENSO_LAUNCHER = "native",
-)
-
-run_sbt(
+engine_distribution(
     name = "sbt_build_engine_distribution",
     srcs = ENGINE_DIST_SOURCES,
-    args = [
-        "buildEngineDistribution",
-    ],
-    env = ENV,
+    extra_system_props = EXTRA_SYSTEM_PROPS,
+    native_image = False,
     out_dir = "built-distribution",
-    system_props = SBT_SYSTEM_PROPS + EXTRA_SYSTEM_PROPS,
     visibility = ["//visibility:public"],
 )
 
-run_sbt(
+engine_distribution(
     name = "sbt_build_native_engine_distribution",
     srcs = ENGINE_DIST_SOURCES,
-    args = [
-        "buildEngineDistribution",
-    ],
-    env = NATIVE_IMAGE_ENV,
+    extra_system_props = EXTRA_SYSTEM_PROPS,
+    native_image = True,
     out_dir = "built-distribution-native",
-    system_props = SBT_SYSTEM_PROPS + EXTRA_SYSTEM_PROPS,
     visibility = ["//visibility:public"],
 )
 
@@ -278,7 +229,7 @@ run_sbt(
     args = [
         "buildSmallJdkForRelease",
     ],
-    env = ENV,
+    env = get_enso_env(native_image = False),
     out_dir = "built-small-jdk",
     system_props = SBT_SYSTEM_PROPS + SMALL_JDK_SYSTEM_PROPS,
     visibility = ["//visibility:public"],

Cargo.lock

@@ -26,13 +26,18 @@ single_version_override(
 bazel_dep(name = "bazel_skylib", version = "1.8.1")
 bazel_dep(name = "rules_cc", version = "0.2.12")
 bazel_dep(name = "zlib", version = "1.3.1.bcr.7")
-bazel_dep(name = "aspect_rules_esbuild", version = "0.22.1")
+bazel_dep(name = "aspect_rules_esbuild", version = "0.24.0")
+single_version_override(
+    module_name = "aspect_rules_esbuild",
+    patch_strip = 1,
+    patches = ["patches/aspect_rules_esbuild_windows_fix.patch"],
+)
 
 ## Node.js
 node = use_extension("@rules_nodejs//nodejs:extensions.bzl", "node")
 node.toolchain(node_version = "22.11.0")
 
-tar_toolchain = use_extension("//toolchains:tar/extensions.bzl", "tar_toolchain")
+tar_toolchain = use_extension("//toolchains/tar:extensions.bzl", "tar_toolchain")
 use_repo(tar_toolchain, "tar_toolchain")
 
 register_toolchains("//toolchains:windows_builtin_tar_toolchain")