Fix github workflow (#101)

* Remove tabs
* Fix flake8 errors
* Add quotes around the requirements file
* Install the package before testing it
* Rework testing to debug problems
- Split install and test
- Run tests only on python 2.7
* Runs tests on python 3.6
* Run tests on 3.7

Author: itziakos

.github/workflows/test.yml

@@ -10,7 +10,7 @@ jobs:
   tests:
     strategy:
       matrix:
-        python-version: [2.7, 3.3, 3.4, 3.6, 3.7]
+        python-version: [3.6, 3.7]
         os: [windows-2019]
     runs-on: ${{ matrix.os }}
     steps:
@@ -19,26 +19,32 @@ jobs:
       uses: actions/setup-python@v2
       with:
         python-version: ${{ matrix.python-version }}
-	architecture: 'x64'
+        architecture: 'x64'
+    - name: Install on ${{ matrix.python-version }} 64-bit
+      run: |
+          pip install -e .
+          pip install -r "test-requirements.txt"
+          pip --version
     - name: Test on ${{ matrix.python-version }} 64-bit
       run: |
-          pip install -q -rtest-requirements.txt
-    	  pip --version
-    	  coverage run -p -m haas -v win32ctypes
-    	  pip install --upgrade cffi
-    	  coverage run -p -m haas -v win32ctypes
+          coverage run -m haas -v win32ctypes
+          pip install --upgrade cffi
+          coverage run -m haas -v win32ctypes
     - name: Set up Python ${{ matrix.python-version }}
       uses: actions/setup-python@v2
       with:
         python-version: ${{ matrix.python-version }}
-	architecture: 'x86'
+        architecture: 'x86'
+    - name: Install on ${{ matrix.python-version }} 32-bit
+      run: |
+          pip install -e .
+          pip install -r "test-requirements.txt"
+          pip --version
     - name: test on ${{ matrix.python-version }} 32-bit
       run: |
-          pip install -q -rtest-requirements.txt
-    	  pip --version
-    	  coverage run -p -m haas -v win32ctypes
-    	  pip install --upgrade cffi
-    	  coverage run -p -m haas -v win32ctypes
+          coverage run -p -m haas -v win32ctypes
+          pip install --upgrade cffi
+          coverage run -p -m haas -v win32ctypes
     - uses: actions/upload-artifact@v2
       with:
         name: Upload Coverage info
@@ -55,4 +61,3 @@ jobs:
       run: python -m pip install flake8
     - name: Lint codebase
       run: python -m flake8 win32ctypes/
-      

win32ctypes/core/__init__.py

@@ -27,6 +27,7 @@
 
 # Setup module redirection based on the backend
 
+
 class BackendLoader(Loader):
 
     def __init__(self, redirect_module):
@@ -61,6 +62,7 @@ def find_module(self, fullname, path=None):
         else:
             return None
 
+
 sys.meta_path.append(BackendFinder([
     '_dll', '_authentication', '_time',
     '_common', '_resource', '_nl_support',

win32ctypes/core/cffi/_resource.py

@@ -39,7 +39,7 @@
 BOOL WINAPI EndUpdateResourceW(HANDLE hUpdate, BOOL fDiscard);
 BOOL WINAPI UpdateResourceW(HANDLE hUpdate, LPCTSTR lpType, LPCTSTR lpName, WORD wLanguage, LPVOID lpData, DWORD cbData);
 
-""")
+""")  # noqa
 
 
 def ENUMRESTYPEPROC(callback):

win32ctypes/core/cffi/_system_information.py

@@ -24,11 +24,11 @@
 
 def _GetWindowsDirectory():
     buffer = ffi.new(MAX_PATH_BUF)
-    l = dlls.kernel32.GetWindowsDirectoryW(buffer, MAX_PATH)
-    return ffi.unpack(buffer, l)
+    directory = dlls.kernel32.GetWindowsDirectoryW(buffer, MAX_PATH)
+    return ffi.unpack(buffer, directory)
 
 
 def _GetSystemDirectory():
     buffer = ffi.new(MAX_PATH_BUF)
-    l = dlls.kernel32.GetSystemDirectoryW(buffer, MAX_PATH)
-    return ffi.unpack(buffer, l)
+    directory = dlls.kernel32.GetSystemDirectoryW(buffer, MAX_PATH)
+    return ffi.unpack(buffer, directory)

win32ctypes/core/compat.py

@@ -20,12 +20,12 @@ def is_integer(i):
     text_type = str
 else:
     def is_text(s):
-        return isinstance(s, unicode)
+        return isinstance(s, unicode)  # noqa
 
     def is_bytes(b):
         return isinstance(b, (bytes, str))
 
     def is_integer(i):
-        return isinstance(i, (int, long))
+        return isinstance(i, (int, long))  # noqa
 
-    text_type = unicode
+    text_type = unicode  # noqa

win32ctypes/pywintypes.py

@@ -6,7 +6,7 @@
 # LICENSE.txt
 #
 import warnings
-from win32ctypes.pywin32.pywintypes import *
+from win32ctypes.pywin32.pywintypes import *  # noqa
 
 warnings.warn(
     "Please use 'from win32ctypes.pywin32 import pywintypes'",

win32ctypes/tests/compat.py

@@ -72,7 +72,7 @@ def run(self, result=None):
                 result.errors = []
                 for error in errors:
                     if skip_error in error[1]:
-                        print ('Skipped')
+                        print('Skipped')
                     else:
                         result.errors.append(error)
             return result

win32ctypes/tests/test_win32cred.py

@@ -21,7 +21,8 @@
 
 # find the pywin32 version
 version_file = os.path.join(
-    os.path.dirname(os.path.dirname(win32cred.__file__)), 'pywin32.version.txt')
+    os.path.dirname(
+        os.path.dirname(win32cred.__file__)), 'pywin32.version.txt')
 if os.path.exists(version_file):
     with open(version_file) as handle:
         pywin32_build = handle.read().strip()
@@ -32,7 +33,7 @@
 class TestCred(compat.TestCase):
 
     @unittest.skipIf(
-        pywin32_build == "223" and sys.version_info[:2] == (3,7),
+        pywin32_build == "223" and sys.version_info[:2] == (3, 7),
         "pywin32 version 223 bug with CredRead (mhammond/pywin32#1232)")
     def test_write_to_pywin32(self):
         username = u"john"

win32ctypes/win32api.py

@@ -6,7 +6,7 @@
 # LICENSE.txt
 #
 import warnings
-from win32ctypes.pywin32.win32api import *
+from win32ctypes.pywin32.win32api import *  # noqa
 
 warnings.warn(
     "Please use 'from win32ctypes.pywin32 import win32api'",

win32ctypes/win32cred.py

@@ -6,7 +6,7 @@
 # LICENSE.txt
 #
 import warnings
-from win32ctypes.pywin32.win32cred import *
+from win32ctypes.pywin32.win32cred import *  # noqa
 
 warnings.warn(
     "Please use 'from win32ctypes.pywin32 import win32cred'",