restrict writing one credential attribute for ctypes

Author: itziakos

win32ctypes/core/ctypes/_authentication.py

@@ -72,12 +72,11 @@ def fromdict(cls, credential):
                 count = len(attributes)
                 if count == 0:
                     continue
-                data = (PCREDENTIAL_ATTRIBUTE * count)()
-                for index in range(count):
-                    attribute = CREDENTIAL_ATTRIBUTE.fromdict(
-                        attributes[index])
-                    data[index] = PCREDENTIAL_ATTRIBUTE(attribute)
-                c_credentials.Attributes = cast(data, PCREDENTIAL_ATTRIBUTE)
+                elif count > 1:
+                    raise ValueError('Multiple attributes are not supported')
+                c_attribute = CREDENTIAL_ATTRIBUTE.fromdict(attributes[0])
+                c_pattribute = PCREDENTIAL_ATTRIBUTE(c_attribute)
+                c_credentials.Attributes = c_pattribute
                 c_credentials.AttributeCount = count
             else:
                 setattr(c_credentials, key, credential[key])

win32ctypes/tests/test_authentication.py

@@ -56,15 +56,13 @@ def test_roundtrip(self):
         keyword = 'mysecret-attribute'
         value = b'Created by MiniPyWin32Cred test suite'
         attribute1 = {'Keyword': keyword, 'Value': value, 'Flags': 2}
-        attribute2 = {
-            'Keyword': keyword + '12', 'Value': value[:10], 'Flags': 1}
         data = {
             'Type': CRED_TYPE_GENERIC,
             'TargetName': target,
             'UserName': username,
             'CredentialBlob': password,
             'Comment': comment,
-            'Attributes': (attribute1, attribute2),
+            'Attributes': (attribute1,),
             'Persist': CRED_PERSIST_ENTERPRISE}
 
         # when
@@ -80,9 +78,6 @@ def test_roundtrip(self):
         del result['CredentialBlobSize']
         del result['AttributeCount']
         result['CredentialBlob'] = result['CredentialBlob'].decode('utf-16')
-        for attribute in result['Attributes']:
-            if 'Value' in attribute:
-                attribute['Value'] = attribute['Value']
         self.assertEqual(result, data)
 
 

win32ctypes/tests/test_win32cred.py

@@ -46,7 +46,7 @@ def _demo_attributes(self):
         attribute2 = {
             'Keyword': keyword + '12',
             'Value': b'Attribute from MiniPyWin32', 'Flags': 0}
-        return (attribute1, attribute2)
+        return (attribute1,)
 
     def _demo_credentials(self, UserName=u'jone'):
         return {
@@ -61,6 +61,7 @@ def _demo_credentials(self, UserName=u'jone'):
     @unittest.skipIf(
         pywin32_build == '223' and sys.version_info[:2] == (3, 7),
         'pywin32 version 223 bug with CredRead (mhammond/pywin32#1232)')
+
     def test_write_to_pywin32(self):
         # given
         target = u'jone@doe'