lint: verify that each line contains only one jump

Thomas Bleher · Thomas Bleher · commit 5ad1912d63fb · 2020-12-05T23:20:25.000+01:00
As discussed in #231 and #238, TipToi pens handle a jump after all other actions (even if they are earlier in the list). If there are multiple jumps, only the last has an effect. This lint check verifies that a GME only contains one jump, and that the jump is the last action. This check is true for all GMEs published by Ravensburger.
diff --git a/src/Lint.hs b/src/Lint.hs
@@ -12,6 +12,7 @@ lintTipToi :: TipToiFile -> Segments -> IO ()
 lintTipToi tt segments = do
     let hyps = [ (hyp1, "play indicies are correct")
                , (hyp2, "media indicies are correct")
+               , (hyp3, "at most one jump per line, as last action")
                ]
     forM_ hyps $ \(hyp, desc) -> do
         let wrong = filter (not . hyp) (concat (mapMaybe snd (ttScripts tt)))
@@ -46,6 +47,13 @@ lintTipToi tt segments = do
     hyp2 :: Line ResReg -> Bool
     hyp2 (Line _ _ _ mi) = all (< media_count) mi
 
+    max_one_jump_at_end [] = True
+    max_one_jump_at_end (Jump x : acts) = null acts
+    max_one_jump_at_end (x : acts) = max_one_jump_at_end acts
+
+    hyp3 :: Line ResReg -> Bool
+    hyp3 (Line _ _ as _) = max_one_jump_at_end as
+
     report :: Segment -> Segment -> IO ()
     report (o1,l1,d1) (o2,l2,d2)
         | l1 == l2 && o1 == o2
diff --git a/testsuite/expected/downloaded/Alle meine Tiere.gme.lint.txt b/testsuite/expected/downloaded/Alle meine Tiere.gme.lint.txt
@@ -1,2 +1,3 @@
 All lines do satisfy hypothesis "play indicies are correct"!
 All lines do satisfy hypothesis "media indicies are correct"!
+All lines do satisfy hypothesis "at most one jump per line, as last action"!
diff --git a/testsuite/expected/downloaded/Dein Koerper und Du.gme.lint.txt b/testsuite/expected/downloaded/Dein Koerper und Du.gme.lint.txt
@@ -1,2 +1,3 @@
 All lines do satisfy hypothesis "play indicies are correct"!
 All lines do satisfy hypothesis "media indicies are correct"!
+All lines do satisfy hypothesis "at most one jump per line, as last action"!
diff --git a/testsuite/expected/downloaded/Duell-der-Superquizzer.gme.lint.txt b/testsuite/expected/downloaded/Duell-der-Superquizzer.gme.lint.txt
@@ -1,2 +1,3 @@
 All lines do satisfy hypothesis "play indicies are correct"!
 All lines do satisfy hypothesis "media indicies are correct"!
+All lines do satisfy hypothesis "at most one jump per line, as last action"!
diff --git a/testsuite/expected/downloaded/Expedition Wissen - Aegypten.gme.lint.txt b/testsuite/expected/downloaded/Expedition Wissen - Aegypten.gme.lint.txt
@@ -1,2 +1,3 @@
 All lines do satisfy hypothesis "play indicies are correct"!
 All lines do satisfy hypothesis "media indicies are correct"!
+All lines do satisfy hypothesis "at most one jump per line, as last action"!
diff --git a/testsuite/expected/downloaded/Leserabe Drache.gme.lint.txt b/testsuite/expected/downloaded/Leserabe Drache.gme.lint.txt
@@ -1,2 +1,3 @@
 All lines do satisfy hypothesis "play indicies are correct"!
 All lines do satisfy hypothesis "media indicies are correct"!
+All lines do satisfy hypothesis "at most one jump per line, as last action"!
diff --git a/testsuite/expected/downloaded/Pocket Wissen - Baustellenfahrzeuge.gme.lint.txt b/testsuite/expected/downloaded/Pocket Wissen - Baustellenfahrzeuge.gme.lint.txt
@@ -1,2 +1,3 @@
 All lines do satisfy hypothesis "play indicies are correct"!
 All lines do satisfy hypothesis "media indicies are correct"!
+All lines do satisfy hypothesis "at most one jump per line, as last action"!
diff --git a/testsuite/expected/downloaded/Puzzle Ritterburg.gme.lint.txt b/testsuite/expected/downloaded/Puzzle Ritterburg.gme.lint.txt
@@ -1,2 +1,3 @@
 All lines do satisfy hypothesis "play indicies are correct"!
 All lines do satisfy hypothesis "media indicies are correct"!
+All lines do satisfy hypothesis "at most one jump per line, as last action"!
diff --git a/testsuite/expected/downloaded/Sprichst_Du_Englisch.gme.lint.txt b/testsuite/expected/downloaded/Sprichst_Du_Englisch.gme.lint.txt
@@ -1,2 +1,3 @@
 All lines do satisfy hypothesis "play indicies are correct"!
 All lines do satisfy hypothesis "media indicies are correct"!
+All lines do satisfy hypothesis "at most one jump per line, as last action"!
diff --git a/testsuite/expected/downloaded/WWW Ritter.gme.lint.txt b/testsuite/expected/downloaded/WWW Ritter.gme.lint.txt
@@ -1,2 +1,3 @@
 All lines do satisfy hypothesis "play indicies are correct"!
 All lines do satisfy hypothesis "media indicies are correct"!
+All lines do satisfy hypothesis "at most one jump per line, as last action"!
diff --git a/testsuite/expected/downloaded/WWW Weltatlas.gme.lint.txt b/testsuite/expected/downloaded/WWW Weltatlas.gme.lint.txt
@@ -1,2 +1,3 @@
 All lines do satisfy hypothesis "play indicies are correct"!
 All lines do satisfy hypothesis "media indicies are correct"!
+All lines do satisfy hypothesis "at most one jump per line, as last action"!

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,3 @@`
`1`	`1`	`All lines do satisfy hypothesis "play indicies are correct"!`
`2`	`2`	`All lines do satisfy hypothesis "media indicies are correct"!`
	`3`	`+All lines do satisfy hypothesis "at most one jump per line, as last action"!`