Skip to content

Commit f09e3c3

Browse files
authored
Merge pull request #28 from fjarri/remove-getrandom
Remove an explicit `getrandom` dependency
2 parents 22a0c81 + f16ad6f commit f09e3c3

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

.github/workflows/crypto-primes.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ env:
1212
RUSTFLAGS: "-Dwarnings"
1313

1414
jobs:
15-
build:
15+
build-wasm:
1616
runs-on: ubuntu-latest
1717
strategy:
1818
matrix:
@@ -30,7 +30,6 @@ jobs:
3030
target: ${{ matrix.target }}
3131
override: true
3232
- run: cargo build --target ${{ matrix.target }} --release --no-default-features
33-
- run: cargo build --target ${{ matrix.target }} --release --no-default-features --features default-rng
3433

3534
codecov:
3635
runs-on: ubuntu-latest

CHANGELOG.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
44
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
55

66

7-
## [0.3.1] - Unreleased
7+
## [0.4.0] - Unreleased
8+
9+
### Changed
10+
11+
- `getrandom` is not an explicit dependency anymore. This may break builds with the `wasm32-unknown-unknown` target which relied on `crypto-primes` enabling the `getrandom/js` feature. These builds are advised to do it themselves. ([#28])
12+
813

914
### Fixed
1015

@@ -13,6 +18,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1318

1419

1520
[#26]: https://github.com/nucypher/rust-umbral/pull/26
21+
[#28]: https://github.com/nucypher/rust-umbral/pull/28
1622

1723

1824
## [0.3.0] - 2023-05-05

Cargo.toml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ categories = ["cryptography", "no-std"]
1111
[dependencies]
1212
crypto-bigint = { version = "0.5.2", default-features = false, features = ["rand_core"] }
1313
rand_core = { version = "0.6", default-features = false }
14-
getrandom = { version = "0.2", optional = true, default-features = false, features = ["js"] }
1514
openssl = { version = "0.10", optional = true, features = ["vendored"] }
1615
rug = { version = "1.18", default-features = false, features = ["integer"], optional = true }
1716

@@ -26,7 +25,7 @@ num-prime = "0.4.3"
2625

2726
[features]
2827
default = ["default-rng"]
29-
default-rng = ["getrandom", "rand_core/getrandom"]
28+
default-rng = ["rand_core/getrandom"]
3029
tests-openssl = ["openssl"]
3130
tests-gmp = ["rug"]
3231
tests-exhaustive = []

0 commit comments

Comments
 (0)