chore(deps): update dependency golangci/golangci-lint to v2 (#1156)

Author: renovate[bot]

.golangci.yml

@@ -1,33 +1,42 @@
+version: "2"
+linters:
+  enable:
+    - misspell
+    - revive
+    - whitespace
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    rules:
+      - linters:
+          - dupl
+          - errcheck
+          - gocyclo
+        path: _test\.go
+      - linters:
+          - gocyclo
+        path: pkg/models/envelope.go
+        text: func `\(Envelope\).Balance`
+      - linters:
+          - gocyclo
+        path: pkg/importer/parser/ynab4/parse.go
+        text: func `parseTransactions`
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
 issues:
   fix: true
-
-  # Relax rules for tests
-  exclude-rules:
-    - path: _test\.go
-      linters:
-        - gocyclo
-        - errcheck
-        - dupl
-
-    - path: pkg/models/envelope.go
-      linters:
-        - gocyclo
-      text: "func `\\(Envelope\\).Balance`"
-
-    - path: pkg/importer/parser/ynab4/parse.go
-      linters:
-        - gocyclo
-      text: "func `parseTransactions`"
-
-linters:
+formatters:
   enable:
     - gofumpt
     - goimports
-    - govet
-    - revive
-    - whitespace
-    - misspell
-
-linters-settings:
-  gofumpt:
-    extra-rules: true
+  settings:
+    gofumpt:
+      extra-rules: true
+  exclusions:
+    generated: lax

.pre-commit-config.yaml

@@ -31,14 +31,28 @@ repos:
         language: system
         pass_filenames: false
         entry: swag fmt
-        files: ^pkg/.*
+        files: ^(pkg|internal)/.*
 
       - id: swag init
         name: Create swagger docs.go
         language: system
         pass_filenames: false
         entry: swag init --parseDependency --output ./api
-        files: ^pkg/.*
+        files: ^(pkg|internal)/.*
+
+      - id: go mod tidy
+        name: go mod tidy
+        language: system
+        pass_filenames: false
+        entry: go mod tidy
+        files: ^go\.(mod|sum)$
+
+      - id: golangci-lint
+        name: golangci-lint
+        language: system
+        pass_filenames: false
+        entry: golangci-lint run
+        files: ^.*\.go$
 
       # Taken from https://github.com/rstcheck/rstcheck/blob/178e8c1001aebe2dcbf006e7e6980246704d2315/.pre-commit-config.yaml#L141
       #
@@ -52,11 +66,3 @@ repos:
         # This contains "FIMXE" because I often mistype it
         entry: '(^|//!?|#|<!--|;|/\*(\*|!)?|\.\.)\s*(FIXME:|FIMXE:|BUG:)(?!#i#)'
         exclude: CONTRIBUTING.md
-
-  - repo: https://github.com/dnephin/pre-commit-golang
-    rev: v0.5.1
-    hooks:
-      - id: go-mod-tidy
-      - id: golangci-lint
-        args:
-          - "--timeout=5m"

Makefile

@@ -1,7 +1,7 @@
 .PHONY: setup-pre-commit-ci
 setup-pre-commit-ci:
 # renovate: datasource=github-releases depName=golangci/golangci-lint
-	go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.64.8
+	go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.0.2
 # renovate: datasource=github-releases depName=swaggo/swag
 	go install github.com/swaggo/swag/cmd/[email protected]
 

internal/controllers/v4/month_test.go

@@ -19,7 +19,7 @@ import (
 func (suite *TestSuiteStandard) TestMonthsGet() {
 	budget := createTestBudget(suite.T(), v4.BudgetEditable{})
 
-	r := test.Request(suite.T(), http.MethodGet, strings.Replace(budget.Data.Links.Month, "YYYY-MM", "2022-01", -1), "")
+	r := test.Request(suite.T(), http.MethodGet, strings.ReplaceAll(budget.Data.Links.Month, "YYYY-MM", "2022-01"), "")
 	test.AssertHTTPStatus(suite.T(), &r, http.StatusOK)
 }
 

internal/importer/creator.go

@@ -44,7 +44,7 @@ func Create(db *gorm.DB, resources ParsedResources) (models.Budget, error) {
 			return models.Budget{}, fmt.Errorf("the account '%s' specified in the Match Rule matching '%s' could not be found in the list of Accounts", matchRule.Account, matchRule.Match)
 		}
 
-		matchRule.MatchRule.AccountID = resources.Accounts[aIdx].ID
+		matchRule.AccountID = resources.Accounts[aIdx].ID
 
 		err := tx.Create(&matchRule.MatchRule).Error
 		if err != nil {

internal/importer/parser/ynab-import/parse.go

@@ -72,7 +72,7 @@ func Parse(f io.Reader, account models.Account) ([]importer.TransactionPreview,
 		} else if record[headers["Outflow"]] == "" && record[headers["Inflow"]] == "" {
 			return csvReadError(reader, errors.New("no amount is set for the transaction"))
 		} else if record[headers["Outflow"]] != "" {
-			t.Transaction.SourceAccountID = account.DefaultModel.ID
+			t.Transaction.SourceAccountID = account.ID
 			t.DestinationAccountName = record[headers["Payee"]]
 
 			amount, err := decimal.NewFromString(record[headers["Outflow"]])
@@ -82,7 +82,7 @@ func Parse(f io.Reader, account models.Account) ([]importer.TransactionPreview,
 
 			t.Transaction.Amount = amount
 		} else {
-			t.Transaction.DestinationAccountID = account.DefaultModel.ID
+			t.Transaction.DestinationAccountID = account.ID
 			t.SourceAccountName = record[headers["Payee"]]
 
 			amount, err := decimal.NewFromString(record[headers["Inflow"]])

internal/importer/parser/ynab4/parse_test.go

@@ -332,7 +332,7 @@ func testTransactions(t *testing.T, accounts []models.Account, envelopes []model
 	for _, tt := range tests {
 		t.Run(fmt.Sprintf("%s: %s -> %s - %s", tt.date, tt.sourceAccount, tt.destinationAccount, tt.note), func(t *testing.T) {
 			// Get transaction
-			idx := slices.IndexFunc(transactions, func(t models.Transaction) bool { return t.Date == tt.date && t.Note == tt.note })
+			idx := slices.IndexFunc(transactions, func(t models.Transaction) bool { return t.Date.Equal(tt.date) && t.Note == tt.note })
 			require.NotEqual(t, -1, idx, "No transaction at expected date with expected note")
 			tr := transactions[idx]
 

internal/uuid/uuid_test.go

@@ -28,7 +28,7 @@ func TestUnmarshalParam(t *testing.T) {
 	// A valid UUID in a string parses
 	id := uuid.NewString()
 	assert.Nil(t, u.UnmarshalParam(id))
-	assert.Equal(t, id, u.UUID.String())
+	assert.Equal(t, id, u.String())
 
 	// Empty string parses to Nil UIID
 	id = ""