fix: YNAB import format import does not rely on fixed column order (#826)

Author: morremeyer

pkg/importer/parser/ynab-import/parse.go

@@ -24,12 +24,18 @@ func Parse(f io.Reader, account models.Account) ([]importer.TransactionPreview,
 
 	var transactions []importer.TransactionPreview
 
-	// Skip the first line
-	_, err := reader.Read()
+	// First line contains headers
+	headerRow, err := reader.Read()
 	if err == io.EOF {
 		return []importer.TransactionPreview{}, nil
 	}
 
+	// Build map for header keys
+	headers := map[string]int{}
+	for i := range headerRow {
+		headers[headerRow[i]] = i
+	}
+
 	for {
 		record, err := reader.Read()
 		if err == io.EOF {
@@ -39,7 +45,7 @@ func Parse(f io.Reader, account models.Account) ([]importer.TransactionPreview,
 			return csvReadError(reader, fmt.Errorf("could not read line in CSV: %w", err))
 		}
 
-		date, err := time.Parse("01/02/2006", record[Date])
+		date, err := time.Parse("01/02/2006", record[headers["Date"]])
 		if err != nil {
 			return csvReadError(reader, fmt.Errorf("could not parse time: %w", err))
 		}
@@ -49,31 +55,31 @@ func Parse(f io.Reader, account models.Account) ([]importer.TransactionPreview,
 				Date:          date,
 				AvailableFrom: types.NewMonth(date.Year(), date.Month()),
 				ImportHash:    helpers.Sha256String(strings.Join(record, ",")),
-				Note:          record[Memo],
+				Note:          record[headers["Memo"]],
 				BudgetID:      account.BudgetID,
 			},
 		}
 
 		// Set the source and destination account
-		if record[Outflow] != "" && record[Inflow] != "" {
+		if record[headers["Outflow"]] != "" && record[headers["Inflow"]] != "" {
 			return csvReadError(reader, errors.New("both outflow and inflow are set for the transaction"))
-		} else if record[Outflow] == "" && record[Inflow] == "" {
+		} else if record[headers["Outflow"]] == "" && record[headers["Inflow"]] == "" {
 			return csvReadError(reader, errors.New("no amount is set for the transaction"))
-		} else if record[Outflow] != "" {
+		} else if record[headers["Outflow"]] != "" {
 			t.Transaction.SourceAccountID = account.DefaultModel.ID
-			t.DestinationAccountName = record[Payee]
+			t.DestinationAccountName = record[headers["Payee"]]
 
-			amount, err := decimal.NewFromString(record[Outflow])
+			amount, err := decimal.NewFromString(record[headers["Outflow"]])
 			if err != nil {
 				return csvReadError(reader, errors.New("outflow could not be parsed to a decimal"))
 			}
 
 			t.Transaction.Amount = amount
 		} else {
 			t.Transaction.DestinationAccountID = account.DefaultModel.ID
-			t.SourceAccountName = record[Payee]
+			t.SourceAccountName = record[headers["Payee"]]
 
-			amount, err := decimal.NewFromString(record[Inflow])
+			amount, err := decimal.NewFromString(record[headers["Inflow"]])
 			if err != nil {
 				return csvReadError(reader, errors.New("inflow could not be parsed to a decimal"))
 			}

pkg/importer/parser/ynab-import/parse_test.go

@@ -20,6 +20,7 @@ func TestParse(t *testing.T) {
 	}{
 		{"Empty file", "empty.csv", 0},
 		{"With content", "comdirect-ynap.csv", 3},
+		{"With differently ordered content", "bank2ynab-ynap.csv", 1},
 	}
 
 	for _, tt := range tests {

pkg/importer/parser/ynab-import/types.go

@@ -0,0 +1,2 @@
+Category,Payee,Date,Inflow,Outflow
+,exampleIssuer,11/06/2023,,82.8

testdata/importer/ynab-import/bank2ynab-ynap.csv

@@ -1,4 +1,4 @@
 Date,Payee,Memo,Outflow,Inflow
 04/01/2019,,Test,59.97,
 04/01/2019,,ISHSII-MSCI EUR.SRI EOACC WPKNR: A1H7ZS ISIN: IE00B52VJ196,119.98,
-04/01/2019,Leo Bernard,Lastschrift Sparplan 1,,180.00
+04/01/2019,Leo Bernard,Lastschrift Sparplan 1,,180.00