fix: do not quick allocate for archived envelopes (#673)

Author: morremeyer

pkg/controllers/month.go

@@ -182,7 +182,7 @@ func (co Controller) SetAllocations(c *gin.Context) {
 	// Get all envelope IDs and allocation amounts where there is no allocation
 	// for the request month, but one for the last month
 	if !queryWithRetry(c, co.DB.
-		Joins("JOIN allocations ON allocations.envelope_id = envelopes.id AND allocations.month = ? AND NOT EXISTS(?)", pastMonth, queryCurrentMonth).
+		Joins("JOIN allocations ON allocations.envelope_id = envelopes.id AND envelopes.hidden IS FALSE AND allocations.month = ? AND NOT EXISTS(?)", pastMonth, queryCurrentMonth).
 		Select("envelopes.id, allocations.amount").
 		Table("envelopes").
 		Find(&envelopesAmount)) {

pkg/controllers/month_test.go

@@ -158,6 +158,7 @@ func (suite *TestSuiteStandard) TestSetMonthBudgeted() {
 	category := suite.createTestCategory(models.CategoryCreate{BudgetID: budget.Data.ID})
 	envelope1 := suite.createTestEnvelope(models.EnvelopeCreate{CategoryID: category.Data.ID})
 	envelope2 := suite.createTestEnvelope(models.EnvelopeCreate{CategoryID: category.Data.ID})
+	archivedEnvelope := suite.createTestEnvelope(models.EnvelopeCreate{CategoryID: category.Data.ID, Hidden: true})
 
 	allocation1 := suite.createTestAllocation(models.AllocationCreate{
 		Month:      types.NewMonth(2022, 1),
@@ -171,6 +172,12 @@ func (suite *TestSuiteStandard) TestSetMonthBudgeted() {
 		EnvelopeID: envelope2.Data.ID,
 	})
 
+	_ = suite.createTestAllocation(models.AllocationCreate{
+		Month:      types.NewMonth(2022, 1),
+		Amount:     decimal.NewFromFloat(50),
+		EnvelopeID: archivedEnvelope.Data.ID,
+	})
+
 	// Update in budgeted mode allocations
 	recorder := test.Request(suite.controller, suite.T(), http.MethodPost, strings.Replace(budget.Data.Links.MonthAllocations, "YYYY-MM", "2022-02", 1), controllers.BudgetAllocationMode{Mode: controllers.AllocateLastMonthBudget})
 	assertHTTPStatus(suite.T(), &recorder, http.StatusNoContent)
@@ -189,6 +196,13 @@ func (suite *TestSuiteStandard) TestSetMonthBudgeted() {
 	var envelope2Month controllers.EnvelopeMonthResponse
 	suite.decodeResponse(&recorder, &envelope2Month)
 	suite.Assert().True(allocation2.Data.Amount.Equal(envelope2Month.Data.Allocation), "Expected: %s, got %s, Request ID: %s", allocation2.Data.Amount, envelope2Month.Data.Allocation, recorder.Header().Get("x-request-id"))
+
+	// Verify the allocation for the archived envelope
+	recorder = test.Request(suite.controller, suite.T(), http.MethodGet, strings.Replace(archivedEnvelope.Data.Links.Month, "YYYY-MM", "2022-02", 1), "")
+	assertHTTPStatus(suite.T(), &recorder, http.StatusOK)
+	var archivedEnvelopeMonth controllers.EnvelopeMonthResponse
+	suite.decodeResponse(&recorder, &archivedEnvelopeMonth)
+	suite.Assert().True(archivedEnvelopeMonth.Data.Allocation.IsZero(), "Expected: 0, got %s, Request ID: %s", archivedEnvelopeMonth.Data.Allocation, recorder.Header().Get("x-request-id"))
 }
 
 func (suite *TestSuiteStandard) TestSetMonthSpend() {