fix: do not match archived accounts (#1131)

Author: morremeyer

internal/controllers/v4/import.go

@@ -289,10 +289,10 @@ func ImportYnabImportPreview(c *gin.Context) {
 		return
 	}
 
-	// Get all match rules for the budget that the import target account is part of
+	// Get all match rules for the budget for which the account is not archived
 	var matchRules []models.MatchRule
 	err = models.DB.
-		Joins("JOIN accounts ON accounts.budget_id = ?", account.BudgetID).
+		Joins("JOIN accounts ON accounts.budget_id = ? AND NOT accounts.archived", account.BudgetID).
 		Joins("JOIN match_rules rr ON rr.account_id = accounts.id").
 		Order("rr.priority asc").
 		Find(&matchRules).Error

internal/controllers/v4/import_test.go

@@ -293,6 +293,26 @@ func (suite *TestSuiteStandard) TestImportYnabImportPreviewFindAccounts() {
 	}
 }
 
+// TestImportMatchingNoArchivedAccounts verifies that during an import, match rules for archived accounts
+// are not used
+func (suite *TestSuiteStandard) TestImportMatchingNoArchivedAccounts() {
+	// Create a budget and two existing accounts to use
+	budget := createTestBudget(suite.T(), v4.BudgetEditable{})
+
+	// Account we import to
+	internalAccount := createTestAccount(suite.T(), v4.AccountEditable{BudgetID: budget.Data.ID, Name: "Envelope Zero Account"})
+
+	edeka := createTestAccount(suite.T(), v4.AccountEditable{BudgetID: budget.Data.ID, Name: "Edeka", External: true, Archived: true})
+	_ = createTestMatchRule(suite.T(), v4.MatchRuleEditable{
+		Match:     "Supermarket*",
+		AccountID: edeka.Data.ID,
+	})
+
+	preview := suite.parseCSV(suite.T(), internalAccount.Data.ID, "match-rule-archived-account.csv")
+
+	assert.Equal(suite.T(), uuid.Nil, preview.Data[0].Transaction.DestinationAccountID)
+}
+
 func (suite *TestSuiteStandard) TestImportYnabImportPreviewMatch() {
 	// Create a budget and two existing accounts to use
 	budget := createTestBudget(suite.T(), v4.BudgetEditable{})

test/data/importer/ynab-import/match-rule-archived-account.csv

@@ -0,0 +1,2 @@
+Date,Payee,Memo,Outflow,Inflow
+04/01/2019,Supermarket,,59.97,