refactor: remove unused method TotalBudgeted

Author: morremeyer

pkg/models/budget.go

@@ -120,33 +120,6 @@ func (b Budget) Budgeted(db *gorm.DB, month types.Month) (decimal.Decimal, error
 	return budgeted.Decimal, nil
 }
 
-// TotalBudgeted calculates the total sum that has been budgeted before a specific month.
-func (b Budget) TotalBudgeted(db *gorm.DB, month types.Month) (decimal.Decimal, error) {
-	month = month.AddDate(0, 1)
-
-	var budgeted decimal.NullDecimal
-	err := db.
-		Select("SUM(amount)").
-		Joins("JOIN envelopes ON allocations.envelope_id = envelopes.id AND envelopes.deleted_at IS NULL").
-		Joins("JOIN categories ON envelopes.category_id = categories.id AND categories.deleted_at IS NULL").
-		Joins("JOIN budgets ON categories.budget_id = budgets.id AND budgets.deleted_at IS NULL").
-		Where("budgets.id = ?", b.ID).
-		Where("allocations.month < date(?) ", month).
-		Table("allocations").
-		Find(&budgeted).
-		Error
-	if err != nil {
-		return decimal.Zero, err
-	}
-
-	// If no transactions are found, the value is nil
-	if !budgeted.Valid {
-		return decimal.NewFromFloat(0), nil
-	}
-
-	return budgeted.Decimal, nil
-}
-
 type CategoryEnvelopes struct {
 	ID         uuid.UUID       `json:"id" example:"dafd9a74-6aeb-46b9-9f5a-cfca624fea85"` // ID of the category
 	Name       string          `json:"name" example:"Rainy Day Funds" default:""`         // Name of the category

pkg/models/budget_test.go

@@ -257,26 +257,11 @@ func (suite *TestSuiteStandard) TestBudgetCalculations() {
 	assert.Nil(suite.T(), err)
 	assert.True(suite.T(), income.IsZero(), "Income is %s, should be 0", income)
 
-	// Verify total budgeted for used budget
-	budgeted, err := budget.TotalBudgeted(suite.db, marchTwentyTwentyTwo)
-	assert.Nil(suite.T(), err)
-	assert.True(suite.T(), budgeted.Equal(decimal.NewFromFloat(67)), "Budgeted is %s, should be 67", budgeted)
-
-	// Verify total budgeted for used budget in January after (regression test for using AddDate(0, 1, 0) with the month instead of the whole date)
-	budgeted, err = budget.TotalBudgeted(suite.db, types.NewMonth(2023, 1))
-	assert.Nil(suite.T(), err)
-	assert.True(suite.T(), budgeted.Equal(decimal.NewFromFloat(67)), "Budgeted is %s, should be 67", budgeted)
-
 	// Verify budgeted for used budget
-	budgeted, err = budget.Budgeted(suite.db, marchTwentyTwentyTwo)
+	budgeted, err := budget.Budgeted(suite.db, marchTwentyTwentyTwo)
 	assert.Nil(suite.T(), err)
 	assert.True(suite.T(), budgeted.Equal(decimal.NewFromFloat(25)), "Budgeted is %s, should be 25", budgeted)
 
-	// Verify total budgeted for empty budget
-	budgeted, err = emptyBudget.TotalBudgeted(suite.db, marchTwentyTwentyTwo)
-	assert.Nil(suite.T(), err)
-	assert.True(suite.T(), budgeted.IsZero(), "Budgeted is %s, should be 0", budgeted)
-
 	// Verify budgeted for empty budget
 	budgeted, err = emptyBudget.Budgeted(suite.db, marchTwentyTwentyTwo)
 	assert.Nil(suite.T(), err)
@@ -295,18 +280,6 @@ func (suite *TestSuiteStandard) TestMonthIncomeNoTransactions() {
 	assert.True(suite.T(), income.IsZero(), "Income is %s, should be 0", income)
 }
 
-func (suite *TestSuiteStandard) TestTotalBudgetedNoTransactions() {
-	budget := models.Budget{}
-	err := suite.db.Save(&budget).Error
-	if err != nil {
-		suite.Assert().Fail("Resource could not be saved", err)
-	}
-
-	budgeted, err := budget.TotalBudgeted(suite.db, types.NewMonth(1913, 8))
-	assert.Nil(suite.T(), err)
-	assert.True(suite.T(), budgeted.IsZero(), "Income is %s, should be 0", budgeted)
-}
-
 func (suite *TestSuiteStandard) TestBudgetIncomeDBFail() {
 	budget := models.Budget{}
 
@@ -337,21 +310,6 @@ func (suite *TestSuiteStandard) TestBudgetBudgetedDBFail() {
 	suite.Assert().Equal("sql: database is closed", err.Error())
 }
 
-func (suite *TestSuiteStandard) TestBudgetTotalBudgetedDBFail() {
-	budget := models.Budget{}
-
-	err := suite.db.Save(&budget).Error
-	if err != nil {
-		suite.Assert().Fail("Resource could not be saved", err)
-	}
-
-	suite.CloseDB()
-
-	_, err = budget.TotalBudgeted(suite.db, types.NewMonth(2017, 7))
-	suite.Assert().NotNil(err)
-	suite.Assert().Equal("sql: database is closed", err.Error())
-}
-
 // TestBudgetMonth verifies that the monthly calculations are correct.
 func (suite *TestSuiteStandard) TestMonth() {
 	budget := suite.createTestBudget(models.BudgetCreate{})