fix: error message for availability month is now passed to the user (#800)

Fixes #795.

Author: morremeyer

pkg/httperrors/errors.go

@@ -65,6 +65,11 @@ func DBError(c *gin.Context, err error) ErrorStatus {
 		return ErrorStatus{Status: http.StatusNotFound, Err: errors.New("there is no resource for the ID you specified")}
 	}
 
+	// Availability month is set before the month of the transaction
+	if strings.Contains(err.Error(), "availability month must not be earlier than the month of the transaction") {
+		return ErrorStatus{Status: http.StatusBadRequest, Err: err}
+	}
+
 	// Account name must be unique per Budget
 	if strings.Contains(err.Error(), "UNIQUE constraint failed: accounts.name, accounts.budget_id") {
 		return ErrorStatus{Status: http.StatusBadRequest, Err: errors.New("the account name must be unique for the budget")}

pkg/httperrors/errors_test.go

@@ -171,6 +171,7 @@ func TestDatabaseErrorMessages(t *testing.T) {
 		err  string
 		msg  string
 	}{
+		{http.StatusBadRequest, "availability month must not be earlier than the month of the transaction, transaction date: 2023-10-22, available month 2023-09", "availability month must not be earlier than the month of the transaction, transaction date: 2023-10-22, available month 2023-09"},
 		{http.StatusBadRequest, "CHECK constraint failed: source_destination_different", "source and destination accounts for a transaction must be different"},
 		{http.StatusBadRequest, "UNIQUE constraint failed: accounts.name, accounts.budget_id", "the account name must be unique for the budget"},
 		{http.StatusBadRequest, "UNIQUE constraint failed: categories.name, categories.budget_id", "the category name must be unique for the budget"},

pkg/models/transaction.go

@@ -97,7 +97,7 @@ func (t *Transaction) BeforeSave(tx *gorm.DB) (err error) {
 	if t.AvailableFrom.IsZero() {
 		t.AvailableFrom = types.MonthOf(t.Date)
 	} else if t.AvailableFrom.Before(types.MonthOf(t.Date)) {
-		return fmt.Errorf("availability month must not be earlier than the month of the transaction, transaction date: %s, available month %s", t.Date, t.AvailableFrom)
+		return fmt.Errorf("availability month must not be earlier than the month of the transaction, transaction date: %s, available month %s", t.Date.Format("2006-01-02"), t.AvailableFrom)
 	}
 
 	// Enforce ReconciledSource = false when source account is external