fix: add envelope link, fix zero padding for self link for MonthConfigs (#443)

Author: morremeyer

pkg/controllers/month_config.go

@@ -339,7 +339,8 @@ func (co Controller) getMonthConfigObject(c *gin.Context, mConfig models.MonthCo
 	return MonthConfig{
 		mConfig,
 		MonthConfigLinks{
-			Self: fmt.Sprintf("%s/v1/month-configs/%s/%d-%d", c.GetString("baseURL"), mConfig.EnvelopeID, mConfig.Month.Year(), mConfig.Month.Month()),
+			Self:     fmt.Sprintf("%s/v1/month-configs/%s/%04d-%02d", c.GetString("baseURL"), mConfig.EnvelopeID, mConfig.Month.Year(), mConfig.Month.Month()),
+			Envelope: fmt.Sprintf("%s/v1/envelopes/%s", c.GetString("baseURL"), mConfig.EnvelopeID),
 		},
 	}
 }

pkg/controllers/month_config_test.go

@@ -117,6 +117,17 @@ func (suite *TestSuiteStandard) TestMonthConfigsGet() {
 
 			recorder := test.Request(suite.controller, suite.T(), http.MethodGet, path, "")
 			assert.Equal(t, tt.status, recorder.Code, "Request ID %s", recorder.Header().Get("x-request-id"))
+
+			if tt.status == http.StatusOK {
+				var mConfig controllers.MonthConfigResponse
+				suite.decodeResponse(&recorder, &mConfig)
+
+				selfLink := fmt.Sprintf("http://example.com/v1/month-configs/%s/%s", tt.envelopeID, tt.month)
+				assert.Equal(t, selfLink, mConfig.Data.Links.Self, "Request ID %s", recorder.Header().Get("x-request-id"))
+
+				envelopeLink := fmt.Sprintf("http://example.com/v1/envelopes/%s", tt.envelopeID)
+				assert.Equal(t, envelopeLink, mConfig.Data.Links.Envelope, "Request ID %s", recorder.Header().Get("x-request-id"))
+			}
 		})
 	}
 }