feat: treat transaction note filter parameters like "contains"

Author: morremeyer

pkg/controllers/transaction.go

@@ -11,6 +11,7 @@ import (
 	"github.com/gin-gonic/gin"
 	"github.com/google/uuid"
 	"github.com/shopspring/decimal"
+	"golang.org/x/exp/slices"
 	"gorm.io/gorm"
 )
 
@@ -34,7 +35,7 @@ type TransactionLinks struct {
 type TransactionQueryFilter struct {
 	Date                 time.Time       `form:"date"`
 	Amount               decimal.Decimal `form:"amount"`
-	Note                 string          `form:"note"`
+	Note                 string          `form:"note" filterField:"false"`
 	BudgetID             string          `form:"budget"`
 	SourceAccountID      string          `form:"source"`
 	DestinationAccountID string          `form:"destination"`
@@ -73,7 +74,6 @@ func (f TransactionQueryFilter) ToCreate(c *gin.Context) (models.TransactionCrea
 	return models.TransactionCreate{
 		Date:                 f.Date,
 		Amount:               f.Amount,
-		Note:                 f.Note,
 		BudgetID:             budgetID,
 		SourceAccountID:      sourceAccountID,
 		DestinationAccountID: destinationAccountID,
@@ -224,7 +224,7 @@ func (co Controller) GetTransactions(c *gin.Context) {
 	}
 
 	// Get the fields set in the filter
-	queryFields, _ := httputil.GetURLFields(c.Request.URL, filter)
+	queryFields, setFields := httputil.GetURLFields(c.Request.URL, filter)
 
 	// Convert the QueryFilter to a Create struct
 	create, ok := filter.ToCreate(c)
@@ -254,6 +254,12 @@ func (co Controller) GetTransactions(c *gin.Context) {
 		})
 	}
 
+	if filter.Note != "" {
+		query = query.Where("note LIKE ?", fmt.Sprintf("%%%s%%", filter.Note))
+	} else if slices.Contains(setFields, "Note") {
+		query = query.Where("note = ''")
+	}
+
 	var transactions []models.Transaction
 	if !queryWithRetry(c, query.Find(&transactions)) {
 		return

pkg/controllers/transaction_test.go

@@ -156,6 +156,7 @@ func (suite *TestSuiteStandard) TestGetTransactionsFilter() {
 		{"Exact Amount", fmt.Sprintf("amount=%s", decimal.NewFromFloat(2.718).String()), 2},
 		{"Note", "note=Not important", 1},
 		{"No note", "note=", 1},
+		{"Fuzzy note", "note=important", 2},
 		{"Budget Match", fmt.Sprintf("budget=%s", b.Data.ID), 3},
 		{"Envelope 2", fmt.Sprintf("envelope=%s", e2.Data.ID), 1},
 		{"Non-existing Source Account", "source=3340a084-acf8-4cb4-8f86-9e7f88a86190", 0},