fix: availableFrom now set to correct month for Import Previews (#788)

Resolves #786.

Author: morremeyer

pkg/controllers/import_test.go

@@ -11,6 +11,7 @@ import (
 	"path"
 	"testing"
 
+	"github.com/envelope-zero/backend/v3/internal/types"
 	"github.com/envelope-zero/backend/v3/pkg/controllers"
 	"github.com/envelope-zero/backend/v3/pkg/models"
 	"github.com/envelope-zero/backend/v3/test"
@@ -175,6 +176,22 @@ func (suite *TestSuiteStandard) TestYnabImportPreviewDuplicateDetection() {
 	suite.Assert().Equal(transaction.Data.ID, preview.Data[0].DuplicateTransactionIDs[0], "Duplicate transaction ID is not ID of the transaction that is duplicated")
 }
 
+func (suite *TestSuiteStandard) TestYnabImportAvailableFrom() {
+	// Create test account
+	account := suite.createTestAccount(models.AccountCreate{Name: "TestYnabImportAvailableFrom"})
+	preview := parseCSV(suite, account.Data.ID, "available-from-test.csv")
+
+	dates := []types.Month{
+		types.NewMonth(2019, 2),
+		types.NewMonth(2019, 4),
+		types.NewMonth(2019, 5),
+	}
+
+	for i, transaction := range preview.Data {
+		assert.Equal(suite.T(), dates[i], transaction.Transaction.AvailableFrom)
+	}
+}
+
 func parseCSV(suite *TestSuiteStandard, accountID uuid.UUID, file string) controllers.ImportPreviewList {
 	path := fmt.Sprintf("ynab-import-preview?accountId=%s", accountID.String())
 

pkg/importer/parser/ynab-import/parse.go

@@ -8,6 +8,7 @@ import (
 	"strings"
 	"time"
 
+	"github.com/envelope-zero/backend/v3/internal/types"
 	"github.com/envelope-zero/backend/v3/pkg/importer"
 	"github.com/envelope-zero/backend/v3/pkg/importer/helpers"
 	"github.com/envelope-zero/backend/v3/pkg/models"
@@ -45,10 +46,11 @@ func Parse(f io.Reader, account models.Account) ([]importer.TransactionPreview,
 
 		t := importer.TransactionPreview{
 			Transaction: models.TransactionCreate{
-				Date:       date,
-				ImportHash: helpers.Sha256String(strings.Join(record, ",")),
-				Note:       record[Memo],
-				BudgetID:   account.BudgetID,
+				Date:          date,
+				AvailableFrom: types.NewMonth(date.Year(), date.Month()),
+				ImportHash:    helpers.Sha256String(strings.Join(record, ",")),
+				Note:          record[Memo],
+				BudgetID:      account.BudgetID,
 			},
 		}
 

testdata/importer/ynab-import/available-from-test.csv

@@ -0,0 +1,4 @@
+Date,Payee,Memo,Outflow,Inflow
+02/28/2019,EDEKA Schmidt,Glob Test,59.97,
+04/30/2019,DB Vertrieb GmbH,Glob Train ticket,80.00,
+05/25/2019,Some Company,Glob Salary April 2019,,2350

testdata/importer/ynab-import/rename-rule-test.csv

@@ -0,0 +1,4 @@
+Date,Payee,Memo,Outflow,Inflow
+04/01/2019,EDEKA Schmidt,Glob Test,59.97,
+04/01/2019,DB Vertrieb GmbH,Glob Train ticket,80.00,
+04/25/2019,Some Company,Glob Salary April 2019,,2350