fix: date filter now filters for the date

It filtered for an exact time match before which does not make a lot
of sense.

Author: morremeyer

api/docs.go

@@ -2400,6 +2400,12 @@ const docTemplate = `{
                 ],
                 "summary": "Get transactions",
                 "parameters": [
+                    {
+                        "type": "string",
+                        "description": "Date of the transaction. Ignores exact time, matches on the day of the RFC3339 timestamp provided.",
+                        "name": "date",
+                        "in": "query"
+                    },
                     {
                         "type": "string",
                         "description": "Filter by amount",

api/swagger.json

@@ -2388,6 +2388,12 @@
                 ],
                 "summary": "Get transactions",
                 "parameters": [
+                    {
+                        "type": "string",
+                        "description": "Date of the transaction. Ignores exact time, matches on the day of the RFC3339 timestamp provided.",
+                        "name": "date",
+                        "in": "query"
+                    },
                     {
                         "type": "string",
                         "description": "Filter by amount",

api/swagger.yaml

@@ -2486,6 +2486,11 @@ paths:
     get:
       description: Returns a list of transactions
       parameters:
+      - description: Date of the transaction. Ignores exact time, matches on the day
+          of the RFC3339 timestamp provided.
+        in: query
+        name: date
+        type: string
       - description: Filter by amount
         in: query
         name: amount

pkg/controllers/transaction.go

@@ -33,7 +33,7 @@ type TransactionLinks struct {
 }
 
 type TransactionQueryFilter struct {
-	Date                  time.Time       `form:"date"`
+	Date                  time.Time       `form:"date" filterField:"false"`
 	Amount                decimal.Decimal `form:"amount"`
 	AmountLessOrEqual     decimal.Decimal `form:"amountLessOrEqual" filterField:"false"` // Amount less than or equal to this
 	AmountMoreOrEqual     decimal.Decimal `form:"amountMoreOrEqual" filterField:"false"` // Amount more than or equal to this
@@ -76,7 +76,6 @@ func (f TransactionQueryFilter) ToCreate(c *gin.Context) (models.TransactionCrea
 	}
 
 	return models.TransactionCreate{
-		Date:                  f.Date,
 		Amount:                f.Amount,
 		BudgetID:              budgetID,
 		SourceAccountID:       sourceAccountID,
@@ -201,19 +200,19 @@ func (co Controller) CreateTransaction(c *gin.Context) {
 //	@Failure		404
 //	@Failure		500	{object}	httperrors.HTTPError
 //	@Router			/v1/transactions [get]
-//	@Param			date					query	time.Time	false	"Filter by date"
-//	@Param			amount					query	string		false	"Filter by amount"
-//	@Param			amountLessOrEqual		query	string		false	"Amount less than or equal to this"
-//	@Param			amountMoreOrEqual		query	string		false	"Amount more than or equal to this"
-//	@Param			note					query	string		false	"Filter by note"
-//	@Param			budget					query	string		false	"Filter by budget ID"
-//	@Param			account					query	string		false	"Filter by ID of associated account, regardeless of source or destination"
-//	@Param			source					query	string		false	"Filter by source account ID"
-//	@Param			destination				query	string		false	"Filter by destination account ID"
-//	@Param			envelope				query	string		false	"Filter by envelope ID"
-//	@Param			reconciled				query	bool		false	"DEPRECATED. Filter by reconcilication state"
-//	@Param			reconciledSource		query	bool		false	"Reconcilication state in source account"
-//	@Param			reconciledDestination	query	bool		false	"Reconcilication state in destination account"
+//	@Param			date					query	string	false	"Date of the transaction. Ignores exact time, matches on the day of the RFC3339 timestamp provided."
+//	@Param			amount					query	string	false	"Filter by amount"
+//	@Param			amountLessOrEqual		query	string	false	"Amount less than or equal to this"
+//	@Param			amountMoreOrEqual		query	string	false	"Amount more than or equal to this"
+//	@Param			note					query	string	false	"Filter by note"
+//	@Param			budget					query	string	false	"Filter by budget ID"
+//	@Param			account					query	string	false	"Filter by ID of associated account, regardeless of source or destination"
+//	@Param			source					query	string	false	"Filter by source account ID"
+//	@Param			destination				query	string	false	"Filter by destination account ID"
+//	@Param			envelope				query	string	false	"Filter by envelope ID"
+//	@Param			reconciled				query	bool	false	"DEPRECATED. Filter by reconcilication state"
+//	@Param			reconciledSource		query	bool	false	"Reconcilication state in source account"
+//	@Param			reconciledDestination	query	bool	false	"Reconcilication state in destination account"
 func (co Controller) GetTransactions(c *gin.Context) {
 	var filter TransactionQueryFilter
 	if err := c.Bind(&filter); err != nil {
@@ -235,6 +234,12 @@ func (co Controller) GetTransactions(c *gin.Context) {
 		TransactionCreate: create,
 	}, queryFields...)
 
+	// Filter for the transaction being at the same date
+	if !filter.Date.IsZero() {
+		date := time.Date(filter.Date.Year(), filter.Date.Month(), filter.Date.Day(), 0, 0, 0, 0, time.UTC)
+		query = query.Where("transactions.date >= date(?)", date).Where("transactions.date < date(?)", date.AddDate(0, 0, 1))
+	}
+
 	if filter.AccountID != "" {
 		accountID, ok := httputil.UUIDFromString(c, filter.AccountID)
 		if !ok {

pkg/controllers/transaction_test.go

@@ -158,7 +158,8 @@ func (suite *TestSuiteStandard) TestGetTransactionsFilter() {
 		query string
 		len   int
 	}{
-		{"Exact Date", fmt.Sprintf("date=%s", time.Date(2021, 2, 6, 5, 1, 0, 585, time.UTC).Format(time.RFC3339Nano)), 1},
+		{"Exact Time", fmt.Sprintf("date=%s", time.Date(2021, 2, 6, 5, 1, 0, 585, time.UTC).Format(time.RFC3339Nano)), 1},
+		{"Same date", fmt.Sprintf("date=%s", time.Date(2021, 2, 6, 7, 0, 0, 700, time.UTC).Format(time.RFC3339Nano)), 1},
 		{"Exact Amount", fmt.Sprintf("amount=%s", decimal.NewFromFloat(2.718).String()), 2},
 		{"Note", "note=Not important", 1},
 		{"No note", "note=", 1},