Skip to content

Commit d13558b

Browse files
fix checkstyle violations
1 parent 00f1bd7 commit d13558b

File tree

6 files changed

+11
-14
lines changed

6 files changed

+11
-14
lines changed

core/src/main/java/com/envimate/mapmate/builder/MapMateBuilder.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,19 +51,18 @@
5151

5252
public final class MapMateBuilder {
5353
private static final int INITIAL_CAPACITY = 10000;
54-
private final PackageScanner packageScanner;
5554
public Detector detector = ConventionalDetector.conventionalDetectorWithAnnotations();
55+
private final PackageScanner packageScanner;
5656
private final List<Recipe> recipes = new LinkedList<>();
57-
private Map<MarshallingType, Marshaller> marshallerMap = new HashMap<>(1);
58-
private Map<MarshallingType, Unmarshaller> unmarshallerMap = new HashMap<>(1);
5957
private final ValidationMappings validationMappings = ValidationMappings.empty();
6058
private final ValidationErrorsMapping validationErrorsMapping = validationErrors -> {
6159
throw AggregatedValidationException.fromList(validationErrors);
6260
};
61+
private Map<MarshallingType, Marshaller> marshallerMap = new HashMap<>(1);
62+
private Map<MarshallingType, Unmarshaller> unmarshallerMap = new HashMap<>(1);
6363
private InjectorFactory injectorFactory = InjectorFactory.emptyInjectorFactory();
6464

65-
66-
public MapMateBuilder(final PackageScanner packageScanner) {
65+
private MapMateBuilder(final PackageScanner packageScanner) {
6766
this.packageScanner = packageScanner;
6867
}
6968

core/src/main/java/com/envimate/mapmate/builder/anticorruption/DefinitionsFactory.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@
4848
import static com.envimate.mapmate.serialization.SerializableDataTransferObject.serializableDataTransferObject;
4949
import static com.envimate.mapmate.serialization.SerializableDefinitions.serializableDefinitions;
5050

51-
5251
@ToString
5352
@EqualsAndHashCode
5453
@RequiredArgsConstructor(access = AccessLevel.PRIVATE)
@@ -82,7 +81,6 @@ public SerializableDefinitions toSerializableDefinitions() {
8281
}
8382

8483
return serializableDefinitions(serializableCPs, serializableDTOs);
85-
8684
}
8785

8886
public DeserializableDefinitions toDeserializableDefinitions() {
@@ -111,5 +109,4 @@ public DeserializableDefinitions toDeserializableDefinitions() {
111109

112110
return deserializableDefinitions(deserializableCPs, deserializableDTOs);
113111
}
114-
115112
}

core/src/main/java/com/envimate/mapmate/builder/definitions/CustomPrimitiveDefinition.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ public static CustomPrimitiveDefinition customPrimitiveDefinition(final Class<?>
5858
return untypedCustomPrimitiveDefinition(type, serializer, deserializer);
5959
}
6060

61-
6261
private static CustomPrimitiveDefinition untypedCustomPrimitiveDefinition(
6362
final Class<?> type,
6463
final CustomPrimitiveSerializer<?> serializer,
@@ -146,5 +145,4 @@ private static CustomPrimitiveDeserializer<?> createDeserializer(final Class<?>
146145

147146
return customPrimitiveByMethodDeserializer(deserializationMethod);
148147
}
149-
150148
}

core/src/main/java/com/envimate/mapmate/builder/recipes/primitives/BuiltInPrimitiveSerializedAsStringSupport.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,12 +66,14 @@ public Map<Class<?>, CustomPrimitiveDefinition> customPrimitiveDefinitions() {
6666
);
6767
}
6868

69-
7069
private static <T> CustomPrimitiveDefinition toCustomPrimitiveDefinition(final Class<T> type,
7170
final Function<String, T> deserializer) {
7271
final CustomPrimitiveSerializer<T> customPrimitiveSerializer = obj -> {
73-
if (obj != null) return String.valueOf(obj);
74-
else return null;
72+
if (obj != null) {
73+
return String.valueOf(obj);
74+
} else {
75+
return null;
76+
}
7577
};
7678
return customPrimitiveDefinition(type, customPrimitiveSerializer, deserializer::apply);
7779
}

core/src/test/checkstyle/checkstyle-suppressions.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@
3535
<suppress checks="IllegalCatchCheck" files="Serializer.java"/>
3636
<suppress checks="IllegalCatchCheck" files="Deserializer|When"/>
3737
<suppress checks="MethodLength" files="Deserializer.java"/>
38+
<suppress checks="MethodLength" files="MapMateBuilder.java"/>
39+
<suppress checks="VisibilityModifier" files="MapMateBuilder.java"/>
3840
<suppress
3941
checks="MagicNumber|MethodName|IllegalCatch|LineLength|MethodLength|FinalParameters|FileLength|InnerTypeLast"
4042
files="DeserializerBuilderTest|DeserializerTest|SerializerTest|SerializerBuilderTest|CircularReferenceDetectorTest|Examples"/>

core/src/test/java/com/envimate/mapmate/builder/IndividuallyAddedModelsBuilderTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import com.envimate.mapmate.builder.models.customconvention.Email;
2626
import com.envimate.mapmate.builder.models.customconvention.EmailAddress;
2727
import com.envimate.mapmate.builder.models.customconvention.Subject;
28-
import com.envimate.mapmate.builder.recipes.manualregistry.ManualRegistry;
2928
import com.envimate.mapmate.builder.validation.CustomTypeValidationException;
3029
import com.envimate.mapmate.deserialization.Deserializer;
3130
import com.google.gson.Gson;

0 commit comments

Comments
 (0)