Skip to content

Expand testing suite #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomaszwagerman merged 10 commits into from
Jan 20, 2026
Merged

Expand testing suite #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5dbb3c5
add asyncio as test dep, start batcher tests
thomaszwagerman Aug 5, 2025
b279526
#61: replace all instances of datetime.utcnow()
thomaszwagerman Aug 5, 2025
c3e4cf5
add batcher tests
thomaszwagerman Aug 5, 2025
a1c57c7
correct spelling error in templates.py
thomaszwagerman Aug 5, 2025
6492170
add templating tests
thomaszwagerman Aug 5, 2025
5a8feab
add runners tests
thomaszwagerman Aug 5, 2025
9fc7848
replace yaml examples and rewrite config tests
thomaszwagerman Aug 5, 2025
734608f
rename config test file
thomaszwagerman Aug 5, 2025
f6aedd8
add cli tests
thomaszwagerman Aug 5, 2025
a2b466d
remove unused marker
thomaszwagerman Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 0 additions & 62 deletions examples/invalid_yamls/bad_type.yaml
View file
Open in desktop

This file was deleted.

67 changes: 0 additions & 67 deletions examples/invalid_yamls/invalid_batch_config.yaml
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions examples/invalid_yamls/missing_name.yaml
View file
Open in desktop

This file was deleted.

10 changes: 5 additions & 5 deletions model_ensembler/batcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import logging
import os

from datetime import datetime
from datetime import datetime, timezone
from pprint import pformat

import model_ensembler
Expand Down Expand Up @@ -53,7 +53,7 @@ async def run_batch_item(run):
run_ctx.set(run)
cluster = cluster_ctx.get()

logging.info("Start run {} at {}".format(run.id, datetime.utcnow()))
logging.info("Start run {} at {}".format(run.id, datetime.now(timezone.utc)))
logging.debug(pformat(run))

args = Arguments()
Expand Down Expand Up @@ -141,7 +141,7 @@ async def run_batch_item(run):
logging.error("Run failure caught, abandoning {} but not the "
"batch".format(run.id))

logging.info("End run {} at {}".format(run.id, datetime.utcnow()))
logging.info("End run {} at {}".format(run.id, datetime.now(timezone.utc)))
return job_id, run


Expand All @@ -160,7 +160,7 @@ def do_batch_execution(loop, batch, repeat=False):
ProcessingException: If there is pre or post_batch processing error.
"""

logging.info("Start batch: {}".format(datetime.utcnow()))
logging.info("Start batch: {}".format(datetime.now(timezone.utc)))
logging.debug(pformat(batch))

args = Arguments()
Expand Down Expand Up @@ -266,7 +266,7 @@ def do_batch_execution(loop, batch, repeat=False):

os.chdir(orig)
logging.info("Batch {} completed: {}".
format(batch.name, datetime.utcnow()))
format(batch.name, datetime.now(timezone.utc)))
# TODO: return batch windows/info
return "Success"

Expand Down
2 changes: 1 addition & 1 deletion model_ensembler/templates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ def process_templates(run, template_list):
"""
for tmpl_file in template_list:
if tmpl_file[-3:] != ".j2":
raise TemplatingError("{} doe not appear to be a Jinja2 template "
raise TemplatingError("{} does not appear to be a Jinja2 template "
"(.j2)".format(tmpl_file))

try:
Expand Down
4 changes: 3 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ dependencies = [
[project.optional-dependencies]
tests = [
"pytest",
"pytest-cov"
"pytest-cov",
"pytest-asyncio",
]
lint = [
"flake8"
Expand Down Expand Up @@ -81,3 +82,4 @@ exclude = "docs/"

[tool.distutils.bdist_wheel]
universal = true

Loading