ts: remove unused no_verbose var and modulecmd_start proc

Signed-off-by: Xavier Delaruelle <[email protected]>

Author: xdelaruelle

testsuite/config/unix.exp

@@ -95,9 +95,7 @@ proc default_tclsh {} {
 
 
 #
-# modulecmd_start -- start modulecmd running
-# Since modulecmd writes to both streams, stdout and stderr, a catcher
-# has to be installed in order to scan both 
+# modulecmd_xxx_ -- run modulecmd
 #
 
 # alternative method to collect stdout and stderr from command execution (on
@@ -134,7 +132,6 @@ proc modulecmd_xxx_ {command {input noinput}} {
 	global comp_error
 	global comp_exit
 	global errorCode
-	global no_verbose
 
     if {[info exists ::endpipe]} {
         unset ::endpipe
@@ -162,7 +159,7 @@ proc modulecmd_xxx_ {command {input noinput}} {
         lappend cmdlist << $input
     }
 
-	if { ! $no_verbose && $verbose > 1 } {
+	if { $verbose > 1 } {
         send_user "starting [lrange $cmdlist 1 end]\n"
 	}
 
@@ -195,7 +192,6 @@ proc modulecmd_xxx_ {command {input noinput}} {
 	global comp_error
 	global comp_exit
 	global errorCode
-	global no_verbose
 
 	if ![info exists command] then {
 	  unresolved "internal testsuite error: no module command specified"
@@ -220,7 +216,7 @@ proc modulecmd_xxx_ {command {input noinput}} {
         lappend cmdlist << $input
     }
 
-	if { ! $no_verbose && $verbose > 1 } {
+	if { $verbose > 1 } {
         send_user "starting [lrange $cmdlist 1 end]\n"
 	}
 
@@ -249,14 +245,6 @@ proc modulecmd_xxx_ {command {input noinput}} {
 
 }
 
-proc modulecmd_start {command {input noinput}} {
-	global no_verbose
-
-	set no_verbose 0
-	modulecmd_xxx_ "$command" $input
-	unset no_verbose
-}
-
 
 #
 # Test procedure to check a module installation

testsuite/modules.00-init/006-procs.exp

@@ -47,7 +47,7 @@ proc _test_sub {test_shell cmd {input noinput}} {
 	}
 
 	set shell $test_shell
-	modulecmd_start "$cmd" $input
+	modulecmd_xxx_ "$cmd" $input
 
 	if { $verbose > 1 } {
 		set ol [string length $comp_output]