No warning on {preprend,append}-path --duplicates unload

xdelaruelle · xdelaruelle · commit 383179c9940f · 2021-10-11T06:11:59.000+02:00
Remove warning message when unloading a prepend-path or append-path modulefile command with --duplicates option set. Fixes #421
diff --git a/tcl/envmngt.tcl.in b/tcl/envmngt.tcl.in
@@ -1405,7 +1405,10 @@ proc parsePathCommandArgs {cmd args} {
                }
             }
             --duplicates {
-               if {$cmd eq {unload-path}} {
+               # raise warning when option is used by remove-path but not for
+               # append-path/prepend-path on unload mode
+               if {$cmd eq {unload-path} && ([lindex [info level -2] 0] ne\
+                  {remove-path} || [getState mode] eq {load})} {
                   reportWarning "--duplicates option has no effect on $cmd"
                } else {
                   set allow_dup 1

Original file line number	Diff line number	Diff line change
`@@ -1405,7 +1405,10 @@ proc parsePathCommandArgs {cmd args} {`
`1405`	`1405`	`}`
`1406`	`1406`	`}`
`1407`	`1407`	`--duplicates {`
`1408`		`- if {$cmd eq {unload-path}} {`
	`1408`	`+ # raise warning when option is used by remove-path but not for`
	`1409`	`+ # append-path/prepend-path on unload mode`
	`1410`	`+ if {$cmd eq {unload-path} && ([lindex [info level -2] 0] ne\`
	`1411`	`+ {remove-path} \|\| [getState mode] eq {load})} {`
`1409`	`1412`	`reportWarning "--duplicates option has no effect on $cmd"`
`1410`	`1413`	`} else {`
`1411`	`1414`	`set allow_dup 1`