Refactor setModuleTag call in setLoadedModule

As setModuleTag now ensures no duplicate tag are set, no need to check
if auto-loaded tag is already set. Simplify also the if/else branch as
same commands are applied whether the loaded or auto-loaded tag need to
be set.

Author: xdelaruelle

tcl/modfind.tcl.in

@@ -1212,24 +1212,15 @@ proc setLoadedModule {mod modfile uasked {modvr {}}} {
    set ::g_loadedModules($mod) $modfile
    # a loaded modfile may correspond to multiple loaded virtual modules
    lappend ::g_loadedModuleFiles($modfile) $mod
+
    # record if mod has been asked by user and relative loaded/auto-loaded tag
-   if {$uasked} {
-      setModuleTag $mod loaded
-      # also record tag for module designation including variants if specified
-      if {$modvr ne {} && $mod ne $modvr} {
-         setModuleTag $modvr loaded
-      }
-   # do not register auto-loaded tag if already done (when called from
-   # cacheCurrentModules proc)
-   } else {
-      if {![isModuleTagged $mod auto-loaded 1]} {
-         setModuleTag $mod auto-loaded
-      }
-      if {$modvr ne {} && $mod ne $modvr && ![isModuleTagged $modvr\
-         auto-loaded 1]} {
-         setModuleTag $modvr auto-loaded
-      }
+   set loadedtag [expr {$uasked ? {loaded} : {auto-loaded}}]
+   setModuleTag $mod $loadedtag
+   # also record tag for module designation including variants if specified
+   if {$modvr ne {} && $mod ne $modvr} {
+      setModuleTag $modvr $loadedtag
    }
+
    # build dependency chain
    setModuleDependency $mod
 }