Use cmake 'EVAL CODE' to forward arguments passed to 'module' cmake function

Use cmake 'EVAL CODE' to handle any number of arguments. This change
mandates use of cmake >= 3.18.

The solution comes from the following blog post:
https://crascit.com/2019/01/29/forwarding-command-arguments-in-cmake/

Fixes #419

Signed-off-by: Benoit Dumas <[email protected]>

Author: benoitdudu

tcl/envmngt.tcl.in

@@ -1178,13 +1178,10 @@ end}
       }
       cmake {
          if {[getConf quarantine_support]} {
-            set pre_exec "\n      execute_process(COMMAND \${_mlre} $tclshbin\
-            \"$::argv0\" cmake "
+            set pre_exec "COMMAND \${_mlre} $tclshbin \\\"$::argv0\\\" cmake "
          } else {
-            set pre_exec "\n      execute_process(COMMAND $tclshbin\
-            \"$::argv0\" cmake "
+            set pre_exec "COMMAND $tclshbin \\\"$::argv0\\\" cmake "
          }
-         set post_exec "\n         OUTPUT_FILE \${tempfile_name})\n"
          set fdef {function(module)
    cmake_policy(SET CMP0007 NEW)}
          if {[getConf quarantine_support]} {
@@ -1195,14 +1192,15 @@ end}
       foreach(_mlv ${_mlv_list})
          if(${_mlv} MATCHES "^[A-Za-z_][A-Za-z0-9_]*$")
             if(DEFINED ENV{${_mlv}})
-               set(_mlre "${_mlre}__MODULES_QUAR_${_mlv}=$ENV{${_mlv}};")
+               string(APPEND _mlre
+                      " [===[__MODULES_QUAR_${_mlv}=$ENV{${_mlv}}]===]")
             endif()
             set(_mlrv "MODULES_RUNENV_${_mlv}")
-            set(_mlre "${_mlre}${_mlv}=$ENV{${_mlrv}};")
+            string(APPEND _mlre " [===[${_mlv}=$ENV{${_mlrv}}]===]")
         endif()
       endforeach()
       if (NOT "${_mlre}" STREQUAL "")
-         set(_mlre "env;${_mlre}__MODULES_QUARANTINE_SET=1;")
+         set(_mlre "env ${_mlre} __MODULES_QUARANTINE_SET=1")
       endif()
    endif()}
          }
@@ -1211,23 +1209,17 @@ end}
    execute_process(COMMAND mktemp -t moduleinit.cmake.XXXXXXXXXXXX
       OUTPUT_VARIABLE tempfile_name
       OUTPUT_STRIP_TRAILING_WHITESPACE)
-   if(${ARGC} EQUAL 1)}
-            # adapt command definition depending on the number of args to be
-            # able to pass to some extend (<5 args) empty string element to
-            # modulecmd (no other way as empty element in ${ARGV} are skipped
-            append fdef "$pre_exec\"\${ARGV0}\"$post_exec"
-            append fdef {   elseif(${ARGC} EQUAL 2)}
-            append fdef "$pre_exec\"\${ARGV0}\" \"\${ARGV1}\"$post_exec"
-            append fdef {   elseif(${ARGC} EQUAL 3)}
-            append fdef "$pre_exec\"\${ARGV0}\" \"\${ARGV1}\"\
-               \"\${ARGV2}\"$post_exec"
-            append fdef {   elseif(${ARGC} EQUAL 4)}
-            append fdef "$pre_exec\"\${ARGV0}\" \"\${ARGV1}\"\
-               \"\${ARGV2}\" \"\${ARGV3}\"$post_exec"
-            append fdef {   else()}
-            append fdef "$pre_exec\${ARGV}$post_exec"
-            append fdef {   endif()
-   if(EXISTS ${tempfile_name})
+}
+   append fdef "   set(quotedArgs \"$pre_exec\")"
+   append fdef {
+   cmake_parse_arguments(PARSE_ARGV 0 FWD "" "" "")
+   foreach(arg IN LISTS FWD_UNPARSED_ARGUMENTS)
+      string(APPEND quotedArgs " [===[${arg}]===]")
+   endforeach()
+   string(APPEND quotedArgs " OUTPUT_FILE ${tempfile_name}")
+   cmake_language(EVAL CODE "execute_process(${quotedArgs})")
+}
+   append fdef {   if(EXISTS ${tempfile_name})
       include(${tempfile_name})
       file(REMOVE ${tempfile_name})
    endif()

testsuite/modules.70-maint/120-autoinit.exp

@@ -413,36 +413,28 @@ set func_cmake "function\\\(module\\\)
 \\s*foreach\\\(_mlv \\\${_mlv_list}\\\)
 \\s*if\\\(\\\${_mlv} MATCHES \"\\\^\\\[A-Za-z_\\\]\\\[A-Za-z0-9_\\\]\\\*\\\$\"\\\)
 \\s*if\\\(DEFINED ENV{\\\${_mlv}}\\\)
-\\s*set\\\(_mlre \"\\\${_mlre}__MODULES_QUAR_\\\${_mlv}=\\\$ENV{\\\${_mlv}};\"\\\)
+\\s*string\\\(APPEND _mlre
+\\s*\" \\\[===\\\[__MODULES_QUAR_\\\${_mlv}=\\\$ENV{\\\${_mlv}}\\\]===\\\]\"\\\)
 \\s*endif\\\(\\\)
 \\s*set\\\(_mlrv \"MODULES_RUNENV_\\\${_mlv}\"\\\)
-\\s*set\\\(_mlre \"\\\${_mlre}\\\${_mlv}=\\\$ENV{\\\${_mlrv}};\"\\\)
+\\s*string\\\(APPEND _mlre \" \\\[===\\\[\\\${_mlv}=\\\$ENV{\\\${_mlrv}}\\\]===\\\]\"\\\)
 \\s*endif\\\(\\\)
 \\s*endforeach\\\(\\\)
 \\s*if \\\(NOT \"\\\${_mlre}\" STREQUAL \"\"\\\)
-\\s*set\\\(_mlre \"env;\\\${_mlre}__MODULES_QUARANTINE_SET=1;\"\\\)
+\\s*set\\\(_mlre \"env \\\${_mlre} __MODULES_QUARANTINE_SET=1\"\\\)
 \\s*endif\\\(\\\)
 \\s*endif\\\(\\\)
 \\s*set\\\(_mlstatus TRUE\\\)
 \\s*execute_process\\\(COMMAND mktemp -t moduleinit.cmake.XXXXXXXXXXXX
 \\s*OUTPUT_VARIABLE tempfile_name
 \\s*OUTPUT_STRIP_TRAILING_WHITESPACE\\\)
-\\s*if\\\(\\\${ARGC} EQUAL 1\\\)
-\\s*execute_process\\\(COMMAND \\\${_mlre} $tclshlocre \"$modulecmd_pathre\" cmake \"\\\${ARGV0}\"
-\\s*OUTPUT_FILE \\\${tempfile_name}\\\)
-\\s*elseif\\\(\\\${ARGC} EQUAL 2\\\)
-\\s*execute_process\\\(COMMAND \\\${_mlre} $tclshlocre \"$modulecmd_pathre\" cmake \"\\\${ARGV0}\" \"\\\${ARGV1}\"
-\\s*OUTPUT_FILE \\\${tempfile_name}\\\)
-\\s*elseif\\\(\\\${ARGC} EQUAL 3\\\)
-\\s*execute_process\\\(COMMAND \\\${_mlre} $tclshlocre \"$modulecmd_pathre\" cmake \"\\\${ARGV0}\" \"\\\${ARGV1}\" \"\\\${ARGV2}\"
-\\s*OUTPUT_FILE \\\${tempfile_name}\\\)
-\\s*elseif\\\(\\\${ARGC} EQUAL 4\\\)
-\\s*execute_process\\\(COMMAND \\\${_mlre} $tclshlocre \"$modulecmd_pathre\" cmake \"\\\${ARGV0}\" \"\\\${ARGV1}\" \"\\\${ARGV2}\" \"\\\${ARGV3}\"
-\\s*OUTPUT_FILE \\\${tempfile_name}\\\)
-\\s*else\\\(\\\)
-\\s*execute_process\\\(COMMAND \\\${_mlre} $tclshlocre \"$modulecmd_pathre\" cmake \\\${ARGV}
-\\s*OUTPUT_FILE \\\${tempfile_name}\\\)
-\\s*endif\\\(\\\)
+\\s*set\\\(quotedArgs \"COMMAND \\\${_mlre} $tclshlocre \\\\\"$modulecmd_pathre\\\\\" cmake \"\\\)
+\\s*cmake_parse_arguments\\\(PARSE_ARGV 0 FWD \"\" \"\" \"\"\\\)
+\\s*foreach\\\(arg IN LISTS FWD_UNPARSED_ARGUMENTS\\\)
+\\s*string\\\(APPEND quotedArgs \" \\\[===\\\[\\\${arg}\\\]===\\\]\"\\\)
+\\s*endforeach\\\(\\\)
+\\s*string\\\(APPEND quotedArgs \" OUTPUT_FILE \\\${tempfile_name}\"\\\)
+\\s*cmake_language\\\(EVAL CODE \"execute_process\\\(\\\${quotedArgs}\\\)\"\\\)
 \\s*if\\\(EXISTS \\\${tempfile_name}\\\)
 \\s*include\\\(\\\${tempfile_name}\\\)
 \\s*file\\\(REMOVE \\\${tempfile_name}\\\)
@@ -619,22 +611,13 @@ set func_cmake "function\\\(module\\\)
 \\s*execute_process\\\(COMMAND mktemp -t moduleinit.cmake.XXXXXXXXXXXX
 \\s*OUTPUT_VARIABLE tempfile_name
 \\s*OUTPUT_STRIP_TRAILING_WHITESPACE\\\)
-\\s*if\\\(\\\${ARGC} EQUAL 1\\\)
-\\s*execute_process\\\(COMMAND $tclshlocre \"$modulecmd_pathre\" cmake \"\\\${ARGV0}\"
-\\s*OUTPUT_FILE \\\${tempfile_name}\\\)
-\\s*elseif\\\(\\\${ARGC} EQUAL 2\\\)
-\\s*execute_process\\\(COMMAND $tclshlocre \"$modulecmd_pathre\" cmake \"\\\${ARGV0}\" \"\\\${ARGV1}\"
-\\s*OUTPUT_FILE \\\${tempfile_name}\\\)
-\\s*elseif\\\(\\\${ARGC} EQUAL 3\\\)
-\\s*execute_process\\\(COMMAND $tclshlocre \"$modulecmd_pathre\" cmake \"\\\${ARGV0}\" \"\\\${ARGV1}\" \"\\\${ARGV2}\"
-\\s*OUTPUT_FILE \\\${tempfile_name}\\\)
-\\s*elseif\\\(\\\${ARGC} EQUAL 4\\\)
-\\s*execute_process\\\(COMMAND $tclshlocre \"$modulecmd_pathre\" cmake \"\\\${ARGV0}\" \"\\\${ARGV1}\" \"\\\${ARGV2}\" \"\\\${ARGV3}\"
-\\s*OUTPUT_FILE \\\${tempfile_name}\\\)
-\\s*else\\\(\\\)
-\\s*execute_process\\\(COMMAND $tclshlocre \"$modulecmd_pathre\" cmake \\\${ARGV}
-\\s*OUTPUT_FILE \\\${tempfile_name}\\\)
-\\s*endif\\\(\\\)
+\\s*set\\\(quotedArgs \"COMMAND $tclshlocre \\\\\"$modulecmd_pathre\\\\\" cmake \"\\\)
+\\s*cmake_parse_arguments\\\(PARSE_ARGV 0 FWD \"\" \"\" \"\"\\\)
+\\s*foreach\\\(arg IN LISTS FWD_UNPARSED_ARGUMENTS\\\)
+\\s*string\\\(APPEND quotedArgs \" \\\[===\\\[\\\${arg}\\\]===\\\]\"\\\)
+\\s*endforeach\\\(\\\)
+\\s*string\\\(APPEND quotedArgs \" OUTPUT_FILE \\\${tempfile_name}\"\\\)
+\\s*cmake_language\\\(EVAL CODE \"execute_process\\\(\\\${quotedArgs}\\\)\"\\\)
 \\s*if\\\(EXISTS \\\${tempfile_name}\\\)
 \\s*include\\\(\\\${tempfile_name}\\\)
 \\s*file\\\(REMOVE \\\${tempfile_name}\\\)