Skip to content

Commit bb3d124

Browse files
committed
ts: check if mod is already loaded before looking at avails
Signed-off-by: Xavier Delaruelle <[email protected]>
1 parent b050f3d commit bb3d124

File tree

2 files changed

+6
-19
lines changed

2 files changed

+6
-19
lines changed

testsuite/modules.50-cmds/720-provide.exp

Lines changed: 5 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -201,8 +201,7 @@ lappend ans [list set _LMFILES_ $mp/provide/1:$mp/bar/1]
201201
lappend ans [list set LOADEDMODULES provide/1:bar/1]
202202
testouterr_cmd bash {load bar/1} $ans {}
203203

204-
#FIXME: should find foo/1 already loaded
205-
testouterr_cmd bash {load foo/1} ERR $err_path'foo/1'
204+
testouterr_cmd bash {load foo/1} OK {}
206205

207206
setenv_loaded_module [list bar/1] [list $mp/bar/1]
208207
setenv_var __MODULES_LMALTNAME bar/1&al|foo/1
@@ -213,8 +212,7 @@ lappend ans [list set _LMFILES_ $mp/bar/1:$mp/provide/1]
213212
lappend ans [list set LOADEDMODULES bar/1:provide/1]
214213
testouterr_cmd bash {load provide/1} $ans {}
215214

216-
#FIXME: should find foo/1 already loaded
217-
testouterr_cmd bash {load foo/1} ERR $err_path'foo/1'
215+
testouterr_cmd bash {load foo/1} OK {}
218216

219217
set ans [list]
220218
lappend ans [list unset __MODULES_LMALTNAME]
@@ -226,8 +224,7 @@ testouterr_cmd bash {unload foo/1} $ans {}
226224
setenv_loaded_module [list bar/1 provide/1] [list $mp/bar/1 $mp/provide/1]
227225
setenv_var __MODULES_LMALTNAME bar/1&al|foo/1:provide/1&al|foo/1
228226

229-
#FIXME: should find foo/1 already loaded
230-
testouterr_cmd bash {load foo/1} ERR $err_path'foo/1'
227+
testouterr_cmd bash {load foo/1} OK {}
231228

232229
setenv_var MODULES_UNLOAD_MATCH_ORDER returnlast
233230
set ans [list]
@@ -375,12 +372,7 @@ testouterr_cmd bash {load provide/1} $ans {}
375372
setenv_loaded_module [list provide/1] [list $mp/provide/1]
376373
setenv_var __MODULES_LMALTNAME provide/1&al|foo
377374

378-
#FIXME: should find foo already loaded
379-
set ans [list]
380-
lappend ans [list set __MODULES_LMALTNAME provide/1&al|foo:bar/1&al|foo]
381-
lappend ans [list set _LMFILES_ $mp/provide/1:$mp/bar/1]
382-
lappend ans [list set LOADEDMODULES provide/1:bar/1]
383-
testouterr_cmd bash {load foo} $ans {}
375+
testouterr_cmd bash {load foo} OK {}
384376

385377
set ans [list]
386378
lappend ans [list unset __MODULES_LMALTNAME]
@@ -460,12 +452,7 @@ testouterr_cmd bash {load provide/1} $ans {}
460452
setenv_loaded_module [list provide/1] [list $mp/provide/1]
461453
setenv_var __MODULES_LMALTNAME provide/1&al|provide/foo
462454

463-
#FIXME: should find provide/foo already loaded
464-
set ans [list]
465-
lappend ans [list set __MODULES_LMALTNAME provide/1&al|provide/foo:provide/2&provide/foo]
466-
lappend ans [list set _LMFILES_ $mp/provide/1:$mp/provide/2]
467-
lappend ans [list set LOADEDMODULES provide/1:provide/2]
468-
testouterr_cmd bash {load provide/foo} $ans {}
455+
testouterr_cmd bash {load provide/foo} OK {}
469456

470457
set ans [list]
471458
lappend ans [list unset __MODULES_LMALTNAME]

testsuite/modules.70-maint/274-adv_version_spec-autosym.exp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -490,7 +490,7 @@ setenv_loaded_module [list autosym8/2] [list $mp/autosym8/2]
490490
setenv_var __MODULES_LMALTNAME autosym8/2&al|autosym8/3&as|autosym8/default&as|autosym8/latest
491491
testouterr_cmd sh {is-loaded autosym8/default} OK {}
492492
testouterr_cmd sh {is-loaded autosym8/latest} OK {}
493-
testouterr_cmd sh {load autosym8/latest} ERR $err_path'autosym8/latest'
493+
testouterr_cmd sh {load autosym8/latest} OK {}
494494
testouterr_cmd sh {load autosym8} OK {}
495495
testouterr_cmd sh {list} OK "$cur_loaded\n 1) autosym8/2 "
496496
testouterr_cmd sh {avail -t autosym8/latest} OK {}

0 commit comments

Comments
 (0)