script: use user-writable dir for install tests in mrel

Change Modules build tests to install in a user-writable directory (in
/tmp). Sudo privileges are thus not needed anymore for this stage.

Remove the build test from the local git repository. This installation
style is covered by the installation test from the fetched repository.

Signed-off-by: Xavier Delaruelle <[email protected]>

Author: xdelaruelle

script/mrel

@@ -102,6 +102,7 @@ if {$argc > 1} {
 if {[catch {
 
 set exitcode 0
+set instdir /tmp/mods+test-install
 set rpmbuilddir $env(HOME)/rpmbuild
 set srpmdir $rpmbuilddir/SRPMS
 set rpmdir $rpmbuilddir/RPMS/$tcl_platform(machine)
@@ -176,7 +177,7 @@ set ghexporturl https://github.com/$ghremtgt/archive/$reltag.tar.gz
 
 # clean previous release files
 file delete -force /tmp/mods+test-gz /tmp/mods+test-bz2 /tmp/mods+test-clone\
-   /tmp/mods+test-export
+   /tmp/mods+test-export $instdir
 file mkdir /tmp/mods+test-gz /tmp/mods+test-bz2 /tmp/mods+test-clone\
    /tmp/mods+test-export
 reportInfo {Recreate test directory /tmp/mods+test-gz and /tmp/mods+test-bz2\
@@ -287,77 +288,67 @@ quitorcont
 runcmd 2>@$logfid git push --force $gh_test_remote c-3.2
 runcmd 2>@$logfid git push --force $gh_test_remote $relbranch
 runcmd 2>@$logfid git push --force $gh_test_remote $reltag
-# see Phase 7 for CI result check
-
-
-# Phase 3: build, test, install from git repository
-# ---------------------------------------------------------
-
-runcmd make
-runcmd script/mt
-runcmd 2>@$logfid sudo make install
-runcmd script/mt install
-runcmd 2>@$logfid sudo make uninstall
+# see Phase 6 for CI result check
 
 
-# Phase 4: build, test, install from generated dists
+# Phase 3: build, test, install from generated dists
 # ---------------------------------------------------------
 
 cd /tmp/mods+test-gz
 runcmd tar xfz $cwd/$distgz
 cd modules-$relver
 reportInfo "Moved into '[pwd]' directory"
-runcmd ./configure
+runcmd ./configure --prefix=$instdir
 runcmd make
 runcmd 2>@$logfid script/mt
-runcmd 2>@$logfid sudo make install
+runcmd 2>@$logfid make install
 runcmd script/mt install
-runcmd 2>@$logfid sudo make uninstall
+runcmd 2>@$logfid make uninstall
 runcmd make clean
 
 cd /tmp/mods+test-bz2
 runcmd tar xfj $cwd/$distbz
 cd modules-$relver
 reportInfo "Moved into '[pwd]' directory"
-runcmd ./configure
+runcmd ./configure --prefix=$instdir
 runcmd make
 runcmd 2>@$logfid script/mt
-runcmd 2>@$logfid sudo make install
+runcmd 2>@$logfid make install
 runcmd script/mt install
-runcmd 2>@$logfid sudo make uninstall
+runcmd 2>@$logfid make uninstall
 runcmd make clean
 
 cd /tmp/mods+test-clone
 runcmd 2>@$logfid git clone $ghcloneurl
 cd modules
 reportInfo "Moved into '[pwd]' directory"
 runcmd 2>@$logfid git checkout $relbranch
-runcmd 2>@$logfid ./configure
+runcmd 2>@$logfid ./configure --prefix=$instdir
 runcmd make
 runcmd 2>@$logfid script/mt quick
-runcmd 2>@$logfid sudo make install
+runcmd 2>@$logfid make install
 runcmd script/mt install
-runcmd 2>@$logfid sudo make uninstall
+runcmd 2>@$logfid make uninstall
 runcmd make clean
 
 cd /tmp/mods+test-export
 runcmd 2>@$logfid wget -O $reltag.tar.gz $ghexporturl
 runcmd tar xfz $reltag.tar.gz
 cd modules-$relver
 reportInfo "Moved into '[pwd]' directory"
-runcmd ./configure
+runcmd ./configure --prefix=$instdir
 runcmd make
 runcmd 2>@$logfid script/mt quick
-runcmd 2>@$logfid sudo make install
+runcmd 2>@$logfid make install
 runcmd script/mt install
-runcmd 2>@$logfid sudo make uninstall
+runcmd 2>@$logfid make uninstall
 runcmd make clean
 
 cd $cwd
 reportInfo "Moved back into '[pwd]' directory"
 
 
-# Phase 5: build, test, install from RPM built locally
+# Phase 4: build, test, install from RPM built locally
 # ---------------------------------------------------------
 
 runcmd 2>@$logfid rpmbuild --rebuild $srcrpm
@@ -369,7 +360,7 @@ foreach rpmpkg [glob $rpmdir/environment-modules-$rpmrelver.*.rpm] {
 }
 
 
-# Phase 6: build and test on Fedora platform
+# Phase 5: build and test on Fedora platform
 # ---------------------------------------------------------
 
 # get list of targets
@@ -438,7 +429,7 @@ while {[array size koji_tasks]} {
 }
 
 
-# Phase 7: verify CI result
+# Phase 6: verify CI result
 # ---------------------------------------------------------
 
 reportInfo "Checking CI tests status on $ghstatusurl"