No require/incompat extra spec match if --not-req is set

Do not match module commands with --not-req option set on require or
incompat extra specifier queries.

Fixes #498

Author: xdelaruelle

NEWS.rst

@@ -27,6 +27,8 @@ Modules 5.3.1 (not yet released)
   (fix issue #496)
 * Fix extra specifier search when an identical module name and version is
   available in several modulepaths. (fix issue #497)
+* Do not match module commands with :mfcmd:`--not-req<module>` option set on
+  ``require`` or ``incompat`` extra specifier queries. (fix issue #498)
 
 .. _Hunspell: https://hunspell.github.io/
 

doc/source/module.rst

@@ -2577,7 +2577,8 @@ same trend ``prereq-all`` is an alias on ``depends-on`` and vice versa.
 Regarding ``switch-off`` and ``switch-on`` elements they correspond
 respectively to the module to unload (if specified) and the module to load on
 a ``module switch`` command. ``switch`` is an alias that matches both
-``switch-off`` and ``switch-on`` elements.
+``switch-off`` and ``switch-on`` elements. ``require`` and ``incompat``
+*elements* do not match module commands where ``--not-req`` option is set.
 
 When several extra specifiers are set on a module search query, they act as an
 *AND* operation. Which means modules listed in result are those matching all

tcl/modscan.tcl

@@ -172,25 +172,36 @@ proc module-sc {command args} {
          show_mtime show_filter search_filter search_match dump_state\
          addpath_pos not_req tag_list args
       set modspeclist [parseModuleSpecification 0 0 0 0 {*}$args]
+
+      # no require/incompat extra specifier alias if --not-req option is set
+      if {$not_req} {
+         set xtaliasinc {}
+         set xtaliasreq {}
+      } else {
+         set xtaliasinc [list incompat]
+         set xtaliasreq [list require]
+      }
+
       if {$command eq {switch}} {
          # distinguish switched-off module spec from switched-on
          # ignore command without or with too much argument
          switch -- [llength $modspeclist] {
             {1} {
                # no switched-off module with one-arg form
-               recordScanModuleElt $modspeclist switch switch-on require
+               recordScanModuleElt $modspeclist switch switch-on\
+                  {*}$xtaliasreq
             }
             {2} {
                lassign $modspeclist swoffarg swonarg
-               recordScanModuleElt $swoffarg switch switch-off incompat
-               recordScanModuleElt $swonarg switch switch-on require
+               recordScanModuleElt $swoffarg switch switch-off {*}$xtaliasinc
+               recordScanModuleElt $swonarg switch switch-on {*}$xtaliasreq
             }
          }
       } else {
-         set xtalias [expr {$command eq {unload} ? {incompat} : {require}}]
+         set xtalias [expr {$command eq {unload} ? $xtaliasinc : $xtaliasreq}]
          # record each module spec
          foreach modspec $modspeclist {
-            recordScanModuleElt $modspec $command $xtalias
+            recordScanModuleElt $modspec $command {*}$xtalias
          }
       }
    }