chore(lint): fix revive, unconvert, and testifylint in image generation and tracing

- Ignore unused parameters in tests and translator (revive)\n- Remove unnecessary string conversions now that model types are strings (unconvert)\n- Use require.Empty for empty string check (testifylint)\n- Remove unused test variable in span tests (unused)\n- Keep extractUsageFromBufferEvent with lint ignore for future parity

Signed-off-by: Hrushikesh Patil <[email protected]>

Author: nutanix-Hrushikesh

go.mod

@@ -84,7 +84,6 @@ require (
 	github.com/AzureAD/microsoft-authentication-library-for-go v1.5.0 // indirect
 	github.com/Microsoft/go-winio v0.6.2 // indirect
 	github.com/NYTimes/gziphandler v1.1.1 // indirect
-	github.com/andybalholm/brotli v1.2.0 // indirect
 	github.com/antlr4-go/antlr/v4 v4.13.1 // indirect
 	github.com/asaskevich/govalidator v0.0.0-20230301143203-a9d515a09cc2 // indirect
 	github.com/avast/retry-go v3.0.0+incompatible // indirect

internal/extproc/mocks_test.go

@@ -525,6 +525,7 @@ func (m *mockImageGenerationMetrics) StartRequest(map[string]string) {}
 func (m *mockImageGenerationMetrics) SetOriginalModel(originalModel string) {
 	m.model = originalModel
 }
+
 func (m *mockImageGenerationMetrics) SetRequestModel(requestModel string) {
 	m.model = requestModel
 }

internal/extproc/translator/translator.go

@@ -18,7 +18,6 @@ import (
 	"github.com/envoyproxy/ai-gateway/internal/apischema/openai"
 	"github.com/envoyproxy/ai-gateway/internal/internalapi"
 	tracing "github.com/envoyproxy/ai-gateway/internal/tracing/api"
-	openaisdk "github.com/openai/openai-go/v2"
 )
 
 const (

internal/tracing/api/api.go

@@ -16,7 +16,6 @@ import (
 	"go.opentelemetry.io/otel/trace"
 
 	"github.com/envoyproxy/ai-gateway/internal/apischema/openai"
-	openaisdk "github.com/openai/openai-go/v2"
 )
 
 var _ Tracing = NoopTracing{}

internal/tracing/image_generation_span.go

@@ -10,7 +10,6 @@ import (
 	"go.opentelemetry.io/otel/trace"
 
 	tracing "github.com/envoyproxy/ai-gateway/internal/tracing/api"
-	openaisdk "github.com/openai/openai-go/v2"
 )
 
 // Ensure imageGenerationSpan implements ImageGenerationSpan.

internal/tracing/image_generation_tracer.go

@@ -15,7 +15,6 @@ import (
 	"go.opentelemetry.io/otel/trace/noop"
 
 	tracing "github.com/envoyproxy/ai-gateway/internal/tracing/api"
-	openaisdk "github.com/openai/openai-go/v2"
 )
 
 // Ensure imageGenerationTracer implements ImageGenerationTracer.

internal/tracing/openinference/openai/image_generation.go

@@ -17,7 +17,6 @@ import (
 
 	tracing "github.com/envoyproxy/ai-gateway/internal/tracing/api"
 	"github.com/envoyproxy/ai-gateway/internal/tracing/openinference"
-	openaisdk "github.com/openai/openai-go/v2"
 )
 
 // ImageGenerationRecorder implements recorders for OpenInference image generation spans.
@@ -89,7 +88,7 @@ func buildImageGenerationRequestAttributes(req *openaisdk.ImageGenerateParams, b
 	attrs := []attribute.KeyValue{
 		attribute.String(openinference.SpanKind, openinference.SpanKindLLM),
 		attribute.String(openinference.LLMSystem, openinference.LLMSystemOpenAI),
-		attribute.String(openinference.LLMModelName, string(req.Model)),
+		attribute.String(openinference.LLMModelName, req.Model),
 	}
 
 	if config.HideInputs {