Skip to content

Commit 58ae337

Browse files
committed
more
Signed-off-by: Takeshi Yoneda <[email protected]>
1 parent db8fa38 commit 58ae337

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

internal/dynamic_module/upstream_filter.go

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,7 @@ func (f *upstreamFilter) RequestHeaders(e sdk.EnvoyHTTPFilter, _ bool) sdk.Reque
3737
e.SendLocalReply(500, nil, []byte("router filter pointer not found in dynamic metadata"))
3838
return sdk.RequestHeadersStatusStopIteration
3939
}
40-
// Parse %d string to uintptr
41-
rfPtr, err := strconv.ParseUint(rfPtrStr, 10, 64)
40+
rfPtr, err := strconv.ParseInt(rfPtrStr, 10, 64)
4241
if err != nil {
4342
e.SendLocalReply(500, nil, []byte(fmt.Sprintf("invalid router filter pointer: %v", err)))
4443
return sdk.RequestHeadersStatusStopIteration
@@ -92,6 +91,8 @@ func (f *upstreamFilter) RequestBody(e sdk.EnvoyHTTPFilter, endOfStream bool) sd
9291
b := f.backend
9392

9493
// TODO: endpoint specific logic such as translation.
94+
var newBody []byte
95+
_ = newBody
9596

9697
if bm := b.Backend.BodyMutation; bm != nil {
9798
// TODO: body mutation if needed.
@@ -100,7 +101,12 @@ func (f *upstreamFilter) RequestBody(e sdk.EnvoyHTTPFilter, endOfStream bool) sd
100101

101102
// Next is to do the upstream auth if needed.
102103
if b.Handler != nil {
103-
authHeaders, err := b.Handler.Do(context.Background(), f.reqHeaders, f.rf.originalRequestBodyRaw)
104+
var originalOrNewBody []byte
105+
if newBody != nil {
106+
originalOrNewBody = newBody
107+
}
108+
109+
authHeaders, err := b.Handler.Do(context.Background(), f.reqHeaders, originalOrNewBody)
104110
if err != nil {
105111
e.SendLocalReply(500, nil, []byte(fmt.Sprintf("failed to do backend auth: %v", err)))
106112
return sdk.RequestBodyStatusStopIterationAndBuffer

0 commit comments

Comments
 (0)