extproc: call defer cancel

Signed-off-by: Hrushikesh Patil <[email protected]>

Author: nutanix-Hrushikesh

internal/extproc/server.go

@@ -150,7 +150,7 @@ func (s *Server) Process(stream extprocv3.ExternalProcessor_ProcessServer) error
 	// an earlier filter has already processed the request headers/bodies and decided to terminate
 	// the request by sending an immediate response. In this case, we will use the passThroughProcessor
 	// to pass the request through without any processing as there would be nothing to process from AI Gateway's perspective.
-	var p Processor = passThroughProcessor{}
+	var p Processor
 	var isUpstreamFilter bool
 	var internalReqID string
 	var originalReqID string
@@ -233,7 +233,10 @@ func (s *Server) Process(stream extprocv3.ExternalProcessor_ProcessServer) error
 				logger = s.logger.With("request_id", originalReqID, "is_upstream_filter", isUpstreamFilter)
 			}
 
-			// At this point, p is guaranteed to be a valid processor either from the concrete processor or the passThroughProcessor.
+			// At this point, ensure p has a valid processor either from the concrete processor or the passThroughProcessor.
+			if p == nil {
+				p = passThroughProcessor{}
+			}
 			resp, err := s.processMsg(ctx, logger, p, req, internalReqID, isUpstreamFilter)
 			if err != nil {
 				s.logger.Error("error processing request message", slog.String("error", err.Error()))

tests/extproc/mcp/mcp_test.go

@@ -675,6 +675,7 @@ func testNotificationCancelled(t *testing.T, m *mcpEnv) {
 	s := m.newSession(t)
 
 	ctx, cancel := context.WithCancel(t.Context()) //nolint: govet
+	defer cancel()
 	doneCh := make(chan any)
 	go func() {
 		_, _ = s.session.CallTool(ctx, &mcp.CallToolParams{