Skip to content

Conversation

@zhaohuabing
Copy link
Member

@zhaohuabing zhaohuabing commented Dec 4, 2025

Description

Improve the comment for the MCP ScopesSupported API - highlight that this should be the minimal set of scopes for basic functionality.

Reference: https://modelcontextprotocol.io/specification/2025-11-25/basic/security_best_practices#scope-minimization

Related Issues/PRs (if applicable)
#1608

@zhaohuabing zhaohuabing requested a review from a team as a code owner December 4, 2025 01:45
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 4, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.24%. Comparing base (e0326cd) to head (f20efca).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1612   +/-   ##
=======================================
  Coverage   83.24%   83.24%           
=======================================
  Files         137      137           
  Lines       12042    12042           
=======================================
  Hits        10024    10024           
  Misses       1411     1411           
  Partials      607      607           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zhaohuabing zhaohuabing changed the title update comments for ScopesSupported docs: update comments for ScopesSupported Dec 4, 2025
Copy link
Member

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍

@mathetake mathetake merged commit 2c64a87 into envoyproxy:main Dec 4, 2025
31 of 38 checks passed
@zhaohuabing zhaohuabing deleted the scope-comment branch December 4, 2025 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants