You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Allow asn header to be populate from isp_db in MaxMind geoip provider. (#39303)
Allows the asn header to be populated from the isp_db when it is
defined. If both asn_db and isp_db are defined, we fetch the asn header
from the asn DB.
Looking back at the proposed change that got approved
https://github.com/envoyproxy/envoy/pull/38714/files and reading the
documentation for the databases:
https://dev.maxmind.com/geoip/docs/databases/asn/https://dev.maxmind.com/geoip/docs/databases/isp/
While we have clear separation of database names, there is an overlap of
fields between asn and isp dbs. Since the subscription model of Maxmind
doesn't include all dbs, if you have access only to the isp db, you can
still get the autonomous_system_number from it.
I believe this also help users that are using the isp db on the geoip
filter that haven't been able to migrate from version 1.33 but want to.
---------
Signed-off-by: Leonardo da Mata <[email protected]>
Signed-off-by: Julien Bisconti <[email protected]>
Mirrored from https://github.com/envoyproxy/envoy @ a5dbcbe81a54910c02aa76854d1396244d65d584
0 commit comments