Skip to content

Commit 982e897

Browse files
Ext_proc: do not support fail_open+FULL_DUPLEX_STREAMED configuraton combination (#39740)
With FULL_DUPLEX_STREAMED mode, the fail open support is a little bit tricky as there is no copy of body chunks stored in Envoy. Reject FULL_DUPLEX_STREAMED+fail_open configuration combination for now. --------- Signed-off-by: Yanjun Xiang <[email protected]> Mirrored from https://github.com/envoyproxy/envoy @ 4861b2057afbc67290da0ec77ae1f1af60f152d0
1 parent c4a6ffb commit 982e897

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

envoy/extensions/filters/http/ext_proc/v3/ext_proc.proto

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,11 @@ message ExternalProcessor {
167167
(xds.annotations.v3.field_status).work_in_progress = true
168168
];
169169

170-
// By default, if the gRPC stream cannot be established, or if it is closed
170+
// If the ``BodySendMode`` in the
171+
// :ref:`processing_mode <envoy_v3_api_field_extensions.filters.http.ext_proc.v3.ExternalProcessor.processing_mode>`
172+
// is set to ``FULL_DUPLEX_STREAMED``, ``failure_mode_allow`` can not be set to true.
173+
//
174+
// Otherwise, by default, if the gRPC stream cannot be established, or if it is closed
171175
// prematurely with an error, the filter will fail. Specifically, if the
172176
// response headers have not yet been delivered, then it will return a 500
173177
// error downstream. If they have been delivered, then instead the HTTP stream to the

0 commit comments

Comments
 (0)