Skip to content

Commit c741076

Browse files
Add the ability to turn off huffman for given http2 protocol option. (#42263)
Commit Message: Add the ability to selectively remove huffman encoding headers as the sender for a given hop. Additional Description: This is just envoyproxy/envoy#38270 without the wonked git history from being an old PR. Risk Level: low (off by default) Testing: Unit test, Running in Prod Docs Changes: n/a Release Notes: included Platform Specific Features: n/a Fixes: #38025 --------- Signed-off-by: Kevin Baichoo <[email protected]> Mirrored from https://github.com/envoyproxy/envoy @ 5f2ccbd1bdc463a80d7184ba5d7c3eb659739fe7
1 parent 730f753 commit c741076

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

envoy/config/core/v3/protocol.proto

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -487,7 +487,7 @@ message KeepaliveSettings {
487487
[(validate.rules).duration = {gte {nanos: 1000000}}];
488488
}
489489

490-
// [#next-free-field: 18]
490+
// [#next-free-field: 19]
491491
message Http2ProtocolOptions {
492492
option (udpa.annotations.versioning).previous_message_type =
493493
"envoy.api.v2.core.Http2ProtocolOptions";
@@ -678,6 +678,12 @@ message Http2ProtocolOptions {
678678

679679
// Configure the maximum amount of metadata than can be handled per stream. Defaults to ``1 MB``.
680680
google.protobuf.UInt64Value max_metadata_size = 17;
681+
682+
// Controls whether to encode headers using huffman encoding.
683+
// This can be useful in cases where the cpu spent encoding the headers isn't
684+
// worth the network bandwidth saved e.g. for localhost.
685+
// If unset, uses the data plane's default value.
686+
google.protobuf.BoolValue enable_huffman_encoding = 18;
681687
}
682688

683689
// [#not-implemented-hide:]

0 commit comments

Comments
 (0)