Skip to content

Commit dd8baae

Browse files
docs: clean up c-ares docs and make it consistent (#39912)
Signed-off-by: Rohit Agrawal <[email protected]> Mirrored from https://github.com/envoyproxy/envoy @ 3eea652a45ab4466333a7de9b17cb5ab32982efa
1 parent 3c1afe3 commit dd8baae

File tree

1 file changed

+20
-11
lines changed

1 file changed

+20
-11
lines changed

envoy/extensions/network/dns_resolver/cares/v3/cares_dns_resolver.proto

Lines changed: 20 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -22,16 +22,16 @@ option (udpa.annotations.file_status).package_version_status = ACTIVE;
2222
// Configuration for c-ares DNS resolver.
2323
// [#next-free-field: 9]
2424
message CaresDnsResolverConfig {
25-
// A list of dns resolver addresses.
26-
// :ref:`use_resolvers_as_fallback<envoy_v3_api_field_extensions.network.dns_resolver.cares.v3.CaresDnsResolverConfig.use_resolvers_as_fallback>`
25+
// A list of DNS resolver addresses.
26+
// :ref:`use_resolvers_as_fallback <envoy_v3_api_field_extensions.network.dns_resolver.cares.v3.CaresDnsResolverConfig.use_resolvers_as_fallback>`
2727
// below dictates if the DNS client should override system defaults or only use the provided
2828
// resolvers if the system defaults are not available, i.e., as a fallback.
2929
repeated config.core.v3.Address resolvers = 1;
3030

3131
// If true use the resolvers listed in the
32-
// :ref:`resolvers<envoy_v3_api_field_extensions.network.dns_resolver.cares.v3.CaresDnsResolverConfig.resolvers>`
32+
// :ref:`resolvers <envoy_v3_api_field_extensions.network.dns_resolver.cares.v3.CaresDnsResolverConfig.resolvers>`
3333
// field only if c-ares is unable to obtain a
34-
// nameserver from the system (e.g., /etc/resolv.conf).
34+
// nameserver from the system (e.g., ``/etc/resolv.conf``).
3535
// Otherwise, the resolvers listed in the resolvers list will override the default system
3636
// resolvers. Defaults to false.
3737
bool use_resolvers_as_fallback = 3;
@@ -45,27 +45,36 @@ message CaresDnsResolverConfig {
4545
// Configuration of DNS resolver option flags which control the behavior of the DNS resolver.
4646
config.core.v3.DnsResolverOptions dns_resolver_options = 2;
4747

48-
// This option allows for number of UDP based DNS queries to be capped. Note, this
49-
// is only applicable to c-ares DNS resolver currently.
48+
// This option allows the number of UDP based DNS queries to be capped.
49+
//
50+
// .. note::
51+
// This is only applicable to c-ares DNS resolver currently.
52+
//
5053
google.protobuf.UInt32Value udp_max_queries = 5;
5154

5255
// The number of seconds each name server is given to respond to a query on the first try of any given server.
5356
//
54-
// Note: While the c-ares library defaults to 2 seconds, Envoy's default (if this field is unset) is 5 seconds.
55-
// This adjustment was made to maintain the previous behavior after users reported an increase in DNS resolution times.
57+
// .. note::
58+
// While the c-ares library defaults to 2 seconds, Envoy's default (if this field is unset) is 5 seconds.
59+
// This adjustment was made to maintain the previous behavior after users reported an increase in DNS resolution times.
60+
//
5661
google.protobuf.UInt64Value query_timeout_seconds = 6 [(validate.rules).uint64 = {gte: 1}];
5762

5863
// The maximum number of query attempts the resolver will make before giving up.
5964
// Each attempt may use a different name server.
6065
//
61-
// Note: While the c-ares library defaults to 3 attempts, Envoy's default (if this field is unset) is 4 attempts.
62-
// This adjustment was made to maintain the previous behavior after users reported an increase in DNS resolution times.
66+
// .. note::
67+
// While the c-ares library defaults to 3 attempts, Envoy's default (if this field is unset) is 4 attempts.
68+
// This adjustment was made to maintain the previous behavior after users reported an increase in DNS resolution times.
69+
//
6370
google.protobuf.UInt32Value query_tries = 7 [(validate.rules).uint32 = {gte: 1}];
6471

6572
// Enable round-robin selection of name servers for DNS resolution. When enabled, the resolver will cycle through the
6673
// list of name servers for each resolution request. This can help distribute the query load across multiple name
6774
// servers. If disabled (default), the resolver will try name servers in the order they are configured.
6875
//
69-
// Note: This setting overrides any system configuration for name server rotation.
76+
// .. note::
77+
// This setting overrides any system configuration for name server rotation.
78+
//
7079
bool rotate_nameservers = 8;
7180
}

0 commit comments

Comments
 (0)