[kafka] Fix incorrect exception code (#40210)

ravenblackx · web-flow · commit 3776520dc26d · 2025-07-11T16:54:20.000-07:00
Commit Message: [kafka] Fix incorrect exception code
Additional Description: This isn't java, we don't `new` everything.

Signed-off-by: Raven Black &lt;ravenblack@dropbox.com&gt;
diff --git a/contrib/kafka/filters/network/source/broker/rewriter.cc b/contrib/kafka/filters/network/source/broker/rewriter.cc
@@ -25,7 +25,7 @@ template <typename T> static T& extractResponseData(AbstractResponseSharedPtr& a
   using TSharedPtr = std::shared_ptr<Response<T>>;
   TSharedPtr cast = std::dynamic_pointer_cast<typename TSharedPtr::element_type>(arg);
   if (nullptr == cast) {
-    throw new EnvoyException("bug: response class not matching response API key");
+    throw EnvoyException("bug: response class not matching response API key");
   } else {
     return cast->data_;
   }

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ template <typename T> static T& extractResponseData(AbstractResponseSharedPtr& a`
`25`	`25`	`using TSharedPtr = std::shared_ptr<Response<T>>;`
`26`	`26`	`TSharedPtr cast = std::dynamic_pointer_cast<typename TSharedPtr::element_type>(arg);`
`27`	`27`	`if (nullptr == cast) {`
`28`		`- throw new EnvoyException("bug: response class not matching response API key");`
	`28`	`+ throw EnvoyException("bug: response class not matching response API key");`
`29`	`29`	`} else {`
`30`	`30`	`return cast->data_;`
`31`	`31`	`}`