Replace deprecated Protobuf::ParseFromArray (#41845)

Risk Level: none
Testing: unit tests
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Signed-off-by: Yan Avlasov <[email protected]>

Author: yanavlasov

source/extensions/common/wasm/context.cc

@@ -934,7 +934,7 @@ WasmResult Context::grpcCall(std::string_view grpc_service, std::string_view ser
                              std::string_view request, std::chrono::milliseconds timeout,
                              uint32_t* token_ptr) {
   GrpcService service_proto;
-  if (!service_proto.ParseFromArray(grpc_service.data(), grpc_service.size())) {
+  if (!service_proto.ParseFromString(grpc_service)) {
     auto cluster_name = std::string(grpc_service.substr(0, grpc_service.size()));
     const auto thread_local_cluster = clusterManager().getThreadLocalCluster(cluster_name);
     if (thread_local_cluster == nullptr) {
@@ -983,7 +983,7 @@ WasmResult Context::grpcStream(std::string_view grpc_service, std::string_view s
                                std::string_view method_name, const Pairs& initial_metadata,
                                uint32_t* token_ptr) {
   GrpcService service_proto;
-  if (!service_proto.ParseFromArray(grpc_service.data(), grpc_service.size())) {
+  if (!service_proto.ParseFromString(grpc_service)) {
     auto cluster_name = std::string(grpc_service.substr(0, grpc_service.size()));
     const auto thread_local_cluster = clusterManager().getThreadLocalCluster(cluster_name);
     if (thread_local_cluster == nullptr) {

source/extensions/common/wasm/foreign.cc

@@ -96,7 +96,7 @@ RegisterForeignFunction registerVerifySignatureForeignFunction(
     [](WasmBase&, std::string_view arguments,
        const std::function<void*(size_t size)>& alloc_result) -> WasmResult {
       envoy::source::extensions::common::wasm::VerifySignatureArguments args;
-      if (args.ParseFromArray(arguments.data(), arguments.size())) {
+      if (args.ParseFromString(arguments)) {
         const auto& hash = args.hash_function();
         auto signature_str = args.signature();
         auto text_str = args.text();
@@ -209,7 +209,7 @@ RegisterForeignFunction registerSetEnvoyFilterStateForeignFunction(
     [](WasmBase&, std::string_view arguments,
        const std::function<void*(size_t size)>&) -> WasmResult {
       envoy::source::extensions::common::wasm::SetEnvoyFilterStateArguments args;
-      if (args.ParseFromArray(arguments.data(), arguments.size())) {
+      if (args.ParseFromString(arguments)) {
         auto context = static_cast<Context*>(proxy_wasm::current_context_);
         return context->setEnvoyFilterState(args.path(), args.value(),
                                             toFilterStateLifeSpan(args.span()));
@@ -393,7 +393,7 @@ class DeclarePropertyFactory {
     WasmForeignFunction f = [self](WasmBase&, std::string_view arguments,
                                    const std::function<void*(size_t size)>&) -> WasmResult {
       envoy::source::extensions::common::wasm::DeclarePropertyArguments args;
-      if (args.ParseFromArray(arguments.data(), arguments.size())) {
+      if (args.ParseFromString(arguments)) {
         CelStateType type = CelStateType::Bytes;
         switch (args.type()) {
         case envoy::source::extensions::common::wasm::WasmType::Bytes:

test/extensions/filters/http/wasm/test_data/test_cpp.cc

@@ -790,7 +790,7 @@ void TestRootContext::onTick() {
           if (WasmResult::Ok == proxy_call_foreign_function(function.data(), function.size(), in.data(),
                                                             in.size(), &out, &out_size)) {
               envoy::source::extensions::common::wasm::VerifySignatureResult result;
-              if (result.ParseFromArray(out, static_cast<int>(out_size)) && result.result()) {
+              if (result.ParseFromString(absl::string_view(out, out_size)) && result.result()) {
                   logInfo("signature is valid");
               } else {
                   logError(result.error());
@@ -814,7 +814,7 @@ void TestRootContext::onTick() {
           if (WasmResult::Ok == proxy_call_foreign_function(function.data(), function.size(), in.data(),
                                                             in.size(), &out, &out_size)) {
               envoy::source::extensions::common::wasm::VerifySignatureResult result;
-              if (result.ParseFromArray(out, static_cast<int>(out_size)) && result.result()) {
+              if (result.ParseFromString(absl::string_view(out, out_size)) && result.result()) {
                   logCritical("signature should not be ok");
               } else {
                   logError(result.error());
@@ -837,7 +837,7 @@ void TestRootContext::onTick() {
           if (WasmResult::Ok == proxy_call_foreign_function(function.data(), function.size(), in.data(),
                                                             in.size(), &out, &out_size)) {
               envoy::source::extensions::common::wasm::VerifySignatureResult result;
-              if (result.ParseFromArray(out, static_cast<int>(out_size)) && result.result()) {
+              if (result.ParseFromString(absl::string_view(out, out_size)) && result.result()) {
                   logCritical("signature should not be ok");
               } else {
                   logError(result.error());
@@ -861,7 +861,7 @@ void TestRootContext::onTick() {
           if (WasmResult::Ok == proxy_call_foreign_function(function.data(), function.size(), in.data(),
                                                             in.size(), &out, &out_size)) {
               envoy::source::extensions::common::wasm::VerifySignatureResult result;
-              if (result.ParseFromArray(out, static_cast<int>(out_size)) && result.result()) {
+              if (result.ParseFromString(absl::string_view(out, out_size)) && result.result()) {
                   logCritical("signature should not be ok");
               } else {
                   logError(result.error());