Skip to content

Commit 87eb239

Browse files
authored
Quiet -Woverloaded-virtual for FieldChecker (in gcc) (#41883)
Commit Message: Quiet -Woverloaded-virtual for FieldChecker (in gcc) Additional Description: [Example of the noise](https://github.com/envoyproxy/envoy/actions/runs/19056203905/job/54426871948). ``` In file included from ./source/extensions/filters/http/proto_api_scrubber/scrubbing_util_lib/field_checker.h:8, from source/extensions/filters/http/proto_api_scrubber/scrubbing_util_lib/field_checker.cc:1: external/com_google_protoprocessinglib/proto_processing_lib/proto_scrubber/field_checker_interface.h:77:29: warning: ‘virtual proto_processing_lib::proto_scrubber::FieldCheckResults proto_processing_lib::proto_scrubber::FieldCheckerInterface::CheckField(const std::vector<std::__cxx11::basic_string<char> >&, const google::protobuf::Field*, int, const google::protobuf::Type*) const’ was hidden [-Woverloaded-virtual=] 77 | virtual FieldCheckResults CheckField( | ^~~~~~~~~~ ./source/extensions/filters/http/proto_api_scrubber/scrubbing_util_lib/field_checker.h:40:21: note: by ‘virtual proto_processing_lib::proto_scrubber::FieldCheckResults Envoy::Extensions::HttpFilters::ProtoApiScrubber::FieldChecker::CheckField(const std::vector<std::__cxx11::basic_string<char> >&, const google::protobuf::Field*) const’ 40 | FieldCheckResults CheckField(const std::vector<std::string>& path, | ^~~~~~~~~~ ``` Risk Level: No behavior change. Testing: No behavior change. Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Raven Black <[email protected]>
1 parent f3e9ece commit 87eb239

File tree

1 file changed

+4
-0
lines changed
  • source/extensions/filters/http/proto_api_scrubber/scrubbing_util_lib

1 file changed

+4
-0
lines changed

source/extensions/filters/http/proto_api_scrubber/scrubbing_util_lib/field_checker.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,10 @@ class FieldChecker : public FieldCheckerInterface {
3333
FieldChecker& operator=(const FieldChecker&) = delete;
3434
~FieldChecker() override {}
3535

36+
// Make all the overloads from the base class visible here so the one explicit
37+
// override doesn't hide the other signatures.
38+
using FieldCheckerInterface::CheckField;
39+
3640
/**
3741
* Returns whether the `field` should be included (kInclude), excluded (kExclude)
3842
* or traversed further (kPartial).

0 commit comments

Comments
 (0)