Commit 87eb239
authored
Quiet -Woverloaded-virtual for FieldChecker (in gcc) (#41883)
Commit Message: Quiet -Woverloaded-virtual for FieldChecker (in gcc)
Additional Description: [Example of the
noise](https://github.com/envoyproxy/envoy/actions/runs/19056203905/job/54426871948).
```
In file included from ./source/extensions/filters/http/proto_api_scrubber/scrubbing_util_lib/field_checker.h:8,
from source/extensions/filters/http/proto_api_scrubber/scrubbing_util_lib/field_checker.cc:1:
external/com_google_protoprocessinglib/proto_processing_lib/proto_scrubber/field_checker_interface.h:77:29: warning: ‘virtual proto_processing_lib::proto_scrubber::FieldCheckResults proto_processing_lib::proto_scrubber::FieldCheckerInterface::CheckField(const std::vector<std::__cxx11::basic_string<char> >&, const google::protobuf::Field*, int, const google::protobuf::Type*) const’ was hidden [-Woverloaded-virtual=]
77 | virtual FieldCheckResults CheckField(
| ^~~~~~~~~~
./source/extensions/filters/http/proto_api_scrubber/scrubbing_util_lib/field_checker.h:40:21: note: by ‘virtual proto_processing_lib::proto_scrubber::FieldCheckResults Envoy::Extensions::HttpFilters::ProtoApiScrubber::FieldChecker::CheckField(const std::vector<std::__cxx11::basic_string<char> >&, const google::protobuf::Field*) const’
40 | FieldCheckResults CheckField(const std::vector<std::string>& path,
| ^~~~~~~~~~
```
Risk Level: No behavior change.
Testing: No behavior change.
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a
Signed-off-by: Raven Black <[email protected]>1 parent f3e9ece commit 87eb239
File tree
1 file changed
+4
-0
lines changed- source/extensions/filters/http/proto_api_scrubber/scrubbing_util_lib
1 file changed
+4
-0
lines changedLines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
36 | 40 | | |
37 | 41 | | |
38 | 42 | | |
| |||
0 commit comments